Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8254318: Remove .hgtags #6748

Closed
wants to merge 1 commit into from

Conversation

shipilev
Copy link
Contributor

@shipilev shipilev commented Dec 7, 2021

After migration to Git, this file serves no purpose. The file is not updated, does not seem to be used. We waited for a year to make sure Mercurial repos are completely dead for everyone in mainline development. Removing this file before JDK 18 fork keeps more repositories clean :)


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/6748/head:pull/6748
$ git checkout pull/6748

Update a local copy of the PR:
$ git checkout pull/6748
$ git pull https://git.openjdk.java.net/jdk pull/6748/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 6748

View PR using the GUI difftool:
$ git pr show -t 6748

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/6748.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Dec 7, 2021

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Dec 7, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Dec 7, 2021

@shipilev The following label will be automatically applied to this pull request:

  • build

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the build label Dec 7, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Dec 7, 2021

Webrevs

erikj79
erikj79 approved these changes Dec 8, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Dec 8, 2021

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8254318: Remove .hgtags

Reviewed-by: erikj, xliu

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 70 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Dec 8, 2021
@shipilev
Copy link
Contributor Author

@shipilev shipilev commented Dec 8, 2021

Trivial, right? No need for a second Reviewer?

@shipilev
Copy link
Contributor Author

@shipilev shipilev commented Dec 9, 2021

Thanks!

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Dec 9, 2021

Going to push as commit 62a7f5d.
Since your change was applied there have been 82 commits pushed to the master branch:

  • d170682: 8278466: "spurious markup" warnings in snippets when building docs-reference
  • 8ef1a23: 8278311: Debian packaging doesn't work
  • 3524355: 8277882: New subnode ideal optimization: converting "c0 - (x + c1)" into "(c0 - c1) - x"
  • 83e6a4c: 8255409: Support the new C_GetInterfaceList, C_GetInterface, and C_SessionCancel APIs in PKCS#11 v3.0
  • 3cec700: 8278463: [test] Serialization WritePrimitive test revised for readFully test fails
  • 03bf55f: 8277980: ObjectMethods::bootstrap throws NPE when lookup is null
  • 3893f4f: 8278330: dump stack trace if the jvmti test nsk/jvmti/GetThreadState/thrstat002 is failed with wrong thread state
  • b3faecf: 8276116: C2: optimize long range checks in int counted loops
  • fe2ae8e: 8276904: Optional.toString() is unnecessarily expensive
  • 6e7b7f3: 8278251: Enable "missing-explicit-ctor" check in the jdk.unsupported.desktop module
  • ... and 72 more: https://git.openjdk.java.net/jdk/compare/f180a4591f52d0af0c030aa85be33c51b06c90ee...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Dec 9, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Dec 9, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Dec 9, 2021

@shipilev Pushed as commit 62a7f5d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@shipilev shipilev deleted the JDK-8254318-remove-hgtags branch Dec 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build integrated
3 participants