8254798: Deprecate for removal an empty finalize() methods in java.desktop module

[mrserb]

The java.desktop module has a few implementations of the finalize() method which do nothing. We can remove such methods if the class is not public API, and could mark these methods in the public classes as "forRemoval = true"

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Testing

	Linux x64	Windows x64	macOS x64
Build	✔️ (5/5 passed)	✔️ (2/2 passed)	✔️ (2/2 passed)
Test (tier1)	✔️ (9/9 passed)	✔️ (9/9 passed)	✔️ (9/9 passed)

Issue

• JDK-8254798: Deprecate for removal an empty finalize() methods in java.desktop module

Reviewers

• Kevin Rushforth (@kevinrushforth - Author)
• Pankaj Bansal (@pankaj-bansal - Reviewer)

Download

$ git fetch https://git.openjdk.java.net/jdk pull/675/head:pull/675
$ git checkout pull/675

[bridgekeeper]

👋 Welcome back serb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@mrserb The following labels will be automatically applied to this pull request:

• 2d
• sound

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

[mrserb]

/csr

[openjdk]

@mrserb this pull request will not be integrated until the CSR request JDK-8254808 for issue JDK-8254798 has been approved.

[mlbridge]

Webrevs

• 00: Full (4903668)

[openjdk]

@mrserb This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8254798: Deprecate for removal an empty finalize() methods in java.desktop module

Reviewed-by: kcr, pbansal

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 28 new commits pushed to the master branch:

• 83ea863: 8253559: The INDEX page should link to Serialized Form and Constant Values pages
• e66c6bb: 8254349: The TestNoScreenMenuBar test should be updated
• 402d01a: 8254795: Remove obsolete template files
• 07ec35e: 8254623: gc/g1/TestHumongousConcurrentStartUndo.java still fails sometimes
• 0570cc1: 8254855: Clean up and remove unused code in vmIntrinsics
• 1742c44: 8254695: G1: Next mark bitmap clear not cancelled after marking abort
• 34583eb: 8254161: Prevent instantiation of EnumSet subclasses through deserialization
• 3d23bd8: 8254814: [Vector API] Fix an AVX512 crash after JDK-8223347
• 7c0d417: 8251535: Partial peeling at unsigned test adds incorrect loop exit check
• 5145bed: 8254125: Assertion in cppVtables.cpp during builds on 32bit Windows
• ... and 18 more: https://git.openjdk.java.net/jdk/compare/03fa733e8b22eeeda8b381e33a6437bd03a28ac0...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[mrserb]

/integrate

[openjdk]

@mrserb Since your change was applied there have been 32 commits pushed to the master branch:

• 272bb5d: 8253455: Record Classes javax.lang.model changes
• c17d585: 8246774: implement Record Classes as a standard feature in Java
• 0b3e6c5: 8194126: Regression automated Test '/open/test/jdk/javax/swing/JColorChooser/Test7194184.java' fails
• ce1aac1: 8028707: javax/swing/JComboBox/6236162/bug6236162.java fails on azure
• 83ea863: 8253559: The INDEX page should link to Serialized Form and Constant Values pages
• e66c6bb: 8254349: The TestNoScreenMenuBar test should be updated
• 402d01a: 8254795: Remove obsolete template files
• 07ec35e: 8254623: gc/g1/TestHumongousConcurrentStartUndo.java still fails sometimes
• 0570cc1: 8254855: Clean up and remove unused code in vmIntrinsics
• 1742c44: 8254695: G1: Next mark bitmap clear not cancelled after marking abort
• ... and 22 more: https://git.openjdk.java.net/jdk/compare/03fa733e8b22eeeda8b381e33a6437bd03a28ac0...master

Your commit was automatically rebased without conflicts.

Pushed as commit dd032b7.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.