Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8254798: Deprecate for removal an empty finalize() methods in java.desktop module #675

Closed
wants to merge 2 commits into from
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
@@ -1,5 +1,5 @@
/*
* Copyright (c) 1999, 2019, Oracle and/or its affiliates. All rights reserved.
* Copyright (c) 1999, 2020, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
@@ -478,12 +478,6 @@ public final MidiDevice getMidiDevice() {
final boolean isOpen() {
return open;
}

//$$fb is that a good idea?
//protected void finalize() {
// close();
//}

} // class AbstractReceiver


@@ -759,7 +759,8 @@ public void activate() throws ProfileDataException {
* Object#finalize()} for further information about migration
* options.
*/
@Deprecated(since="9")
@Deprecated(since = "9", forRemoval = true)
@SuppressWarnings("removal")
protected void finalize () {
}

@@ -1,5 +1,5 @@
/*
* Copyright (c) 1995, 2018, Oracle and/or its affiliates. All rights reserved.
* Copyright (c) 1995, 2020, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
@@ -1630,7 +1630,8 @@ public boolean isCompatibleSampleModel(SampleModel sm) {
* See the specification for {@link Object#finalize()} for further
* information about migration options.
*/
@Deprecated(since="9")
@Deprecated(since = "9", forRemoval = true)
@SuppressWarnings("removal")
public void finalize() {
}

@@ -1,5 +1,5 @@
/*
* Copyright (c) 1995, 2018, Oracle and/or its affiliates. All rights reserved.
* Copyright (c) 1995, 2020, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
@@ -1524,7 +1524,8 @@ public BigInteger getValidPixels() {
* See the specification for {@link Object#finalize()} for further
* information about migration options.
*/
@Deprecated(since="9")
@Deprecated(since = "9", forRemoval = true)
@SuppressWarnings("removal")
public void finalize() {
}

@@ -1,5 +1,5 @@
/*
* Copyright (c) 1999, 2018, Oracle and/or its affiliates. All rights reserved.
* Copyright (c) 1999, 2020, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
@@ -377,15 +377,4 @@ public void skipDownTo(int y) {
public long getNativeIterator() {
return 0;
}

/*
* Cleans out all internal data structures.
*/
//public native void dispose();

@SuppressWarnings("deprecation")
protected void finalize() {
//dispose();
}

}
@@ -1,5 +1,5 @@
/*
* Copyright (c) 1999, 2018, Oracle and/or its affiliates. All rights reserved.
* Copyright (c) 1999, 2020, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
@@ -47,17 +47,6 @@
// Is the associated Region rectangular?
boolean isrect;

/*
REMIND: For native implementation
long pData; // Private storage of rect info
static {
initIDs();
}
public static native void initIDs();
*/

/**
* Constructs an instance based on the given Region
*/
@@ -197,14 +186,4 @@ public void skipDownTo(int y) {
public long getNativeIterator() {
return 0;
}

/*
* Cleans out all internal data structures.
* REMIND: Native implementation
public native void dispose();
protected void finalize() {
dispose();
}
*/
}