8277998: runtime/cds/appcds/loaderConstraints/DynamicLoaderConstraintsTest.java#custom-cl-zgc failed "assert(ZAddress::is_marked(addr)) failed: Should be marked"

[calvinccheung]

This fix is to ensure the classes created from LambdaFormInvokers::reload_class (being renamed to LambdaFormInvokers::regenerate_class) are being kept alive by adding them into an array of OopHandle.
Cleanup of the array is done for dynamic CDS dump only because for static dump, the VM will exit right after dumping a CDS archive.

Testing in progress: CI mach5 tiers 1-4.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8277998: runtime/cds/appcds/loaderConstraints/DynamicLoaderConstraintsTest.java#custom-cl-zgc failed "assert(ZAddress::is_marked(addr)) failed: Should be marked"

Reviewers

• Ioi Lam (@iklam - Reviewer)
• Yumin Qi (@yminqi - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/6751/head:pull/6751
$ git checkout pull/6751

Update a local copy of the PR:
$ git checkout pull/6751
$ git pull https://git.openjdk.java.net/jdk pull/6751/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 6751

View PR using the GUI difftool:
$ git pr show -t 6751

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/6751.diff

[bridgekeeper]

👋 Welcome back ccheung! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[calvinccheung]

/label add hotspot-runtime

[openjdk]

@calvinccheung
The hotspot-runtime label was successfully added.

[mlbridge]

Webrevs

• 00: Full (a9b3c114)

[iklam]

LGTM

[openjdk]

@calvinccheung This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8277998: runtime/cds/appcds/loaderConstraints/DynamicLoaderConstraintsTest.java#custom-cl-zgc failed "assert(ZAddress::is_marked(addr)) failed: Should be marked"

Reviewed-by: iklam, minqi

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 26 new commits pushed to the master branch:

• fb6d611: 8278276: G1: Refine naming of G1GCParPhaseTimesTracker::_must_record
• d7ad546: 8276422: Add command-line option to disable finalization
• ec7cb6d: 8276447: Deprecate finalization-related methods for removal
• 3c2951f: 8275771: JDK source code contains redundant boolean operations in jdk.compiler and langtools
• 3d61372: 8278363: Create extented container test groups
• 716c2e1: 8278368: ProblemList tools/jpackage/share/MultiNameTwoPhaseTest.java on macosx-x64
• a8a1fbc: 8278068: Fix next-line modifier (snippet markup)
• 061017a: 8273175: Add @SInCE tags to the DocTree.Kind enum constants
• d7c283a: 8275233: Incorrect line number reported in exception stack trace thrown from a lambda expression
• 3955b03: 8277328: jdk/jshell/CommandCompletionTest.java failures on Windows
• ... and 16 more: https://git.openjdk.java.net/jdk/compare/f22d157e551fb28991e7713a45e63a0a8d9d2c4c...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[yminqi]

LGTM.

[calvinccheung]

Thanks @iklam and @yminqi for the review.
/integrate

[openjdk]

Going to push as commit e4852c6.
Since your change was applied there have been 36 commits pushed to the master branch:

• 37921e3: 8269258: java/net/httpclient/ManyRequestsLegacy.java failed with connection timeout
• fd8cb2d: 8278346: java/nio/file/Files/probeContentType/Basic.java fails on Linux SLES15 machine
• e5cb84e: 8278336: Use int64_t to represent byte quantities consistently in JfrObjectAllocationSample
• 54993b1: 8278309: [windows] use of uninitialized OSThread::_state
• 10e0318: 8278158: jwebserver should set request timeout
• 5dcdee4: 8262341: Refine identical code in AddI/LNode.
• b334d96: 8276964: Better indicate a snippet that could not be processed
• 30f0c64: 8277992: Add fast jdk_svc subtests to jdk:tier3
• 5266e7d: 8278379: Zero VM is broken due to UseRTMForStackLocks was not declared after JDK-8276901
• e7db581: 8277168: AArch64: Enable arraycopy partial inlining with SVE
• ... and 26 more: https://git.openjdk.java.net/jdk/compare/f22d157e551fb28991e7713a45e63a0a8d9d2c4c...master

Your commit was automatically rebased without conflicts.

[openjdk]

@calvinccheung Pushed as commit e4852c6.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.