8278379: Zero VM is broken due to UseRTMForStackLocks was not declared after JDK-8276901

[DamonFool]

Hi all,

Zero VM is broken due to UseRTMForStackLocks was not declared after JDK-8276901.
Please review this fix.

Thanks.
Best regards,
Jie

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8278379: Zero VM is broken due to UseRTMForStackLocks was not declared after JDK-8276901

Reviewers

• David Holmes (@dholmes-ora - Reviewer)
• Aleksey Shipilev (@shipilev - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/6753/head:pull/6753
$ git checkout pull/6753

Update a local copy of the PR:
$ git checkout pull/6753
$ git pull https://git.openjdk.java.net/jdk pull/6753/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 6753

View PR using the GUI difftool:
$ git pr show -t 6753

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/6753.diff

[bridgekeeper]

👋 Welcome back jiefu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@DamonFool The following label will be automatically applied to this pull request:

• hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (bb65d395)

[dholmes-ora]

Hi Jie,

This code needs to be changed for other reasons (my email has not gotten to the mailing list yet - seems to be some kind of outage), but this fix for zero seems fine.

Thanks,
David

[openjdk]

@DamonFool This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8278379: Zero VM is broken due to UseRTMForStackLocks was not declared after JDK-8276901

Reviewed-by: dholmes, shade

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 4 new commits pushed to the master branch:

• e7db581: 8277168: AArch64: Enable arraycopy partial inlining with SVE
• fb6d611: 8278276: G1: Refine naming of G1GCParPhaseTimesTracker::_must_record
• d7ad546: 8276422: Add command-line option to disable finalization
• ec7cb6d: 8276447: Deprecate finalization-related methods for removal

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[DamonFool]

Hi Jie,

This code needs to be changed for other reasons (my email has not gotten to the mailing list yet - seems to be some kind of outage), but this fix for zero seems fine.

Thanks, David

Thanks @dholmes-ora .

So do you think it's trivial?

[shipilev]

Looks fine and trivial.

[DamonFool]

Looks fine and trivial.

Thanks @shipilev .
So integrate it.

/integrate

[openjdk]

Going to push as commit 5266e7d.
Since your change was applied there have been 4 commits pushed to the master branch:

• e7db581: 8277168: AArch64: Enable arraycopy partial inlining with SVE
• fb6d611: 8278276: G1: Refine naming of G1GCParPhaseTimesTracker::_must_record
• d7ad546: 8276422: Add command-line option to disable finalization
• ec7cb6d: 8276447: Deprecate finalization-related methods for removal

Your commit was automatically rebased without conflicts.

[openjdk]

@DamonFool Pushed as commit 5266e7d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.