Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8254814: [Vector API] Fix an AVX512 crash after JDK-8223347 #676

Closed
wants to merge 1 commit into from

Conversation

@DamonFool
Copy link
Member

@DamonFool DamonFool commented Oct 15, 2020

As discussed here[1], it's time to integrate this fix.
And the original PR is here[2].

Testing:

  • All jdk/incubator/vector/ tests passed on Linux/x64 AVX512 machines

[1] #367 (comment)
[2] openjdk/panama-vector#1


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Testing

Linux x64 Windows x64 macOS x64
Build ✔️ (5/5 passed) ✔️ (2/2 passed) ✔️ (2/2 passed)
Test (tier1) ✔️ (9/9 passed) ✔️ (9/9 passed) ✔️ (9/9 passed)

Issue

  • JDK-8254814: [Vector API] Fix an AVX512 crash after JDK-8223347

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/676/head:pull/676
$ git checkout pull/676

@DamonFool
Copy link
Member Author

@DamonFool DamonFool commented Oct 15, 2020

/issue add JDK-JDK-8254814
/test
/label add hotspot-compiler
/cc hotspot-compiler

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Oct 15, 2020

👋 Welcome back jiefu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Oct 15, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Oct 15, 2020

@DamonFool This issue is referenced in the PR title - it will now be updated.

@openjdk
Copy link

@openjdk openjdk bot commented Oct 15, 2020

@DamonFool
The hotspot-compiler label was successfully added.

@openjdk
Copy link

@openjdk openjdk bot commented Oct 15, 2020

@DamonFool The hotspot-compiler label was already applied.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Oct 15, 2020

Webrevs

Copy link

@iwanowww iwanowww left a comment

Looks good.

@openjdk
Copy link

@openjdk openjdk bot commented Oct 15, 2020

@DamonFool This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8254814: [Vector API] Fix an AVX512 crash after JDK-8223347

Reviewed-by: vlivanov, thartmann, psandoz

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 11 new commits pushed to the master branch:

  • f3ce45f: 8254799: runtime/ErrorHandling/TestHeapDumpOnOutOfMemoryError.java fails with release VMs
  • cda22e3: 8254811: JDK-8254158 broke ppc64, s390 builds
  • 8ef88e5: 8249878: jfr_emergency_dump has secondary crashes
  • 3c2f5e0: 8254674: G1: Improve root location reference to dead obj verification message
  • abe5137: 8254719: ZGC: Clean up includes
  • 60159cf: 8253952: Refine ZipOutputStream.putNextEntry() to recalculate ZipEntry's compressed size
  • 9359ff0: 8252221: Use multiple workers for Parallel GC pre-touching
  • f44fc6d: 8254734: "dead loop detected" assert failure with patch from 8223051
  • 7f73474: 8254773: Remove unimplemented ciReplay::is_loaded(Klass* klass)
  • 167c192: 8254771: Remove unimplemented ciSignature::get_all_klasses
  • ... and 1 more: https://git.openjdk.java.net/jdk/compare/7e5eb493e1e3647e013ac709bc0b8601c1d27491...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Oct 15, 2020
@DamonFool
Copy link
Member Author

@DamonFool DamonFool commented Oct 16, 2020

Thanks @iwanowww , @TobiHartmann and @PaulSandoz for your review.
/integrate

@openjdk openjdk bot closed this Oct 16, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Oct 16, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Oct 16, 2020

@DamonFool Since your change was applied there have been 16 commits pushed to the master branch:

  • 7c0d417: 8251535: Partial peeling at unsigned test adds incorrect loop exit check
  • 5145bed: 8254125: Assertion in cppVtables.cpp during builds on 32bit Windows
  • bdda205: 8254369: Node::disconnect_inputs may skip precedences
  • 96bb6e7: 8251325: Miss 'L' for long value in if statement
  • 546620b: 8254192: ExtraSharedClassListFile contains extra white space at end of line
  • f3ce45f: 8254799: runtime/ErrorHandling/TestHeapDumpOnOutOfMemoryError.java fails with release VMs
  • cda22e3: 8254811: JDK-8254158 broke ppc64, s390 builds
  • 8ef88e5: 8249878: jfr_emergency_dump has secondary crashes
  • 3c2f5e0: 8254674: G1: Improve root location reference to dead obj verification message
  • abe5137: 8254719: ZGC: Clean up includes
  • ... and 6 more: https://git.openjdk.java.net/jdk/compare/7e5eb493e1e3647e013ac709bc0b8601c1d27491...master

Your commit was automatically rebased without conflicts.

Pushed as commit 3d23bd8.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants