New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JDK-8278346: java/nio/file/Files/probeContentType/Basic.java fails on Linux SLES15 machine #6761
Conversation
|
Webrevs
|
type, expectedTypes); | ||
System.err.printf("For extension " + extension | ||
+ " we got content type: %s; expected: %s%n", | ||
type, expectedTypes); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For consistency, we can pass extension
as argument, too:
System.err.printf("For extension %s we got content type: %s; expected: %s%n",
extension, type, expectedTypes);
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, I adjusted the output.
Apart from the small comment LGTM (I'm not a reviewer) |
@MBaesken This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 28 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.
|
/integrate |
Going to push as commit fd8cb2d.
Your commit was automatically rebased without conflicts. |
Hello, please review this small test adjustment.
The test java/nio/file/Files/probeContentType/Basic.java fails on a SLES15 Linux machine with this output :
Content type: application/x-bzip; expected: [application/bz2, application/x-bzip2]
Content type: application/x-genesis-rom; expected: [text/markdown]
Content type: application/x-php; expected: [text/plain, text/php]
Content type: application/x-rar; expected: [application/rar, application/vnd.rar]
java.lang.RuntimeException: Test failed!
at Basic.main(Basic.java:192)
at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:104)
at java.base/java.lang.reflect.Method.invoke(Method.java:577)
at com.sun.javatest.regtest.agent.MainWrapper$MainThread.run(MainWrapper.java:127)
at java.base/java.lang.Thread.run(Thread.java:833)
For see the strange 'application/x-genesis-rom' mapping see also
markdown files ending in .md get marked as 'application/x-genesis-rom'
https://bugs.launchpad.net/ubuntu/+source/shared-mime-info/+bug/611763
The other mappings look okay to me but sems we need to add them to the test.
Best regards, Matthias
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/6761/head:pull/6761
$ git checkout pull/6761
Update a local copy of the PR:
$ git checkout pull/6761
$ git pull https://git.openjdk.java.net/jdk pull/6761/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 6761
View PR using the GUI difftool:
$ git pr show -t 6761
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/6761.diff