Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8276819: javax/print/PrintServiceLookup/FlushCustomClassLoader.java fails to free #6778

Closed
wants to merge 1 commit into from

Conversation

mrserb
Copy link
Member

@mrserb mrserb commented Dec 9, 2021

This is an attempt to make the FlushCustomClassLoader more stable. I cannot reproduce this bug so added some improvement blindly, based on assumption that the test may fail on the slow/overloaded system.

  • The attempt limitation was removed, but the test execution time decreased to 1 minute
  • For each attempt the generation of OOM was added to make sure that the GC was triggered

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8276819: javax/print/PrintServiceLookup/FlushCustomClassLoader.java fails to free

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/6778/head:pull/6778
$ git checkout pull/6778

Update a local copy of the PR:
$ git checkout pull/6778
$ git pull https://git.openjdk.java.net/jdk pull/6778/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 6778

View PR using the GUI difftool:
$ git pr show -t 6778

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/6778.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Dec 9, 2021

👋 Welcome back serb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

@openjdk openjdk bot commented Dec 9, 2021

@mrserb The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the client label Dec 9, 2021
@mrserb mrserb marked this pull request as ready for review Dec 9, 2021
@openjdk openjdk bot added the rfr label Dec 9, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Dec 9, 2021

Webrevs

@openjdk
Copy link

@openjdk openjdk bot commented Dec 10, 2021

@mrserb This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8276819: javax/print/PrintServiceLookup/FlushCustomClassLoader.java fails to free

Reviewed-by: psadhukhan, aivanov

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 20 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Dec 10, 2021
@mrserb
Copy link
Member Author

@mrserb mrserb commented Dec 12, 2021

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Dec 12, 2021

Going to push as commit 7c2c585.
Since your change was applied there have been 31 commits pushed to the master branch:

  • db68a0c: 8276766: Enable jar and jmod to produce deterministic timestamped content
  • 6eb6ec0: 8278525: Additional -Wnonnull errors happen with GCC 11
  • 81c56c7: 8278456: Define jtreg jdk_desktop test group time-based sub-tasks for use by headful testing.
  • 61736f8: Merge
  • 0602f4c: 8277621: ARM32: multiple fastdebug failures with "bad AD file" after JDK-8276162
  • 3df8dc4: 8278538: Test langtools/jdk/javadoc/tool/CheckManPageOptions.java fails after the manpage was updated
  • ed5d53a: 8273179: Update nroff pages in JDK 18 before RC
  • afd065b: 8278415: [TESTBUG] vmTestbase/nsk/stress/stack/stack018.java fails with "java.lang.Error: TEST_RFE"
  • 4f594e6: 8278381: [GCC 11] Address::make_raw() does not initialize rspec
  • 8eb453b: 8277072: ObjectStreamClass caches keep ClassLoaders alive
  • ... and 21 more: https://git.openjdk.java.net/jdk/compare/352435581e4354741684d66df8a33b1fbdb96162...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Dec 12, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Dec 12, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Dec 12, 2021

@mrserb Pushed as commit 7c2c585.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client integrated
3 participants