Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8278456: Define jtreg jdk_desktop test group time-based sub-tasks for use by headful testing. #6784

Closed
wants to merge 1 commit into from

Conversation

prrace
Copy link
Contributor

@prrace prrace commented Dec 9, 2021

Define part1/part2/part3 for client jtreg tests as done for some other areas
See the bug report for some numbers on the potential benefits of this for faster testing.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8278456: Define jtreg jdk_desktop test group time-based sub-tasks for use by headful testing.

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/6784/head:pull/6784
$ git checkout pull/6784

Update a local copy of the PR:
$ git checkout pull/6784
$ git pull https://git.openjdk.java.net/jdk pull/6784/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 6784

View PR using the GUI difftool:
$ git pr show -t 6784

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/6784.diff

@prrace
Copy link
Contributor Author

prrace commented Dec 9, 2021

/label add client

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 9, 2021

👋 Welcome back prr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added rfr Pull request is ready for review client client-libs-dev@openjdk.org labels Dec 9, 2021
@openjdk
Copy link

openjdk bot commented Dec 9, 2021

@prrace
The client label was successfully added.

@mlbridge
Copy link

mlbridge bot commented Dec 9, 2021

Webrevs

@openjdk
Copy link

openjdk bot commented Dec 9, 2021

@prrace This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8278456: Define jtreg jdk_desktop test group time-based sub-tasks for use by headful testing.

Reviewed-by: serb, aivanov, psadhukhan

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 30 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Dec 9, 2021
@prrace
Copy link
Contributor Author

prrace commented Dec 10, 2021

/integrate

@openjdk
Copy link

openjdk bot commented Dec 10, 2021

Going to push as commit 81c56c7.
Since your change was applied there have been 40 commits pushed to the master branch:

  • 61736f8: Merge
  • 0602f4c: 8277621: ARM32: multiple fastdebug failures with "bad AD file" after JDK-8276162
  • 3df8dc4: 8278538: Test langtools/jdk/javadoc/tool/CheckManPageOptions.java fails after the manpage was updated
  • ed5d53a: 8273179: Update nroff pages in JDK 18 before RC
  • afd065b: 8278415: [TESTBUG] vmTestbase/nsk/stress/stack/stack018.java fails with "java.lang.Error: TEST_RFE"
  • 4f594e6: 8278381: [GCC 11] Address::make_raw() does not initialize rspec
  • 8eb453b: 8277072: ObjectStreamClass caches keep ClassLoaders alive
  • 3e0b083: 8278533: Remove some unused methods in c1_Instruction and c1_ValueMap
  • aed3ea2: 8277634: Incorrect method name in invokedynamic
  • 539fbbf: 8278532: Fix some typos in compiler comments
  • ... and 30 more: https://git.openjdk.java.net/jdk/compare/42d9b1baac25df649a8d575f5ffa3a0d5b8e7ed0...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Dec 10, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 10, 2021
@openjdk
Copy link

openjdk bot commented Dec 10, 2021

@prrace Pushed as commit 81c56c7.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client client-libs-dev@openjdk.org integrated Pull request has been integrated
4 participants