Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8278525: Additional -Wnonnull errors happen with GCC 11 #6788

Closed
wants to merge 1 commit into from

Conversation

lutkerd
Copy link
Contributor

@lutkerd lutkerd commented Dec 9, 2021

8271515 introduced more issues with xmm0


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8278525: Additional -Wnonnull errors happen with GCC 11

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/6788/head:pull/6788
$ git checkout pull/6788

Update a local copy of the PR:
$ git checkout pull/6788
$ git pull https://git.openjdk.java.net/jdk pull/6788/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 6788

View PR using the GUI difftool:
$ git pr show -t 6788

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/6788.diff

8271515 introduced more issues with xmm0
@bridgekeeper
Copy link

bridgekeeper bot commented Dec 9, 2021

👋 Welcome back lutkerd! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 9, 2021
@openjdk
Copy link

openjdk bot commented Dec 9, 2021

@lutkerd The following label will be automatically applied to this pull request:

  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-compiler hotspot-compiler-dev@openjdk.org label Dec 9, 2021
@mlbridge
Copy link

mlbridge bot commented Dec 9, 2021

Webrevs

@merykitty
Copy link
Member

I believe an x86 version of 8276563 would solve the problem.

Copy link
Member

@phohensee phohensee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm.

@openjdk
Copy link

openjdk bot commented Dec 10, 2021

@lutkerd This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8278525: Additional -Wnonnull errors happen with GCC 11

Reviewed-by: phh, dlong

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 46 new commits pushed to the master branch:

  • 81c56c7: 8278456: Define jtreg jdk_desktop test group time-based sub-tasks for use by headful testing.
  • 61736f8: Merge
  • 0602f4c: 8277621: ARM32: multiple fastdebug failures with "bad AD file" after JDK-8276162
  • 3df8dc4: 8278538: Test langtools/jdk/javadoc/tool/CheckManPageOptions.java fails after the manpage was updated
  • ed5d53a: 8273179: Update nroff pages in JDK 18 before RC
  • afd065b: 8278415: [TESTBUG] vmTestbase/nsk/stress/stack/stack018.java fails with "java.lang.Error: TEST_RFE"
  • 4f594e6: 8278381: [GCC 11] Address::make_raw() does not initialize rspec
  • 8eb453b: 8277072: ObjectStreamClass caches keep ClassLoaders alive
  • 3e0b083: 8278533: Remove some unused methods in c1_Instruction and c1_ValueMap
  • aed3ea2: 8277634: Incorrect method name in invokedynamic
  • ... and 36 more: https://git.openjdk.java.net/jdk/compare/2478158815a9ae0466542e27562bff046d760d3e...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@phohensee, @dean-long) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Dec 10, 2021
@lutkerd
Copy link
Contributor Author

lutkerd commented Dec 10, 2021

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Dec 10, 2021
@openjdk
Copy link

openjdk bot commented Dec 10, 2021

@lutkerd
Your change (at version 16e4369) is now ready to be sponsored by a Committer.

@phohensee
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Dec 10, 2021

Going to push as commit 6eb6ec0.
Since your change was applied there have been 46 commits pushed to the master branch:

  • 81c56c7: 8278456: Define jtreg jdk_desktop test group time-based sub-tasks for use by headful testing.
  • 61736f8: Merge
  • 0602f4c: 8277621: ARM32: multiple fastdebug failures with "bad AD file" after JDK-8276162
  • 3df8dc4: 8278538: Test langtools/jdk/javadoc/tool/CheckManPageOptions.java fails after the manpage was updated
  • ed5d53a: 8273179: Update nroff pages in JDK 18 before RC
  • afd065b: 8278415: [TESTBUG] vmTestbase/nsk/stress/stack/stack018.java fails with "java.lang.Error: TEST_RFE"
  • 4f594e6: 8278381: [GCC 11] Address::make_raw() does not initialize rspec
  • 8eb453b: 8277072: ObjectStreamClass caches keep ClassLoaders alive
  • 3e0b083: 8278533: Remove some unused methods in c1_Instruction and c1_ValueMap
  • aed3ea2: 8277634: Incorrect method name in invokedynamic
  • ... and 36 more: https://git.openjdk.java.net/jdk/compare/2478158815a9ae0466542e27562bff046d760d3e...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Dec 10, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Dec 10, 2021
@openjdk
Copy link

openjdk bot commented Dec 10, 2021

@phohensee @lutkerd Pushed as commit 6eb6ec0.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-compiler hotspot-compiler-dev@openjdk.org integrated Pull request has been integrated
4 participants