Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8277481: Obsolete seldom used CDS flags #6800

Closed
wants to merge 3 commits into from
Closed

Conversation

hseigel
Copy link
Member

@hseigel hseigel commented Dec 10, 2021

Please review this change to obsolete deprecated CDS options UseSharedSpaces, RequireSharedSpaces, DynamicDumpSharedSpaces, and DumpSharedSpaces. The change was tested by running Mach5 tiers 1-2 on Linux, Mac OS, and Windows and Mach5 tiers 3-5 on Linux x64 and Windows x64.

The use of UseSharedSpaces in ps_core_common.c was tested on Mac OS x64 by temporarily removing serviceability/sa/ClhsdbPmap.java#core from the problem list.

Thanks! Harold


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/6800/head:pull/6800
$ git checkout pull/6800

Update a local copy of the PR:
$ git checkout pull/6800
$ git pull https://git.openjdk.java.net/jdk pull/6800/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 6800

View PR using the GUI difftool:
$ git pr show -t 6800

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/6800.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Dec 10, 2021

👋 Welcome back hseigel! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Dec 10, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Dec 10, 2021

@hseigel The following labels will be automatically applied to this pull request:

  • core-libs
  • hotspot
  • serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added serviceability hotspot core-libs labels Dec 10, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Dec 10, 2021

Webrevs

@AlanBateman
Copy link
Contributor

@AlanBateman AlanBateman commented Dec 10, 2021

/label remove core-libs

@openjdk openjdk bot removed the core-libs label Dec 10, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Dec 10, 2021

@AlanBateman
The core-libs label was successfully removed.

iklam
iklam approved these changes Dec 10, 2021
Copy link
Member

@iklam iklam left a comment

Looks good to me. Thanks for fixing this!

@openjdk
Copy link

@openjdk openjdk bot commented Dec 10, 2021

@hseigel This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8277481: Obsolete seldom used CDS flags

Reviewed-by: iklam, ccheung, dholmes

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 12 new commits pushed to the master branch:

  • 7c2c585: 8276819: javax/print/PrintServiceLookup/FlushCustomClassLoader.java fails to free
  • db68a0c: 8276766: Enable jar and jmod to produce deterministic timestamped content
  • 6eb6ec0: 8278525: Additional -Wnonnull errors happen with GCC 11
  • 81c56c7: 8278456: Define jtreg jdk_desktop test group time-based sub-tasks for use by headful testing.
  • 61736f8: Merge
  • 0602f4c: 8277621: ARM32: multiple fastdebug failures with "bad AD file" after JDK-8276162
  • 3df8dc4: 8278538: Test langtools/jdk/javadoc/tool/CheckManPageOptions.java fails after the manpage was updated
  • ed5d53a: 8273179: Update nroff pages in JDK 18 before RC
  • afd065b: 8278415: [TESTBUG] vmTestbase/nsk/stress/stack/stack018.java fails with "java.lang.Error: TEST_RFE"
  • 4f594e6: 8278381: [GCC 11] Address::make_raw() does not initialize rspec
  • ... and 2 more: https://git.openjdk.java.net/jdk/compare/aed3ea2043e765bf4a9ac980da2515f19855c780...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Dec 10, 2021
Copy link
Member

@calvinccheung calvinccheung left a comment

Looks good. Just one nit.

Copy link
Member

@dholmes-ora dholmes-ora left a comment

LGTM!

Thanks,
David

@hseigel
Copy link
Member Author

@hseigel hseigel commented Dec 13, 2021

Thanks Ioi, Calvin, and David for the reviews!

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Dec 13, 2021

Going to push as commit 14f7385.
Since your change was applied there have been 15 commits pushed to the master branch:

  • 23fd9f1: 8271079: JavaFileObject#toUri and multi-release jars
  • ccdb9f1: 8278482: G1: Improve HeapRegion::block_is_obj
  • 8b5ff4b: 8278344: sun/security/pkcs12/KeytoolOpensslInteropTest.java test fails because of different openssl output
  • 7c2c585: 8276819: javax/print/PrintServiceLookup/FlushCustomClassLoader.java fails to free
  • db68a0c: 8276766: Enable jar and jmod to produce deterministic timestamped content
  • 6eb6ec0: 8278525: Additional -Wnonnull errors happen with GCC 11
  • 81c56c7: 8278456: Define jtreg jdk_desktop test group time-based sub-tasks for use by headful testing.
  • 61736f8: Merge
  • 0602f4c: 8277621: ARM32: multiple fastdebug failures with "bad AD file" after JDK-8276162
  • 3df8dc4: 8278538: Test langtools/jdk/javadoc/tool/CheckManPageOptions.java fails after the manpage was updated
  • ... and 5 more: https://git.openjdk.java.net/jdk/compare/aed3ea2043e765bf4a9ac980da2515f19855c780...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Dec 13, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Dec 13, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Dec 13, 2021

@hseigel Pushed as commit 14f7385.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot integrated serviceability
5 participants