Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8278275: Initial nroff manpage generation for JDK 19 #6811

Closed
wants to merge 1 commit into from

Conversation

dholmes-ora
Copy link
Member

@dholmes-ora dholmes-ora commented Dec 13, 2021

Trivial update to change the version to 19-ea, and update the single reference to the "current release".

Content changes for 19 will follow.

Thanks,
David


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8278275: Initial nroff manpage generation for JDK 19

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/6811/head:pull/6811
$ git checkout pull/6811

Update a local copy of the PR:
$ git checkout pull/6811
$ git pull https://git.openjdk.java.net/jdk pull/6811/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 6811

View PR using the GUI difftool:
$ git pr show -t 6811

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/6811.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 13, 2021

👋 Welcome back dholmes! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@dholmes-ora dholmes-ora changed the title 8278275:Initial nroff manpage generation for JDK 19 8278275: Initial nroff manpage generation for JDK 19 Dec 13, 2021
@openjdk
Copy link

openjdk bot commented Dec 13, 2021

@dholmes-ora The following labels will be automatically applied to this pull request:

  • compiler
  • core-libs
  • hotspot-jfr
  • javadoc
  • kulla
  • net
  • serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added javadoc serviceability core-libs net compiler kulla hotspot-jfr rfr labels Dec 13, 2021
@dholmes-ora
Copy link
Member Author

dholmes-ora commented Dec 13, 2021

/label remove compiler core-libs hotspot-jfr javadoc kulla net serviceability

@openjdk openjdk bot removed compiler core-libs hotspot-jfr javadoc kulla net serviceability labels Dec 13, 2021
@openjdk
Copy link

openjdk bot commented Dec 13, 2021

@dholmes-ora
The compiler label was successfully removed.

The core-libs label was successfully removed.

The hotspot-jfr label was successfully removed.

The javadoc label was successfully removed.

The kulla label was successfully removed.

The net label was successfully removed.

The serviceability label was successfully removed.

@dholmes-ora
Copy link
Member Author

dholmes-ora commented Dec 13, 2021

/label add build

@openjdk openjdk bot added the build label Dec 13, 2021
@openjdk
Copy link

openjdk bot commented Dec 13, 2021

@dholmes-ora
The build label was successfully added.

@dholmes-ora
Copy link
Member Author

dholmes-ora commented Dec 13, 2021

This "mechanical" update is just being sent to the build mailing list for review.

Paging @jonathan-gibbons too :)

@mlbridge
Copy link

mlbridge bot commented Dec 13, 2021

Webrevs

Copy link
Member

@erikj79 erikj79 left a comment

Looks good to me.

@openjdk
Copy link

openjdk bot commented Dec 13, 2021

@dholmes-ora This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8278275: Initial nroff manpage generation for JDK 19

Reviewed-by: erikj, jjg, iris

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 6 new commits pushed to the master branch:

  • ca8c58c: 8259610: VectorReshapeTests are not effective due to failing to intrinsify "VectorSupport.convert"
  • 15996e4: 8276241: JVM does not flag constant class entries ending in '/'
  • 14f7385: 8277481: Obsolete seldom used CDS flags
  • 23fd9f1: 8271079: JavaFileObject#toUri and multi-release jars
  • ccdb9f1: 8278482: G1: Improve HeapRegion::block_is_obj
  • 8b5ff4b: 8278344: sun/security/pkcs12/KeytoolOpensslInteropTest.java test fails because of different openssl output

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Dec 13, 2021
@dholmes-ora
Copy link
Member Author

dholmes-ora commented Dec 13, 2021

Thanks for the reviews Erik, Jon and Iris!

/integrate

@openjdk
Copy link

openjdk bot commented Dec 13, 2021

Going to push as commit 624f309.
Since your change was applied there have been 8 commits pushed to the master branch:

  • bdc784c: 8278630: ProblemList compiler/vectorapi/reshape/TestVectorCastAVX512.java on X64
  • db502d3: 8269556: sun/tools/jhsdb/JShellHeapDumpTest.java fails with RuntimeException 'JShellToolProvider' missing from stdout/stderr
  • ca8c58c: 8259610: VectorReshapeTests are not effective due to failing to intrinsify "VectorSupport.convert"
  • 15996e4: 8276241: JVM does not flag constant class entries ending in '/'
  • 14f7385: 8277481: Obsolete seldom used CDS flags
  • 23fd9f1: 8271079: JavaFileObject#toUri and multi-release jars
  • ccdb9f1: 8278482: G1: Improve HeapRegion::block_is_obj
  • 8b5ff4b: 8278344: sun/security/pkcs12/KeytoolOpensslInteropTest.java test fails because of different openssl output

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Dec 13, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Dec 13, 2021
@openjdk
Copy link

openjdk bot commented Dec 13, 2021

@dholmes-ora Pushed as commit 624f309.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@dholmes-ora dholmes-ora deleted the 8278275 branch Dec 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build integrated
4 participants