Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8278643: CoreUtils.getCoreFileLocation() should print out the size of the core file found #6822

Closed
wants to merge 1 commit into from

Conversation

plummercj
Copy link
Contributor

@plummercj plummercj commented Dec 14, 2021

Include the size of the core file when printing a message that it was found.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8278643: CoreUtils.getCoreFileLocation() should print out the size of the core file found

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/6822/head:pull/6822
$ git checkout pull/6822

Update a local copy of the PR:
$ git checkout pull/6822
$ git pull https://git.openjdk.java.net/jdk pull/6822/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 6822

View PR using the GUI difftool:
$ git pr show -t 6822

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/6822.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Dec 14, 2021

👋 Welcome back cjplummer! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@plummercj
Copy link
Contributor Author

@plummercj plummercj commented Dec 14, 2021

/label add serviceability

@openjdk openjdk bot added rfr serviceability labels Dec 14, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Dec 14, 2021

@plummercj
The serviceability label was successfully added.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Dec 14, 2021

Webrevs

@openjdk
Copy link

@openjdk openjdk bot commented Dec 14, 2021

@plummercj This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8278643: CoreUtils.getCoreFileLocation() should print out the size of the core file found

Reviewed-by: amenkov, lmesnik, sspitsyn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 6 new commits pushed to the master branch:

  • 3f9638d: 8278585: Drop unused code from OSThread
  • 8401a05: Merge
  • c93b24d: 8132785: java/lang/management/ThreadMXBean/ThreadLists.java fails intermittently
  • 9a1bbaf: 8273108: RunThese24H crashes with SEGV in markWord::displaced_mark_helper() after JDK-8268276
  • 9b99cbe: 8278580: ProblemList javax/swing/JTree/4908142/bug4908142.java on macosx-x64
  • 94127f4: 8277299: STACK_OVERFLOW in Java_sun_awt_shell_Win32ShellFolder2_getIconBits

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Dec 14, 2021
@plummercj
Copy link
Contributor Author

@plummercj plummercj commented Dec 15, 2021

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Dec 15, 2021

Going to push as commit 54c9a99.
Since your change was applied there have been 15 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated label Dec 15, 2021
@openjdk openjdk bot closed this Dec 15, 2021
@openjdk openjdk bot removed ready rfr labels Dec 15, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Dec 15, 2021

@plummercj Pushed as commit 54c9a99.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@plummercj plummercj deleted the 8278643-corefile_size branch Dec 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated serviceability
4 participants