Skip to content

8278756: Parallel: Drop PSOldGen::_reserved #6829

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
albertnetymk wants to merge 1 commit into from
Closed

8278756: Parallel: Drop PSOldGen::_reserved #6829

albertnetymk wants to merge 1 commit into from

Conversation

@albertnetymk
Copy link
Member

@albertnetymk albertnetymk commented Dec 14, 2021 •
edited by openjdk bot
Loading

Simple change of removing PSOldGen::_reserved and constructing reserved mem region on the fly.

Test: hotspot_gc, tier1-3

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/6829/head:pull/6829
$ git checkout pull/6829

Update a local copy of the PR:
$ git checkout pull/6829
$ git pull https://git.openjdk.java.net/jdk pull/6829/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 6829

View PR using the GUI difftool:
$ git pr show -t 6829

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/6829.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 14, 2021

👋 Welcome back ayang! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 14, 2021
@openjdk
Copy link

openjdk bot commented Dec 14, 2021

@albertnetymk The following label will be automatically applied to this pull request:

  • hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-gc hotspot-gc-dev@openjdk.org label Dec 14, 2021
@mlbridge
Copy link

mlbridge bot commented Dec 14, 2021

Webrevs

tschatzl
tschatzl suggested changes Dec 15, 2021
View reviewed changes
Copy link
Contributor

@tschatzl tschatzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but worried about the SA changes. Please confirm that tier4/5 are good.

src/hotspot/share/gc/parallel/vmStructs_parallelgc.hpp
nonstatic_field(PSYoungGen, _min_gen_size, const size_t) \
nonstatic_field(PSYoungGen, _max_gen_size, const size_t) \
\
nonstatic_field(PSOldGen, _reserved, MemRegion) \
Copy link
Contributor

@tschatzl tschatzl Dec 15, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please test tier4/5 because of the removal of this vmStructs field to make sure that the SA agent still runs? The tests for it are in tier4 (or 5).

Copy link
Member Author

@albertnetymk albertnetymk Dec 15, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tier4-6 pass.

tschatzl
tschatzl approved these changes Dec 16, 2021
View reviewed changes
Copy link
Contributor

@tschatzl tschatzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm.

@openjdk
Copy link

openjdk bot commented Dec 16, 2021 •
edited
Loading

@albertnetymk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8278756: Parallel: Drop PSOldGen::_reserved

Reviewed-by: tschatzl, mli

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 34 new commits pushed to the master branch:

  • 0bddd8a: 8278050: Armenian text isn't rendered on macOS if text layout is performed
  • f6fbb5a: 8278471: Remove unreached rules in AddNode::IdealIL
  • 0dbe4c5: 8278131: runtime/cds/appcds/dynamicArchive/* tests failing in loom repo
  • e6b28e0: Merge
  • d3408a4: 8277964: ClassCastException with no stack trace is thrown with -Xcomp in method handle invocation
  • 69b5d49: 8272064: test/jdk/jdk/jfr/api/consumer/TestHiddenMethod.java needs update for JEP 416
  • d6b5544: 8278607: Misc issues in foreign API javadoc
  • 918e339: 8278233: [macos] tools/jpackage tests timeout due to /usr/bin/osascript
  • f48a3e8: 8278758: runtime/BootstrapMethod/BSMCalledTwice.java fails with release VMs after JDK-8262134
  • 0cc989b: 8278744: KeyStore:getAttributes() not returning unmodifiable Set
  • ... and 24 more: https://git.openjdk.java.net/jdk/compare/3f9638d124076019f49eb77bc3ff8b466e4beb53...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Dec 16, 2021
@albertnetymk
Copy link
Member Author

albertnetymk commented Dec 16, 2021

Thanks for the review.

/integrate

@openjdk
Copy link

openjdk bot commented Dec 16, 2021

Going to push as commit f15a59c.
Since your change was applied there have been 38 commits pushed to the master branch:

  • 271d26f: 8278601: Parallel: Remove redundant code in ObjectStartArray::initialize
  • e0700bf: 8278763: Parallel: Remove grows_up/grows_down in PSVirtualSpace
  • aae5639: 8278642: Refactor java.util.Formatter
  • 7edcd34: 8278534: Remove some unnecessary code in MethodLiveness::init_basic_blocks
  • 0bddd8a: 8278050: Armenian text isn't rendered on macOS if text layout is performed
  • f6fbb5a: 8278471: Remove unreached rules in AddNode::IdealIL
  • 0dbe4c5: 8278131: runtime/cds/appcds/dynamicArchive/* tests failing in loom repo
  • e6b28e0: Merge
  • d3408a4: 8277964: ClassCastException with no stack trace is thrown with -Xcomp in method handle invocation
  • 69b5d49: 8272064: test/jdk/jdk/jfr/api/consumer/TestHiddenMethod.java needs update for JEP 416
  • ... and 28 more: https://git.openjdk.java.net/jdk/compare/3f9638d124076019f49eb77bc3ff8b466e4beb53...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 16, 2021
@openjdk openjdk bot closed this Dec 16, 2021
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 16, 2021
@openjdk
Copy link

openjdk bot commented Dec 16, 2021

@albertnetymk Pushed as commit f15a59c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@albertnetymk albertnetymk deleted the ps-reserve branch December 16, 2021 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@Hamlin-Li Hamlin-Li Hamlin-Li approved these changes

@tschatzl tschatzl tschatzl approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

hotspot-gc hotspot-gc-dev@openjdk.org integrated Pull request has been integrated

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@albertnetymk @Hamlin-Li @tschatzl