Skip to content

Conversation

@zhengyu123
Copy link
Contributor

@zhengyu123 zhengyu123 commented Dec 14, 2021

Please review this trivial patch that removes unused ShenandoahRootScanner class.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8278767: Shenandoah: Remove unused ShenandoahRootScanner

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/6832/head:pull/6832
$ git checkout pull/6832

Update a local copy of the PR:
$ git checkout pull/6832
$ git pull https://git.openjdk.java.net/jdk pull/6832/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 6832

View PR using the GUI difftool:
$ git pr show -t 6832

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/6832.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 14, 2021

👋 Welcome back zgu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Dec 14, 2021

@zhengyu123 The following labels will be automatically applied to this pull request:

  • hotspot-gc
  • shenandoah

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added hotspot-gc hotspot-gc-dev@openjdk.org shenandoah shenandoah-dev@openjdk.org labels Dec 14, 2021
@zhengyu123 zhengyu123 marked this pull request as ready for review December 14, 2021 14:55
@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 14, 2021
@mlbridge
Copy link

mlbridge bot commented Dec 14, 2021

Webrevs

Copy link
Contributor

@rkennke rkennke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and trivial! Thanks!

@openjdk
Copy link

openjdk bot commented Dec 14, 2021

@zhengyu123 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8278767: Shenandoah: Remove unused ShenandoahRootScanner

Reviewed-by: rkennke

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Dec 14, 2021
@zhengyu123
Copy link
Contributor Author

/integrate

@zhengyu123
Copy link
Contributor Author

Thanks, @rkennke

@openjdk
Copy link

openjdk bot commented Dec 14, 2021

Going to push as commit de65230.
Since your change was applied there have been 3 commits pushed to the master branch:

  • a9c1acb: 8275843: Random crashes while the UI code is executed
  • 3f91948: 8278791: Rename ClassLoaderData::holder_phantom
  • 7761a3e: 8278761: Parallel: Remove unused PSOldPromotionLAB constructor

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Dec 14, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 14, 2021
@openjdk
Copy link

openjdk bot commented Dec 14, 2021

@zhengyu123 Pushed as commit de65230.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hotspot-gc hotspot-gc-dev@openjdk.org integrated Pull request has been integrated shenandoah shenandoah-dev@openjdk.org

Development

Successfully merging this pull request may close these issues.

2 participants