8254827: JVMCI: Enable it for Windows+AArch64 #685

lewurm · 2020-10-15T15:00:47Z

Use r18 as allocatable register on Linux only.

A bootstrap works now (it has been crashing before due to r18 being allocated):

$ ./windows-aarch64-server-fastdebug/bin/java.exe -XX:+UnlockExperimentalVMOptions -XX:+UseJVMCICompiler -XX:+BootstrapJVMCI -version
Bootstrapping JVMCI................................. in 17990 ms
(compiled 3330 methods)
openjdk version "16-internal" 2021-03-16
OpenJDK Runtime Environment (fastdebug build 16-internal+0-adhoc.NORTHAMERICAbeurba.openjdk-jdk)
OpenJDK 64-Bit Server VM (fastdebug build 16-internal+0-adhoc.NORTHAMERICAbeurba.openjdk-jdk, mixed mode)

Jtreg tests test/hotspot/jtreg/compiler/jvmci are passing as well.

Progress

Change must not contain extraneous whitespace
Commit message must refer to an issue
Change must be properly reviewed

Testing

	Linux x32	Linux x64	Windows x64	macOS x64
Build	✔️ (1/1 passed)	✔️ (5/5 passed)	✔️ (2/2 passed)	✔️ (2/2 passed)
Test (tier1)		✔️ (9/9 passed)	❌ (1/9 failed)	✔️ (9/9 passed)

Failed test task

Windows x64 (hs/tier1 compiler)

Issue

JDK-8254827: JVMCI: Enable it for Windows+AArch64

Reviewers

Magnus Ihse Bursie (@magicus - Reviewer) ⚠️ Review applies to 593dfdd
Tom Rodriguez (@tkrodriguez - Reviewer)
Vladimir Kozlov (@vnkozlov - Reviewer)

Download

$ git fetch https://git.openjdk.java.net/jdk pull/685/head:pull/685
$ git checkout pull/685

Use r18 as allocatable register on Linux only. A bootstrap works now (it has been crashing before due to r18 being allocated): ```console $ ./windows-aarch64-server-fastdebug/bin/java.exe -XX:+UnlockExperimentalVMOptions -XX:+UseJVMCICompiler -XX:+BootstrapJVMCI -version Bootstrapping JVMCI................................. in 17990 ms (compiled 3330 methods) openjdk version "16-internal" 2021-03-16 OpenJDK Runtime Environment (fastdebug build 16-internal+0-adhoc.NORTHAMERICAbeurba.openjdk-jdk) OpenJDK 64-Bit Server VM (fastdebug build 16-internal+0-adhoc.NORTHAMERICAbeurba.openjdk-jdk, mixed mode) ``` Jtreg tests `test/hotspot/jtreg/compiler/jvmci` are passing as well.

bridgekeeper · 2020-10-15T15:01:15Z

👋 Welcome back burban! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2020-10-15T15:03:20Z

@lewurm The following labels will be automatically applied to this pull request:

build
hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

mlbridge · 2020-10-15T15:07:18Z

Webrevs

magicus

Build changes look good, but you'll need a review on the hotspot part as well.

openjdk · 2020-10-19T11:06:07Z

@lewurm This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8254827: JVMCI: Enable it for Windows+AArch64

Reviewed-by: ihse, never, kvn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 241 new commits pushed to the master branch:

c774741: 8255695: Some JVMTI calls in the jdwp debug agent are using FUNC_PTR instead of JVMTI_FUNC_PTR
bee864f: 8255766: Fix linux+arm64 build after 8254072
ceba2f8: 8255696: JDWP debug agent's canSuspendResumeThreadLists() should be removed
a250716: 8255694: memory leak in JDWP debug agent after calling JVMTI GetAllThreads
acb5f65: 8211958: Broken links in java.desktop files
bc6085b: 8255578: [JVMCI] be more careful about reflective reads of Class.componentType.
05bcd67: 8255529: Remove unused methods from java.util.zip.ZipFile
d93e3a7: 8255760: Shenandoah: match constants style in ShenandoahMarkTask fallback
3e89f72: 8255237: ZGC: Bulk free garbage pages during relocation set selection
6dac8d2: 8255671: Bidi.reorderVisually has misleading exception messages
... and 231 more: https://git.openjdk.java.net/jdk/compare/cdc8c401b50abcf75a3c8bbe2eafdd360f3aa3be...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@magicus, @tkrodriguez, @vnkozlov) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

...es/jdk.vm.ci.hotspot.aarch64/src/jdk/vm/ci/hotspot/aarch64/AArch64HotSpotRegisterConfig.java

dougxc · 2020-10-20T10:02:32Z

...es/jdk.vm.ci.hotspot.aarch64/src/jdk/vm/ci/hotspot/aarch64/AArch64HotSpotRegisterConfig.java

    public static final Register heapBaseRegister = r27;
    public static final Register threadRegister = r28;
    public static final Register fp = r29;

    private static final RegisterArray reservedRegisters = new RegisterArray(rscratch1, rscratch2, threadRegister, fp, lr, r31, zr, sp);

-    private static RegisterArray initAllocatable(Architecture arch, boolean reserveForHeapBase) {
+    private static RegisterArray initAllocatable(Architecture arch, boolean reserveForHeapBase, boolean linuxOs) {


Instead of linuxOs, canUsePlatformRegister is a better name. The logic of which OS does what belongs more in AArch64HotSpotJVMCIBackendFactory.

…mci-win-aarch64

lewurm · 2020-10-20T13:51:50Z

Thank you for your comments @dougxc 🙂

make/autoconf/jvm-features.m4

lewurm · 2020-11-02T20:34:45Z

/integrate

Thanks for the review Tom and Magnus, and for the comments to Vladimir and Doug 🙂

openjdk · 2020-11-02T20:35:48Z

@lewurm
Your change (at version 7e6cb73) is now ready to be sponsored by a Committer.

tkrodriguez · 2020-11-03T19:03:22Z

/sponsor

openjdk · 2020-11-03T19:05:03Z

@tkrodriguez @lewurm Since your change was applied there have been 270 commits pushed to the master branch:

f64a15d: 8254315: Shenandoah: Concurrent weak reference processing
83f3cf4: 8196087: java/awt/image/DrawImage/IncorrectUnmanagedImageRotatedClip.java fails
134e22a: 8255606: Enable concurrent stack processing on x86_32 platforms
ca216ba: 8255810: Zero: build fails without JVMTI
d47336b: 8248320: Provide a unique accessible name for
64a9811: 8255798: Remove dead headless code in CompileJavaModules.gmk
364b0fe: 8255801: Race when building ct.sym build tools
f389a71: 8255737: Zero: DO_UPDATE_INSTRUCTION_COUNT should only update when relevant VM flags are set
93ef009: 8255762: Shenandoah: Consolidate/streamline interpreter LRBs
63461d5: 8255072: [TESTBUG] com/sun/jdi/EATests.java should not fail if expected VMOutOfMemoryException is not thrown
... and 260 more: https://git.openjdk.java.net/jdk/compare/cdc8c401b50abcf75a3c8bbe2eafdd360f3aa3be...master

Your commit was automatically rebased without conflicts.

Pushed as commit 88ee973.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Reviewed-by: ihse, never, kvn

openjdk bot added the rfr Pull request is ready for review label Oct 15, 2020

openjdk bot added build build-dev@openjdk.org hotspot-compiler hotspot-compiler-dev@openjdk.org labels Oct 15, 2020

magicus approved these changes Oct 19, 2020

View reviewed changes

openjdk bot added the ready Pull request is ready to be integrated label Oct 19, 2020

dougxc reviewed Oct 20, 2020

View reviewed changes

lewurm added 3 commits October 20, 2020 11:31

comment for platformRegister

5319dff

rename argument to canUsePlatformRegister

28dcf57

Merge remote-tracking branch 'upstream/master' into 8254827-enable-jv…

707201f

…mci-win-aarch64

add missing precompiled.hpp include

7e6cb73

lewurm mentioned this pull request Oct 30, 2020

8255703: jaotc: Add Windows+Arm64 support #972

Closed

3 tasks

tkrodriguez approved these changes Nov 2, 2020

View reviewed changes

vnkozlov suggested changes Nov 2, 2020

View reviewed changes

make/autoconf/jvm-features.m4 Show resolved Hide resolved

vnkozlov approved these changes Nov 2, 2020

View reviewed changes

make/autoconf/jvm-features.m4 Show resolved Hide resolved

openjdk bot added the sponsor Pull request is ready to be sponsored label Nov 2, 2020

openjdk bot closed this Nov 3, 2020

openjdk bot added integrated Pull request has been integrated and removed sponsor Pull request is ready to be sponsored ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 3, 2020

openjdk-notifier bot referenced this pull request Nov 3, 2020

8254827: JVMCI: Enable it for Windows+AArch64

88ee973

Reviewed-by: ihse, never, kvn

mlbridge bot mentioned this pull request Nov 3, 2020

8255616: Disable AOT and Graal in Oracle OpenJDK #960

Closed

3 tasks

lewurm mentioned this pull request Jan 22, 2021

Merge jdk:master openjdk/aarch64-port#12

Merged

3 tasks

8254827: JVMCI: Enable it for Windows+AArch64 #685

8254827: JVMCI: Enable it for Windows+AArch64 #685

lewurm commented Oct 15, 2020 •

edited by openjdk bot

bridgekeeper bot commented Oct 15, 2020

openjdk bot commented Oct 15, 2020

mlbridge bot commented Oct 15, 2020 •

edited

magicus left a comment

openjdk bot commented Oct 19, 2020 •

edited

dougxc Oct 20, 2020

lewurm commented Oct 20, 2020

lewurm commented Nov 2, 2020

openjdk bot commented Nov 2, 2020

tkrodriguez commented Nov 3, 2020

openjdk bot commented Nov 3, 2020

8254827: JVMCI: Enable it for Windows+AArch64 #685

8254827: JVMCI: Enable it for Windows+AArch64 #685

Conversation

lewurm commented Oct 15, 2020 • edited by openjdk bot

Progress

Testing

Issue

Reviewers

Download

bridgekeeper bot commented Oct 15, 2020

openjdk bot commented Oct 15, 2020

mlbridge bot commented Oct 15, 2020 • edited

Webrevs

magicus left a comment

Choose a reason for hiding this comment

openjdk bot commented Oct 19, 2020 • edited

dougxc Oct 20, 2020

Choose a reason for hiding this comment

lewurm commented Oct 20, 2020

lewurm commented Nov 2, 2020

openjdk bot commented Nov 2, 2020

tkrodriguez commented Nov 3, 2020

openjdk bot commented Nov 3, 2020

lewurm commented Oct 15, 2020 •

edited by openjdk bot

mlbridge bot commented Oct 15, 2020 •

edited

openjdk bot commented Oct 19, 2020 •

edited