Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8278893: Parallel: Remove GCWorkerDelayMillis #6862

Conversation

tschatzl
Copy link
Contributor

@tschatzl tschatzl commented Dec 16, 2021

Hi all,

can I have reviews for this change that removes the unnecessary and unused flag develop GCWorkerDelayMillis?

Testing: local compilation, gha

Thanks,
Thomas


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/6862/head:pull/6862
$ git checkout pull/6862

Update a local copy of the PR:
$ git checkout pull/6862
$ git pull https://git.openjdk.java.net/jdk pull/6862/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 6862

View PR using the GUI difftool:
$ git pr show -t 6862

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/6862.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 16, 2021

👋 Welcome back tschatzl! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 16, 2021
@openjdk
Copy link

openjdk bot commented Dec 16, 2021

@tschatzl The following label will be automatically applied to this pull request:

  • hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-gc hotspot-gc-dev@openjdk.org label Dec 16, 2021
@mlbridge
Copy link

mlbridge bot commented Dec 16, 2021

Webrevs

@openjdk
Copy link

openjdk bot commented Dec 16, 2021

@tschatzl This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8278893: Parallel: Remove GCWorkerDelayMillis

Reviewed-by: ayang, mli

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Dec 16, 2021
@tschatzl
Copy link
Contributor Author

Thanks @albertnetymk @Hamlin-Li for your reviews.

/integrate

@openjdk
Copy link

openjdk bot commented Dec 21, 2021

Going to push as commit ff5d417.
Since your change was applied there have been 35 commits pushed to the master branch:

  • 5179672: 8278953: Clarify Class.getDeclaredConstructor specification
  • 8549d8b: 8277100: Dynamic dump can inadvertently overwrite default CDS archive
  • 4c78c9a: 8270929: Obsolete the FilterSpuriousWakeups flag in JDK 19
  • 06206c7: 8278949: Cleanups for 8277850
  • 31fbb87: 6462028: MaskFormatter API documentation refers to getDisplayValue
  • 63e4303: 8278519: serviceability/jvmti/FieldAccessWatch/FieldAccessWatch.java failed "assert(handle != __null) failed: JNI handle should not be null"
  • 6f0e8da: 8278871: [JVMCI] assert((uint)reason < 2* _trap_hist_limit) failed: oob
  • 3c10b5d: 8278104: C1 should support the compiler directive 'BreakAtExecute'
  • cc44e13: 8278623: compiler/vectorapi/reshape/TestVectorCastAVX512.java after JDK-8259610
  • 905b763: 8261404: Class.getReflectionFactory() is not thread-safe
  • ... and 25 more: https://git.openjdk.java.net/jdk/compare/0bddd8af61b6c731f16b857c09de57ceefd72d06...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 21, 2021
@openjdk openjdk bot closed this Dec 21, 2021
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 21, 2021
@openjdk
Copy link

openjdk bot commented Dec 21, 2021

@tschatzl Pushed as commit ff5d417.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@tschatzl tschatzl deleted the submit/8278893-remove-gcworkerdelaymillis branch January 27, 2022 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-gc hotspot-gc-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

3 participants