Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8278885: Remove Windows ARM64 int8_t workaround in G1 #6872

Closed
wants to merge 1 commit into from

Conversation

aamarsh
Copy link

@aamarsh aamarsh commented Dec 16, 2021

Please review this small change to revert a previous workaround that avoided an MSVC issue.

This issue has now been fixed in VS 16.8 and higher.

I also updated some documentation to reflect this change.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8278885: Remove Windows ARM64 int8_t workaround in G1

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/6872/head:pull/6872
$ git checkout pull/6872

Update a local copy of the PR:
$ git checkout pull/6872
$ git pull https://git.openjdk.java.net/jdk pull/6872/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 6872

View PR using the GUI difftool:
$ git pr show -t 6872

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/6872.diff

@bridgekeeper bridgekeeper bot added the oca Needs verification of OCA signatory status label Dec 16, 2021
@bridgekeeper
Copy link

bridgekeeper bot commented Dec 16, 2021

Hi @aamarsh, welcome to this OpenJDK project and thanks for contributing!

We do not recognize you as Contributor and need to ensure you have signed the Oracle Contributor Agreement (OCA). If you have not signed the OCA, please follow the instructions. Please fill in your GitHub username in the "Username" field of the application. Once you have signed the OCA, please let us know by writing /signed in a comment in this pull request.

If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please use "Add GitHub user aamarsh" as summary for the issue.

If you are contributing this work on behalf of your employer and your employer has signed the OCA, please let us know by writing /covered in a comment in this pull request.

@aamarsh
Copy link
Author

aamarsh commented Dec 16, 2021

/covered

@bridgekeeper bridgekeeper bot added the oca-verify Needs verification of OCA signatory status label Dec 16, 2021
@bridgekeeper
Copy link

bridgekeeper bot commented Dec 16, 2021

Thank you! Please allow for a few business days to verify that your employer has signed the OCA. Also, please note that pull requests that are pending an OCA check will not usually be evaluated, so your patience is appreciated!

@openjdk
Copy link

openjdk bot commented Dec 16, 2021

@aamarsh The following labels will be automatically applied to this pull request:

  • build
  • hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added build build-dev@openjdk.org hotspot-gc hotspot-gc-dev@openjdk.org labels Dec 16, 2021
@bridgekeeper bridgekeeper bot removed oca Needs verification of OCA signatory status oca-verify Needs verification of OCA signatory status labels Jan 13, 2022
@openjdk openjdk bot added the rfr Pull request is ready for review label Jan 13, 2022
@mlbridge
Copy link

mlbridge bot commented Jan 13, 2022

Webrevs

@openjdk
Copy link

openjdk bot commented Jan 13, 2022

@aamarsh This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8278885: Remove Windows ARM64 int8_t workaround in G1

Reviewed-by: erikj, tschatzl, mli

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 219 new commits pushed to the master branch:

  • 35172cd: 8278951: containers/cgroup/PlainRead.java fails on Ubuntu 21.10
  • 237f861: 8273143: Transition to _thread_in_vm when handling a polling page exception
  • 9209e6d: 8279877: Document IDEA IDE setup in docs/ide.md
  • 0a839b4: 8279801: EC KeyFactory and KeyPairGenerator do not have aliases for OID format
  • 6fcaa32: 8262442: (windows) Use all proxy configuration sources when java.net.useSystemProxies=true
  • c17a012: 8278961: Enable debug logging in java/net/DatagramSocket/SendDatagramToBadAddress.java
  • b61a4af: 8259774: Deprecate -XX:FlightRecorderOptions:samplethreads
  • 6933934: 8278597: Remove outdated comments regarding RMISecurityManager in HotSpotAgent.java
  • 4851948: 8279903: Redundant modulo operation in ECDHKeyAgreement
  • 67e3d51: Merge
  • ... and 209 more: https://git.openjdk.java.net/jdk/compare/197c9f5ac8cc0ebfcd9f33415b0dcd382cd8d15e...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@erikj79, @tschatzl, @Hamlin-Li) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jan 13, 2022
Copy link
Contributor

@tschatzl tschatzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GC changes look good.

@aamarsh
Copy link
Author

aamarsh commented Jan 13, 2022

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Jan 13, 2022
@openjdk
Copy link

openjdk bot commented Jan 13, 2022

@aamarsh
Your change (at version 6429bad) is now ready to be sponsored by a Committer.

Copy link

@Hamlin-Li Hamlin-Li left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@Hamlin-Li
Copy link

/sponser

@openjdk
Copy link

openjdk bot commented Jan 14, 2022

@Hamlin-Li Unknown command sponser - for a list of valid commands use /help.

@karianna
Copy link
Contributor

/sponser

I think it's sponsor

@tschatzl
Copy link
Contributor

/sponsor

@openjdk
Copy link

openjdk bot commented Jan 17, 2022

Going to push as commit 7b6738f.
Since your change was applied there have been 246 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 17, 2022
@openjdk openjdk bot closed this Jan 17, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 17, 2022
@openjdk openjdk bot removed the sponsor Pull request is ready to be sponsored label Jan 17, 2022
@openjdk
Copy link

openjdk bot commented Jan 17, 2022

@tschatzl @aamarsh Pushed as commit 7b6738f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build build-dev@openjdk.org hotspot-gc hotspot-gc-dev@openjdk.org integrated Pull request has been integrated
5 participants