8278519: serviceability/jvmti/FieldAccessWatch/FieldAccessWatch.java failed "assert(handle != __null) failed: JNI handle should not be null"

[alexmenkov]

The fix adds a check in the event handler which filters out event from non-test threads

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8278519: serviceability/jvmti/FieldAccessWatch/FieldAccessWatch.java failed "assert(handle != __null) failed: JNI handle should not be null"

Reviewers

• Chris Plummer (@plummercj - Reviewer) ⚠️ Review applies to 022a689
• Serguei Spitsyn (@sspitsyn - Reviewer) ⚠️ Review applies to 022a689

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/6874/head:pull/6874
$ git checkout pull/6874

Update a local copy of the PR:
$ git checkout pull/6874
$ git pull https://git.openjdk.java.net/jdk pull/6874/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 6874

View PR using the GUI difftool:
$ git pr show -t 6874

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/6874.diff

[bridgekeeper]

👋 Welcome back amenkov! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@alexmenkov The following label will be automatically applied to this pull request:

• serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (35a6a35a)
• 00: Full (022a689f)

[plummercj]

You need to update the copyright in libFieldAccessWatch.c. Otherwise the changes look good.

[openjdk]

@alexmenkov This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8278519: serviceability/jvmti/FieldAccessWatch/FieldAccessWatch.java failed "assert(handle != __null) failed: JNI handle should not be null"

Reviewed-by: cjplummer, sspitsyn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 65 new commits pushed to the master branch:

• 022e4f0: 8275242: Remove redundant stream() call before forEach in jdk.compiler
• 0bfc204: 8278956: Remove unimplemented PLAB::allocate_aligned
• b17f8d5: 8278954: Using clang together with devkit on linux doesn't work for building
• 769f14d: 8278384: Bytecodes::result_type() for arraylength returns T_VOID instead of T_INT
• e45e0b0: 8278937: JCK test for java_awt/geom/Line2D.Float fails after 8277868
• a68f28c: 8278909: Unproblemlist AdaptiveBlocking001
• 3607a5c: 8277216: Examine InstanceKlass::_misc_flags for concurrency issues
• abab173: 8278568: Consolidate filler objects
• 6412d57: 8278560: X509KeyManagerImpl::getAliases might return a good key with others
• 247ea71: 8278826: Print error if Shenandoah flags are empty (instead of crashing)
• ... and 55 more: https://git.openjdk.java.net/jdk/compare/624f3094b89976a0be0a1d1d4ce304f4be38fb9e...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[sspitsyn]

Looks good.
Chris already pointed to the Copyright year.
Thanks,
Serguei

[alexmenkov]

/integrate

[openjdk]

Going to push as commit 63e4303.
Since your change was applied there have been 69 commits pushed to the master branch:

• 6f0e8da: 8278871: [JVMCI] assert((uint)reason < 2* _trap_hist_limit) failed: oob
• 3c10b5d: 8278104: C1 should support the compiler directive 'BreakAtExecute'
• cc44e13: 8278623: compiler/vectorapi/reshape/TestVectorCastAVX512.java after JDK-8259610
• 905b763: 8261404: Class.getReflectionFactory() is not thread-safe
• 022e4f0: 8275242: Remove redundant stream() call before forEach in jdk.compiler
• 0bfc204: 8278956: Remove unimplemented PLAB::allocate_aligned
• b17f8d5: 8278954: Using clang together with devkit on linux doesn't work for building
• 769f14d: 8278384: Bytecodes::result_type() for arraylength returns T_VOID instead of T_INT
• e45e0b0: 8278937: JCK test for java_awt/geom/Line2D.Float fails after 8277868
• a68f28c: 8278909: Unproblemlist AdaptiveBlocking001
• ... and 59 more: https://git.openjdk.java.net/jdk/compare/624f3094b89976a0be0a1d1d4ce304f4be38fb9e...master

Your commit was automatically rebased without conflicts.

[openjdk]

@alexmenkov Pushed as commit 63e4303.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.