Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8276694: Pattern trailing unescaped backslash causes internal error #6891

Closed
wants to merge 1 commit into from

Conversation

masyano
Copy link

@masyano masyano commented Dec 20, 2021

Could you please review the 8276694 bug fixes?

A message specific for this exception should be printed instead of an internal error. This fix adds a new check to output an appropriate exception message when the regular expression ends with an unescaped backslash. This fix also checks the position of the cursor to rule out other syntax errors at the middle position of the regular expression.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8276694: Pattern trailing unescaped backslash causes internal error

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/6891/head:pull/6891
$ git checkout pull/6891

Update a local copy of the PR:
$ git checkout pull/6891
$ git pull https://git.openjdk.java.net/jdk pull/6891/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 6891

View PR using the GUI difftool:
$ git pr show -t 6891

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/6891.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Dec 20, 2021

👋 Welcome back myano! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Dec 20, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Dec 20, 2021

@masyano The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the core-libs label Dec 20, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Dec 20, 2021

Webrevs

@masyano
Copy link
Author

@masyano masyano commented Jan 5, 2022

Could someone please review this pull request?

@openjdk
Copy link

@openjdk openjdk bot commented Jan 6, 2022

@masyano This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8276694: Pattern trailing unescaped backslash causes internal error

Reviewed-by: jlaskey

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 117 new commits pushed to the master branch:

  • 62d03c2: 8279547: [vectorapi] Enable vector cast tests after JDK-8278948
  • 6a42fba: 8279258: Auto-vectorization enhancement for two-dimensional array operations
  • 8d0f385: 8279520: SPNEGO has not passed channel binding info into the underlying mechanism
  • b3dbfc6: 4884570: StreamPrintService.isAttributeValueSupported does not work properly for SheetCollate
  • 8703f14: 8273322: Enhance macro logic optimization for masked logic operations.
  • bc12381: 8279505: Update documentation for RETRY_COUNT and REPEAT_COUNT
  • 2dbb936: 8279339: (ch) Input/Output streams returned by Channels factory methods don't support concurrent read/write ops
  • 456bd1e: 8211004: javac is complaining about non-denotable types and refusing to generate the class file
  • 844dfb3: Merge
  • 564c8c6: 8279529: ProblemList java/nio/channels/DatagramChannel/ManySourcesAndTargets.java on macosx-aarch64
  • ... and 107 more: https://git.openjdk.java.net/jdk/compare/63e43030ed1260d14df950342c39a377231a3f40...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@JimLaskey) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready label Jan 6, 2022
@masyano
Copy link
Author

@masyano masyano commented Jan 7, 2022

/integrate

@openjdk openjdk bot added the sponsor label Jan 7, 2022
@openjdk
Copy link

@openjdk openjdk bot commented Jan 7, 2022

@masyano
Your change (at version 93b6f05) is now ready to be sponsored by a Committer.

@igraves
Copy link
Member

@igraves igraves commented Jan 11, 2022

Looks good to me. Sponsoring.

@igraves
Copy link
Member

@igraves igraves commented Jan 11, 2022

/sponsor

@openjdk
Copy link

@openjdk openjdk bot commented Jan 11, 2022

Going to push as commit 3aaa098.
Since your change was applied there have been 166 commits pushed to the master branch:

  • 36f41cb: 8279884: Use better file for cygwin source permission check
  • c4518e2: 8278868: Add x86 vectorization support for Long.bitCount()
  • 6714184: 8279700: Parallel: Simplify ScavengeRootsTask constructor API
  • cfee451: 8273914: Indy string concat changes order of operations
  • c3d0a94: 8279833: Loop optimization issue in String.encodeUTF8_UTF16
  • 9e02447: 8279834: Alpine Linux fails to build when --with-source-date enabled
  • 08e14c6: 8278207: G1: Tighten verification in G1ResetSkipCompactingClosure
  • c08b2ac: 8225093: Special property jdk.boot.class.path.append should not default to empty string
  • 4c52eb3: 8279669: test/jdk/com/sun/jdi/TestScaffold.java uses wrong condition
  • d46410c: 8279785: JFR: 'jfr configure' should show default values
  • ... and 156 more: https://git.openjdk.java.net/jdk/compare/63e43030ed1260d14df950342c39a377231a3f40...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated label Jan 11, 2022
@openjdk openjdk bot closed this Jan 11, 2022
@openjdk openjdk bot removed ready rfr sponsor labels Jan 11, 2022
@openjdk
Copy link

@openjdk openjdk bot commented Jan 11, 2022

@igraves @masyano Pushed as commit 3aaa098.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-libs integrated
3 participants