Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8279024: Remove javascript references from clhsdb.html #6903

Closed
wants to merge 2 commits into from

Conversation

plummercj
Copy link
Contributor

@plummercj plummercj commented Dec 21, 2021

clhsdb no longer supports javascript. Remove some remaining references in the docs. I also removed some script references.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8279024: Remove javascript references from clhsdb.html

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/6903/head:pull/6903
$ git checkout pull/6903

Update a local copy of the PR:
$ git checkout pull/6903
$ git pull https://git.openjdk.java.net/jdk pull/6903/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 6903

View PR using the GUI difftool:
$ git pr show -t 6903

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/6903.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 21, 2021

👋 Welcome back cjplummer! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 21, 2021
@openjdk
Copy link

openjdk bot commented Dec 21, 2021

@plummercj The following label will be automatically applied to this pull request:

  • serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the serviceability serviceability-dev@openjdk.org label Dec 21, 2021
@mlbridge
Copy link

mlbridge bot commented Dec 21, 2021

Webrevs

@dholmes-ora
Copy link
Member

dholmes-ora commented Dec 21, 2021

This should be fixed in 18.

@plummercj
Copy link
Contributor Author

plummercj commented Dec 21, 2021

This should be fixed in 18.

SA Javascript support broke in JDK 9. It was removed in JDK 15. See JDK-8244668. Yes, this could go into 18, but since I'm not currently setup for 18 I'd rather just push to 19. At this point it doesn't seem important enough for the extra work to get it into 18.

@openjdk
Copy link

openjdk bot commented Dec 21, 2021

@plummercj This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8279024: Remove javascript references from clhsdb.html

Reviewed-by: kevinw, sspitsyn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 11 new commits pushed to the master branch:

  • ff5d417: 8278893: Parallel: Remove GCWorkerDelayMillis
  • 5179672: 8278953: Clarify Class.getDeclaredConstructor specification
  • 8549d8b: 8277100: Dynamic dump can inadvertently overwrite default CDS archive
  • 4c78c9a: 8270929: Obsolete the FilterSpuriousWakeups flag in JDK 19
  • 06206c7: 8278949: Cleanups for 8277850
  • 31fbb87: 6462028: MaskFormatter API documentation refers to getDisplayValue
  • 63e4303: 8278519: serviceability/jvmti/FieldAccessWatch/FieldAccessWatch.java failed "assert(handle != __null) failed: JNI handle should not be null"
  • 6f0e8da: 8278871: [JVMCI] assert((uint)reason < 2* _trap_hist_limit) failed: oob
  • 3c10b5d: 8278104: C1 should support the compiler directive 'BreakAtExecute'
  • cc44e13: 8278623: compiler/vectorapi/reshape/TestVectorCastAVX512.java after JDK-8259610
  • ... and 1 more: https://git.openjdk.java.net/jdk/compare/022e4f0f1c4862315b34595d6df228a49f67cb2e...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Dec 21, 2021
@plummercj
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Dec 22, 2021

Going to push as commit d0ea7c9.
Since your change was applied there have been 42 commits pushed to the master branch:

  • bf28264: Merge
  • 84d3333: 8279081: ProblemList jdk/jfr/event/oldobject/TestLargeRootSet.java on 2 platforms
  • 00c0d10: 8244670: convert clhsdb "whatis" command from javascript to java
  • fb623f1: 8279066: entries.remove(entry) is useless in PKCS12KeyStore
  • 803cb8a: Merge
  • 1128674: 8278627: Shenandoah: TestHeapDump test failed
  • 54517fa: 8279074: ProblemList compiler/codecache/jmx/PoolsIndependenceTest.java on macosx-aarch64
  • ac7430c: 8278044: ObjectInputStream methods invoking the OIF.CFG.getSerialFilterFactory() silent about error cases.
  • db3d6d7: 8278087: Deserialization filter and filter factory property error reporting under specified
  • 467f654: 8279011: JFR: JfrChunkWriter incorrectly handles int64_t chunk size as size_t
  • ... and 32 more: https://git.openjdk.java.net/jdk/compare/022e4f0f1c4862315b34595d6df228a49f67cb2e...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 22, 2021
@openjdk openjdk bot closed this Dec 22, 2021
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 22, 2021
@openjdk
Copy link

openjdk bot commented Dec 22, 2021

@plummercj Pushed as commit d0ea7c9.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@plummercj plummercj deleted the 8279024-clhsdb_doc branch December 22, 2021 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated serviceability serviceability-dev@openjdk.org
4 participants