Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

8279022: JCmdTestFileSafety.java should check file time stamp for test result #6904

Closed
wants to merge 3 commits into from
Closed

8279022: JCmdTestFileSafety.java should check file time stamp for test result #6904

wants to merge 3 commits into from

Conversation

yminqi
Copy link
Contributor

@yminqi yminqi commented Dec 21, 2021 •
edited by openjdk bot

When test finished, the created archive file should be checked after the first run for existence, and checked for time stamp after second run. Since the file name is same, this method is more accurate than the existing checking, only checking the existence of the file. Since jcmd can do repeat dynamic dump to same java process now, removed unnecessary restart process code.

Tests: tier1, jtreg on local linux-x64.

Thanks
Yumin

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8279022: JCmdTestFileSafety.java should check file time stamp for test result

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/6904/head:pull/6904
$ git checkout pull/6904

Update a local copy of the PR:
$ git checkout pull/6904
$ git pull https://git.openjdk.java.net/jdk pull/6904/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 6904

View PR using the GUI difftool:
$ git pr show -t 6904

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/6904.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 21, 2021

👋 Welcome back minqi! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Dec 21, 2021

@yminqi The following label will be automatically applied to this pull request:

  • hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-runtime hotspot-runtime-dev@openjdk.org label Dec 21, 2021
@yminqi yminqi marked this pull request as ready for review December 21, 2021 03:07
@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 21, 2021
@mlbridge
Copy link

mlbridge bot commented Dec 21, 2021 •
edited

Webrevs

calvinccheung
calvinccheung reviewed Dec 21, 2021
View reviewed changes
test/hotspot/jtreg/runtime/cds/appcds/jcmd/JCmdTestFileSafety.java
if (fileLocal.exists()) {
fileLocal.delete();
}
outputDirFile.setWritable(true);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since you've added the setWritable(true) here, do you still need the existing one at line 116?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It can be removed, but better keep it --- the testing result of last step is deleted just in case it could affect next test. I would like remove the result file anyway. Since the file name keep changing, I will update with a function with the file name (String) to delete the file. Thanks.

calvinccheung
calvinccheung reviewed Dec 21, 2021
View reviewed changes
Copy link
Member

@calvinccheung calvinccheung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just one comment.

calvinccheung
calvinccheung approved these changes Dec 21, 2021
View reviewed changes
Copy link
Member

@calvinccheung calvinccheung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update looks good.

@openjdk
Copy link

openjdk bot commented Dec 21, 2021

@yminqi This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8279022: JCmdTestFileSafety.java should check file time stamp for test result

Reviewed-by: ccheung

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 8 new commits pushed to the master branch:

  • f730906: 8278793: Interpreter(x64) intrinsify Thread.currentThread()
  • 8c0bb53: 8278044: ObjectInputStream methods invoking the OIF.CFG.getSerialFilterFactory() silent about error cases.
  • f90425a: 8278087: Deserialization filter and filter factory property error reporting under specified
  • f4f2f32: 8278917: Use Prev Bitmap for recording evac failed objects
  • 29bd736: 8277893: Arraycopy stress tests
  • ff5d417: 8278893: Parallel: Remove GCWorkerDelayMillis
  • 5179672: 8278953: Clarify Class.getDeclaredConstructor specification
  • 8549d8b: 8277100: Dynamic dump can inadvertently overwrite default CDS archive

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Dec 21, 2021
@yminqi
Copy link
Contributor Author

yminqi commented Dec 22, 2021

@calvinccheung thanks for review!

@yminqi
Copy link
Contributor Author

yminqi commented Dec 22, 2021

/integrate

@openjdk
Copy link

openjdk bot commented Dec 22, 2021

Going to push as commit 9a478b3.
Since your change was applied there have been 37 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 22, 2021
@openjdk openjdk bot closed this Dec 22, 2021
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 22, 2021
@openjdk
Copy link

openjdk bot commented Dec 22, 2021

@yminqi Pushed as commit 9a478b3.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@yminqi yminqi deleted the jdk8279022 branch December 22, 2021 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@calvinccheung calvinccheung calvinccheung approved these changes

Assignees
No one assigned
Labels
hotspot-runtime hotspot-runtime-dev@openjdk.org integrated Pull request has been integrated
Milestone
No milestone
2 participants
@yminqi @calvinccheung