New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8279022: JCmdTestFileSafety.java should check file time stamp for test result #6904
Conversation
|
Webrevs
|
if (fileLocal.exists()) { | ||
fileLocal.delete(); | ||
} | ||
outputDirFile.setWritable(true); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since you've added the setWritable(true)
here, do you still need the existing one at line 116?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It can be removed, but better keep it --- the testing result of last step is deleted just in case it could affect next test. I would like remove the result file anyway. Since the file name keep changing, I will update with a function with the file name (String) to delete the file. Thanks.
@yminqi This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 8 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the
|
@calvinccheung thanks for review! |
/integrate |
Going to push as commit 9a478b3.
Your commit was automatically rebased without conflicts. |
When test finished, the created archive file should be checked after the first run for existence, and checked for time stamp after second run. Since the file name is same, this method is more accurate than the existing checking, only checking the existence of the file. Since jcmd can do repeat dynamic dump to same java process now, removed unnecessary restart process code.
Tests: tier1, jtreg on local linux-x64.
Thanks
Yumin
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/6904/head:pull/6904
$ git checkout pull/6904
Update a local copy of the PR:
$ git checkout pull/6904
$ git pull https://git.openjdk.java.net/jdk pull/6904/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 6904
View PR using the GUI difftool:
$ git pr show -t 6904
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/6904.diff