JDK-8272984: javadoc support for SOURCE_DATE_EPOCH

[jonathan-gibbons]

Please review a relatively simple patch to support the standard SOURCE_DATE_EPOCH environment variable, used by those who are interested in reproducible builds. (See https://reproducible-builds.org)

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed
• Change requires a CSR request to be approved

Issues

• JDK-8272984: javadoc support for SOURCE_DATE_EPOCH
• JDK-8279048: javadoc support for SOURCE_DATE_EPOCH (CSR)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/6905/head:pull/6905
$ git checkout pull/6905

Update a local copy of the PR:
$ git checkout pull/6905
$ git pull https://git.openjdk.java.net/jdk pull/6905/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 6905

View PR using the GUI difftool:
$ git pr show -t 6905

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/6905.diff

[jonathan-gibbons]

/csr

[bridgekeeper]

👋 Welcome back jjg! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@jonathan-gibbons this pull request will not be integrated until the CSR request JDK-8279048 for issue JDK-8272984 has been approved.

[openjdk]

@jonathan-gibbons The following label will be automatically applied to this pull request:

• javadoc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (327ee69b)
• 00: Full (385f785f)

[AlanBateman]

I think this issue will require wider discussion because all previous investigation into this topic have concluded with the JDK not reading the env variable directly, instead providing a way to configure the timestamp. For the jar and jmod tools the option --date is used to specify a fixed timestamp for entries when reproducible builds are required. The Properties.store API specifies to read the system property java.properties.date so that date/timestamp in the comment uses a fixed date.

[bridgekeeper]

@jonathan-gibbons This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[jonathan-gibbons]

I think this issue will require wider discussion because all previous investigation into this topic have concluded with the JDK not reading the env variable directly, instead providing a way to configure the timestamp. For the jar and jmod tools the option --date is used to specify a fixed timestamp for entries when reproducible builds are required. The Properties.store API specifies to read the system property java.properties.date so that date/timestamp in the comment uses a fixed date.

Noted. I have a new implementation coming soon, based on using a new --date option, using code from the jar tool.

[hns]

I think this PR should be closed as it has been superseded by #7171.