Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JDK-8272984: javadoc support for SOURCE_DATE_EPOCH #6905

Conversation

jonathan-gibbons
Copy link
Contributor

@jonathan-gibbons jonathan-gibbons commented Dec 21, 2021

Please review a relatively simple patch to support the standard SOURCE_DATE_EPOCH environment variable, used by those who are interested in reproducible builds. (See https://reproducible-builds.org)


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed
  • Change requires a CSR request to be approved

Issues

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/6905/head:pull/6905
$ git checkout pull/6905

Update a local copy of the PR:
$ git checkout pull/6905
$ git pull https://git.openjdk.java.net/jdk pull/6905/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 6905

View PR using the GUI difftool:
$ git pr show -t 6905

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/6905.diff

@jonathan-gibbons
Copy link
Contributor Author

@jonathan-gibbons jonathan-gibbons commented Dec 21, 2021

/csr

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Dec 21, 2021

👋 Welcome back jjg! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added rfr csr labels Dec 21, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Dec 21, 2021

@jonathan-gibbons this pull request will not be integrated until the CSR request JDK-8279048 for issue JDK-8272984 has been approved.

@openjdk
Copy link

@openjdk openjdk bot commented Dec 21, 2021

@jonathan-gibbons The following label will be automatically applied to this pull request:

  • javadoc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the javadoc label Dec 21, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Dec 21, 2021

Webrevs

@AlanBateman
Copy link
Contributor

@AlanBateman AlanBateman commented Dec 21, 2021

I think this issue will require wider discussion because all previous investigation into this topic have concluded with the JDK not reading the env variable directly, instead providing a way to configure the timestamp. For the jar and jmod tools the option --date is used to specify a fixed timestamp for entries when reproducible builds are required. The Properties.store API specifies to read the system property java.properties.date so that date/timestamp in the comment uses a fixed date.

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jan 18, 2022

@jonathan-gibbons This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@jonathan-gibbons
Copy link
Contributor Author

@jonathan-gibbons jonathan-gibbons commented Jan 19, 2022

I think this issue will require wider discussion because all previous investigation into this topic have concluded with the JDK not reading the env variable directly, instead providing a way to configure the timestamp. For the jar and jmod tools the option --date is used to specify a fixed timestamp for entries when reproducible builds are required. The Properties.store API specifies to read the system property java.properties.date so that date/timestamp in the comment uses a fixed date.

Noted. I have a new implementation coming soon, based on using a new --date option, using code from the jar tool.

@hns
Copy link
Member

@hns hns commented Jan 24, 2022

I think this PR should be closed as it has been superseded by #7171.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
csr javadoc rfr
3 participants