Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8254863: Delete code leftover from old fixes #691

Closed
wants to merge 2 commits into from

Conversation

mrserb
Copy link
Member

@mrserb mrserb commented Oct 16, 2020

The fix for JDK-4893408 adds a special code to handle the "PYCC.pf" color profile for the "kernel java":
https://bugs.openjdk.java.net/browse/JDK-4893408?focusedCommentId=12284308&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-12284308
The "kernel java" support was removed in jdk7 in JDK-7016724 but the special code in the ICC_Profile.java still exists.

After the fix for JDK-8175984 a few methods became unused:

  • CMSManager#freeProfile()
  • ProfileDeferralMgr#unregisterDeferral()

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Testing

Linux x64 Windows x64 macOS x64
Build ✔️ (5/5 passed) ✔️ (2/2 passed) ✔️ (2/2 passed)
Test (tier1) ✔️ (9/9 passed) ✔️ (9/9 passed) ✔️ (9/9 passed)

Issue

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/691/head:pull/691
$ git checkout pull/691

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Oct 16, 2020

👋 Welcome back serb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

@openjdk openjdk bot commented Oct 16, 2020

@mrserb The following label will be automatically applied to this pull request:

  • 2d

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the 2d label Oct 16, 2020
@mrserb mrserb marked this pull request as ready for review Oct 16, 2020
@openjdk openjdk bot added the rfr label Oct 16, 2020
@mlbridge
Copy link

@mlbridge mlbridge bot commented Oct 16, 2020

Webrevs

@openjdk
Copy link

@openjdk openjdk bot commented Oct 21, 2020

@mrserb This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8254863: Delete code leftover from old fixes

Reviewed-by: azeemj, kizune, prr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 395 new commits pushed to the master branch:

  • f39a2c8: 8256015: Shenandoah: Add missing Shenandoah implementation in WB_isObjectInOldGen
  • ed7526a: 8247872: Upgrade HarfBuzz to the latest 2.7.2
  • 6a183fb: 8255562: delete UseRDPCForConstantTableBase
  • c5462bb: 8255989: Remove explicitly unascribed authorship from Java source files
  • 358f5d2: 6422025: ThemeReader.cpp can be updated for VC7
  • a9dff94: 8254864: vmTestbase/nsk/jvmti/ResourceExhausted/resexhausted001/TestDescription.java timed out
  • 0b7fba7: 8254270: linux 32 bit build doesn't compile libjdwp/log_messages.c
  • f5d36e6: 8246741: NetworkInterface/UniqueMacAddressesTest: mac address uniqueness test failed
  • 688b10b: 8255561: add tests to check binary compatibility rules for records
  • 727a69f: 8255969: Improve java/io/BufferedInputStream/LargeCopyWithMark.java using jtreg tags
  • ... and 385 more: https://git.openjdk.java.net/jdk/compare/96bb6e76bfcd5796745dd6ddee647ad1e98a2895...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Oct 21, 2020
Copy link
Contributor

@prrace prrace left a comment

I don't think it was really for kernel. The Windows on-line jRE installer made it
an optional component.

prrace
prrace approved these changes Nov 8, 2020
@mrserb
Copy link
Member Author

@mrserb mrserb commented Nov 10, 2020

/integrate

@openjdk openjdk bot closed this Nov 10, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Nov 10, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Nov 10, 2020

@mrserb Since your change was applied there have been 409 commits pushed to the master branch:

  • 8066b33: 8253905: Update sanity test suite to not place windows at (0,0)
  • f71f9dc: 8255949: AArch64: Add support for vectorized shift right and accumulate
  • 1332ba3: 8256039: Shenandoah: runtime/stringtable/StringTableCleaningTest.java fails
  • 11431b1: 4619330: All built-in java.awt.color.ColorSpace fields should be specified as such
  • 17f04fc: 8254078: DataOutputStream is very slow post-disabling of Biased Locking
  • 79b7909: 8255980: G1 Service thread register_task can be used after shutdown
  • dd8e4ff: 8255711: Fix and unify hotspot signal handlers
  • d99e1f6: 8255991: Shenandoah: Apply 'weak' LRB on cmpxchg and xchg
  • c7551c3: 8256014: Eliminate the warning about serialization in non-public API of Swing
  • 2d6c28d: 6847157: java.lang.NullPointerException: HDC for component at sun.java2d.loops.Blit.Blit
  • ... and 399 more: https://git.openjdk.java.net/jdk/compare/96bb6e76bfcd5796745dd6ddee647ad1e98a2895...master

Your commit was automatically rebased without conflicts.

Pushed as commit b5d78af.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@mrserb mrserb deleted the JDK-8254863 branch Nov 10, 2020
openjdk-notifier bot referenced this issue Nov 10, 2020
Reviewed-by: azeemj, kizune, prr
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2d integrated
4 participants