Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8279168: Shenandoah: Remove unused always_true in ShenandoahRootAdjuster::roots_do() #6917

Closed

Conversation

zhengyu123
Copy link
Contributor

@zhengyu123 zhengyu123 commented Dec 22, 2021

A trivial patch to remove unused always_true variable.

Test:

  • Built on Linux x86_64

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8279168: Shenandoah: Remove unused always_true in ShenandoahRootAdjuster::roots_do()

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/6917/head:pull/6917
$ git checkout pull/6917

Update a local copy of the PR:
$ git checkout pull/6917
$ git pull https://git.openjdk.java.net/jdk pull/6917/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 6917

View PR using the GUI difftool:
$ git pr show -t 6917

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/6917.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 22, 2021

👋 Welcome back zgu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Dec 22, 2021

@zhengyu123 The following labels will be automatically applied to this pull request:

  • hotspot-gc
  • shenandoah

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added hotspot-gc hotspot-gc-dev@openjdk.org shenandoah shenandoah-dev@openjdk.org labels Dec 22, 2021
@shipilev
Copy link
Member

shipilev commented Jan 5, 2022

This PR is still "draft", intended?

@zhengyu123 zhengyu123 marked this pull request as ready for review January 5, 2022 18:48
@openjdk openjdk bot added the rfr Pull request is ready for review label Jan 5, 2022
@mlbridge
Copy link

mlbridge bot commented Jan 5, 2022

Webrevs

Copy link
Member

@shipilev shipilev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine.

@openjdk
Copy link

openjdk bot commented Jan 5, 2022

@zhengyu123 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8279168: Shenandoah: Remove unused always_true in ShenandoahRootAdjuster::roots_do()

Reviewed-by: shade

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 12 new commits pushed to the master branch:

  • 9a0e890: 8277515: Update --release 18 symbol information for JDK 18 build 29
  • a741b92: 8279453: Disable tools/jar/ReproducibleJar.java on 32-bit platforms
  • b6ec39c: 8279510: Parallel: Remove unused PSScavenge::_consecutive_skipped_scavenges
  • 0f98efb: 8279445: Update JMH devkit to 1.34
  • 8b5de27: 8279485: Incorrect copyright year in compiler/lib/ir_framework/IRNode.java after JDK-8278114
  • f326305: 8278114: New addnode ideal optimization: converting "x + x" into "x << 1"
  • 191f730: Merge
  • 95a3010: 8275830: C2: Receiver downcast is missing when inlining through method handle linkers
  • 58b5fb3: 8265317: [vector] assert(payload->is_object()) failed: expected 'object' value for scalar-replaced boxed vector but got: NULL
  • 06f3713: 8279379: GHA: Print tests that are in error
  • ... and 2 more: https://git.openjdk.java.net/jdk/compare/99a8351bc913a94f8aebef54fe7b147545edd258...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jan 5, 2022
@zhengyu123
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Jan 5, 2022

Going to push as commit 7b429a6.
Since your change was applied there have been 12 commits pushed to the master branch:

  • 9a0e890: 8277515: Update --release 18 symbol information for JDK 18 build 29
  • a741b92: 8279453: Disable tools/jar/ReproducibleJar.java on 32-bit platforms
  • b6ec39c: 8279510: Parallel: Remove unused PSScavenge::_consecutive_skipped_scavenges
  • 0f98efb: 8279445: Update JMH devkit to 1.34
  • 8b5de27: 8279485: Incorrect copyright year in compiler/lib/ir_framework/IRNode.java after JDK-8278114
  • f326305: 8278114: New addnode ideal optimization: converting "x + x" into "x << 1"
  • 191f730: Merge
  • 95a3010: 8275830: C2: Receiver downcast is missing when inlining through method handle linkers
  • 58b5fb3: 8265317: [vector] assert(payload->is_object()) failed: expected 'object' value for scalar-replaced boxed vector but got: NULL
  • 06f3713: 8279379: GHA: Print tests that are in error
  • ... and 2 more: https://git.openjdk.java.net/jdk/compare/99a8351bc913a94f8aebef54fe7b147545edd258...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 5, 2022
@openjdk openjdk bot closed this Jan 5, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 5, 2022
@openjdk
Copy link

openjdk bot commented Jan 5, 2022

@zhengyu123 Pushed as commit 7b429a6.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-gc hotspot-gc-dev@openjdk.org integrated Pull request has been integrated shenandoah shenandoah-dev@openjdk.org
2 participants