Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8194126: Regression automated Test '/open/test/jdk/javax/swing/JColorChooser/Test7194184.java' fails #692

Closed
wants to merge 1 commit into from

Conversation

@prsadhuk
Copy link
Contributor

@prsadhuk prsadhuk commented Oct 16, 2020

Please review a test fix for an issue where the color is not chosen correctly.
The issue seems to stem from the fact that keys are not processed properly so the proper color is not chosen.
Fixed by adding autoDelay during processing of key events and also made EDT change to invokeAndWait from invokeLater.
Also, move the frame to center of screen and do cleanup at finally block.
Mach5 job was run for several iteration on all 3 platforms. Link in JBS


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Testing

Linux x64 Windows x64 macOS x64
Build ✔️ (5/5 passed) ✔️ (2/2 passed) ✔️ (2/2 passed)
Test (tier1) ✔️ (9/9 passed) ✔️ (9/9 passed) ✔️ (9/9 passed)

Issue

  • JDK-8194126: Regression automated Test '/open/test/jdk/javax/swing/JColorChooser/Test7194184.java' fails

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/692/head:pull/692
$ git checkout pull/692

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Oct 16, 2020

👋 Welcome back psadhukhan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Oct 16, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Oct 16, 2020

@prsadhuk The following label will be automatically applied to this pull request:

  • swing

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the swing label Oct 16, 2020
@mlbridge
Copy link

@mlbridge mlbridge bot commented Oct 16, 2020

Webrevs

mrserb
mrserb approved these changes Oct 16, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Oct 16, 2020

@prsadhuk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8194126: Regression automated Test '/open/test/jdk/javax/swing/JColorChooser/Test7194184.java' fails

Reviewed-by: serb, trebari

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 18 new commits pushed to the master branch:

  • 3d23bd8: 8254814: [Vector API] Fix an AVX512 crash after JDK-8223347
  • 7c0d417: 8251535: Partial peeling at unsigned test adds incorrect loop exit check
  • 5145bed: 8254125: Assertion in cppVtables.cpp during builds on 32bit Windows
  • bdda205: 8254369: Node::disconnect_inputs may skip precedences
  • 96bb6e7: 8251325: Miss 'L' for long value in if statement
  • 546620b: 8254192: ExtraSharedClassListFile contains extra white space at end of line
  • f3ce45f: 8254799: runtime/ErrorHandling/TestHeapDumpOnOutOfMemoryError.java fails with release VMs
  • cda22e3: 8254811: JDK-8254158 broke ppc64, s390 builds
  • 8ef88e5: 8249878: jfr_emergency_dump has secondary crashes
  • 3c2f5e0: 8254674: G1: Improve root location reference to dead obj verification message
  • ... and 8 more: https://git.openjdk.java.net/jdk/compare/038f58d4f0782f885547d2b052a47fdf2229cfe3...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Oct 16, 2020
@prsadhuk
Copy link
Contributor Author

@prsadhuk prsadhuk commented Oct 17, 2020

/integrate

@openjdk openjdk bot closed this Oct 17, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Oct 17, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Oct 17, 2020

@prsadhuk Since your change was applied there have been 26 commits pushed to the master branch:

  • ce1aac1: 8028707: javax/swing/JComboBox/6236162/bug6236162.java fails on azure
  • 83ea863: 8253559: The INDEX page should link to Serialized Form and Constant Values pages
  • e66c6bb: 8254349: The TestNoScreenMenuBar test should be updated
  • 402d01a: 8254795: Remove obsolete template files
  • 07ec35e: 8254623: gc/g1/TestHumongousConcurrentStartUndo.java still fails sometimes
  • 0570cc1: 8254855: Clean up and remove unused code in vmIntrinsics
  • 1742c44: 8254695: G1: Next mark bitmap clear not cancelled after marking abort
  • 34583eb: 8254161: Prevent instantiation of EnumSet subclasses through deserialization
  • 3d23bd8: 8254814: [Vector API] Fix an AVX512 crash after JDK-8223347
  • 7c0d417: 8251535: Partial peeling at unsigned test adds incorrect loop exit check
  • ... and 16 more: https://git.openjdk.java.net/jdk/compare/038f58d4f0782f885547d2b052a47fdf2229cfe3...master

Your commit was automatically rebased without conflicts.

Pushed as commit 0b3e6c5.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@prsadhuk prsadhuk deleted the JDK-8194126 branch Oct 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants