Skip to content

Conversation

@plummercj
Copy link
Contributor

@plummercj plummercj commented Dec 23, 2021

The SA src/jdk.hotspot.agent/doc/index.html file contains a table of SA scripts and their descriptions. All of these scripts are now gone. They were used to make it easier to launch what today we would call SA tools. Now all these tools are launched as sub-commands of the jhsdb command, which has its own man page.

I also did some other minor fixes and cleanups.

The rendered html can be found here:
https://htmlpreview.github.io/?https://raw.githubusercontent.com/openjdk/jdk/dc0311f0a60ae550b01a3885d74fa23288df37d1/src/jdk.hotspot.agent/doc/index.html


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8279119: src/jdk.hotspot.agent/doc/index.html file contains references to scripts that no longer exist

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/6924/head:pull/6924
$ git checkout pull/6924

Update a local copy of the PR:
$ git checkout pull/6924
$ git pull https://git.openjdk.java.net/jdk pull/6924/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 6924

View PR using the GUI difftool:
$ git pr show -t 6924

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/6924.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 23, 2021

👋 Welcome back cjplummer! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 23, 2021
@openjdk
Copy link

openjdk bot commented Dec 23, 2021

@plummercj The following label will be automatically applied to this pull request:

  • serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the serviceability serviceability-dev@openjdk.org label Dec 23, 2021
@mlbridge
Copy link

mlbridge bot commented Dec 23, 2021

Webrevs

Copy link
Contributor

@kevinjwalls kevinjwalls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice refresh/cleanup.

Copy link
Contributor

@sspitsyn sspitsyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.
Thanks,
Serguei

@openjdk
Copy link

openjdk bot commented Dec 24, 2021

@plummercj This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8279119: src/jdk.hotspot.agent/doc/index.html file contains references to scripts that no longer exist

Reviewed-by: kevinw, sspitsyn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 19 new commits pushed to the master branch:

  • 70c6df6: 8274893: Update java.desktop classes to use try-with-resources
  • d52392c: 8276892: Provide a way to emulate exceptional situations in FileManager when using JavadocTester
  • 22c15dd: 8279189: Inaccurate comment about class VMThread
  • 9d99a37: 8277881: Missing SessionID in TLS1.3 resumption in compatibility mode
  • 4669bcd: 8279244: test accompaning fix for JDK-8205187 is failing in Windows
  • a3b1c6b: Merge
  • 04ad668: 8279204: [BACKOUT] JDK-8278413: C2 crash when allocating array of size too large
  • 730f670: 8268297: jdk/jfr/api/consumer/streaming/TestLatestEvent.java times out
  • 9d5ae2e: 8279076: C2: Bad AD file when matching SqrtF with UseSSE=0
  • 04ee921: 8278967: rmiregistry fails to start because SecurityManager is disabled
  • ... and 9 more: https://git.openjdk.java.net/jdk/compare/eaefb1a1ed9edea440628e3a5c5483ebd52bfcb0...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Dec 24, 2021
@plummercj
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Jan 3, 2022

Going to push as commit 2a59ebb.
Since your change was applied there have been 25 commits pushed to the master branch:

  • 299022d: 8279225: [arm32] C1 longs comparison operation destroys argument registers
  • 4f607f2: Merge
  • 54b800d: 8271202: C1: assert(false) failed: live_in set of first block must be empty
  • 2945b78: 8279195: Document the -XX:+NeverActAsServerClassMachine flag
  • 6588bed: 8278889: AArch64: [vectorapi] VectorMaskLoadStoreTest.testMaskCast() test fail
  • 7fea103: 8279134: Fix Amazon copyright in various files
  • 70c6df6: 8274893: Update java.desktop classes to use try-with-resources
  • d52392c: 8276892: Provide a way to emulate exceptional situations in FileManager when using JavadocTester
  • 22c15dd: 8279189: Inaccurate comment about class VMThread
  • 9d99a37: 8277881: Missing SessionID in TLS1.3 resumption in compatibility mode
  • ... and 15 more: https://git.openjdk.java.net/jdk/compare/eaefb1a1ed9edea440628e3a5c5483ebd52bfcb0...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 3, 2022
@openjdk openjdk bot closed this Jan 3, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 3, 2022
@openjdk
Copy link

openjdk bot commented Jan 3, 2022

@plummercj Pushed as commit 2a59ebb.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@plummercj plummercj deleted the 8279119-rm_sa_scripts branch January 26, 2022 05:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integrated Pull request has been integrated serviceability serviceability-dev@openjdk.org

Development

Successfully merging this pull request may close these issues.

3 participants