Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8279223: Define version in .jcheck/conf #6929

Closed
wants to merge 1 commit into from

Conversation

erikj79
Copy link
Member

@erikj79 erikj79 commented Dec 23, 2021

This patch adds the version field to .jcheck/conf. By doing this we can remove the corresponding configuration from the Skara bots, which in turn reduces the need for timing and general complexity of starting a new JDK release.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/6929/head:pull/6929
$ git checkout pull/6929

Update a local copy of the PR:
$ git checkout pull/6929
$ git pull https://git.openjdk.java.net/jdk pull/6929/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 6929

View PR using the GUI difftool:
$ git pr show -t 6929

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/6929.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Dec 23, 2021

👋 Welcome back erikj! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title JDK-8279223 8279223: Define version in .jcheck/conf Dec 23, 2021
@openjdk openjdk bot added the rfr label Dec 23, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Dec 23, 2021

@erikj79 The following label will be automatically applied to this pull request:

  • build

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the build label Dec 23, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Dec 23, 2021

Webrevs

@openjdk
Copy link

@openjdk openjdk bot commented Dec 23, 2021

@erikj79 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8279223: Define version in .jcheck/conf

Reviewed-by: alanb, iris, kcr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 26 new commits pushed to the master branch:

  • c295e71: 8276700: Improve java.lang.ref.Cleaner javadocs
  • 3a1fca3: 8278146: G1: Rework VM_G1Concurrent VMOp to clearly identify it as pause
  • 2a59ebb: 8279119: src/jdk.hotspot.agent/doc/index.html file contains references to scripts that no longer exist
  • 299022d: 8279225: [arm32] C1 longs comparison operation destroys argument registers
  • 4f607f2: Merge
  • 54b800d: 8271202: C1: assert(false) failed: live_in set of first block must be empty
  • 2945b78: 8279195: Document the -XX:+NeverActAsServerClassMachine flag
  • 6588bed: 8278889: AArch64: [vectorapi] VectorMaskLoadStoreTest.testMaskCast() test fail
  • 7fea103: 8279134: Fix Amazon copyright in various files
  • 70c6df6: 8274893: Update java.desktop classes to use try-with-resources
  • ... and 16 more: https://git.openjdk.java.net/jdk/compare/214f98f6b07e312e6f4ded5364a94277114784e7...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Dec 23, 2021
@erikj79
Copy link
Member Author

@erikj79 erikj79 commented Jan 3, 2022

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Jan 3, 2022

Going to push as commit 6b906bb.
Since your change was applied there have been 26 commits pushed to the master branch:

  • c295e71: 8276700: Improve java.lang.ref.Cleaner javadocs
  • 3a1fca3: 8278146: G1: Rework VM_G1Concurrent VMOp to clearly identify it as pause
  • 2a59ebb: 8279119: src/jdk.hotspot.agent/doc/index.html file contains references to scripts that no longer exist
  • 299022d: 8279225: [arm32] C1 longs comparison operation destroys argument registers
  • 4f607f2: Merge
  • 54b800d: 8271202: C1: assert(false) failed: live_in set of first block must be empty
  • 2945b78: 8279195: Document the -XX:+NeverActAsServerClassMachine flag
  • 6588bed: 8278889: AArch64: [vectorapi] VectorMaskLoadStoreTest.testMaskCast() test fail
  • 7fea103: 8279134: Fix Amazon copyright in various files
  • 70c6df6: 8274893: Update java.desktop classes to use try-with-resources
  • ... and 16 more: https://git.openjdk.java.net/jdk/compare/214f98f6b07e312e6f4ded5364a94277114784e7...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated label Jan 3, 2022
@openjdk openjdk bot closed this Jan 3, 2022
@openjdk openjdk bot removed ready rfr labels Jan 3, 2022
@openjdk
Copy link

@openjdk openjdk bot commented Jan 3, 2022

@erikj79 Pushed as commit 6b906bb.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build integrated
4 participants