Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8279351: [TESTBUG] SADebugDTest.java does not handle "Address already in use" error #6941

Closed
wants to merge 2 commits into from

Conversation

YaSuenag
Copy link
Member

@YaSuenag YaSuenag commented Dec 31, 2021

We expect SADebugDTest.java will retly the test when it encounters "Address already in use" error. However RuntimeException is thrown when the error happens.

So I fixed it with some refactoring in this PR. Key change is the condition in L129.

Please see serviceability-dev post for details.
https://mail.openjdk.java.net/pipermail/serviceability-dev/2021-December/040453.html


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8279351: [TESTBUG] SADebugDTest.java does not handle "Address already in use" error

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/6941/head:pull/6941
$ git checkout pull/6941

Update a local copy of the PR:
$ git checkout pull/6941
$ git pull https://git.openjdk.java.net/jdk pull/6941/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 6941

View PR using the GUI difftool:
$ git pr show -t 6941

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/6941.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 31, 2021

👋 Welcome back ysuenaga! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 31, 2021
@openjdk
Copy link

openjdk bot commented Dec 31, 2021

@YaSuenag The following label will be automatically applied to this pull request:

  • serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the serviceability serviceability-dev@openjdk.org label Dec 31, 2021
@mlbridge
Copy link

mlbridge bot commented Dec 31, 2021

Webrevs

Copy link
Contributor

@plummercj plummercj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll need to update the copyright.

@YaSuenag
Copy link
Member Author

YaSuenag commented Jan 3, 2022

Thanks @plummercj ! I fixed them in new commit.

@openjdk
Copy link

openjdk bot commented Jan 3, 2022

@YaSuenag This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8279351: [TESTBUG] SADebugDTest.java does not handle "Address already in use" error

Reviewed-by: cjplummer

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 2a59ebb: 8279119: src/jdk.hotspot.agent/doc/index.html file contains references to scripts that no longer exist

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jan 3, 2022
@YaSuenag
Copy link
Member Author

YaSuenag commented Jan 4, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Jan 4, 2022

Going to push as commit d1e6f26.
Since your change was applied there have been 10 commits pushed to the master branch:

  • 93c7d90: 8278282: G1: Log basic statistics for evacuation failure
  • 1ffdc52: 8279412: [JVMCI] failed speculations list must outlive any nmethod that refers to it
  • 863bffb: 8279374: Remove unused JNIHandles::weak_oops_do
  • 9bdf6eb: 8279385: [test] Adjust sun/security/pkcs12/KeytoolOpensslInteropTest.java after 8278344
  • 09cf5f1: 8278602: CDS dynamic dump may access unloaded classes
  • 8dc4437: 8278434: timeouts in test java/time/test/java/time/format/TestZoneTextPrinterParser.java
  • 6b906bb: 8279223: Define version in .jcheck/conf
  • c295e71: 8276700: Improve java.lang.ref.Cleaner javadocs
  • 3a1fca3: 8278146: G1: Rework VM_G1Concurrent VMOp to clearly identify it as pause
  • 2a59ebb: 8279119: src/jdk.hotspot.agent/doc/index.html file contains references to scripts that no longer exist

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 4, 2022
@openjdk openjdk bot closed this Jan 4, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 4, 2022
@openjdk
Copy link

openjdk bot commented Jan 4, 2022

@YaSuenag Pushed as commit d1e6f26.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@YaSuenag YaSuenag deleted the JDK-8279351 branch January 11, 2022 00:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated serviceability serviceability-dev@openjdk.org
2 participants