Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JDK-8277515: Update --release 18 symbol information for JDK 18 build 29 #6948

Closed
wants to merge 1 commit into from

Conversation

jddarcy
Copy link
Member

@jddarcy jddarcy commented Jan 3, 2022

Usual update to the JDK 19 symbol files for changes in JDK 18; this time JDK-8276660 in JDK 18 build 28.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8277515: Update --release 18 symbol information for JDK 18 build 29

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/6948/head:pull/6948
$ git checkout pull/6948

Update a local copy of the PR:
$ git checkout pull/6948
$ git pull https://git.openjdk.java.net/jdk pull/6948/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 6948

View PR using the GUI difftool:
$ git pr show -t 6948

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/6948.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 3, 2022

👋 Welcome back darcy! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jan 3, 2022
@openjdk
Copy link

openjdk bot commented Jan 3, 2022

@jddarcy The following labels will be automatically applied to this pull request:

  • build
  • compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added build build-dev@openjdk.org compiler compiler-dev@openjdk.org labels Jan 3, 2022
@mlbridge
Copy link

mlbridge bot commented Jan 3, 2022

Webrevs

@openjdk
Copy link

openjdk bot commented Jan 3, 2022

@jddarcy This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8277515: Update --release 18 symbol information for JDK 18 build 29

Reviewed-by: iris

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • c295e71: 8276700: Improve java.lang.ref.Cleaner javadocs
  • 3a1fca3: 8278146: G1: Rework VM_G1Concurrent VMOp to clearly identify it as pause

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jan 3, 2022
@jddarcy
Copy link
Member Author

jddarcy commented Jan 5, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Jan 5, 2022

Going to push as commit 9a0e890.
Since your change was applied there have been 22 commits pushed to the master branch:

  • a741b92: 8279453: Disable tools/jar/ReproducibleJar.java on 32-bit platforms
  • b6ec39c: 8279510: Parallel: Remove unused PSScavenge::_consecutive_skipped_scavenges
  • 0f98efb: 8279445: Update JMH devkit to 1.34
  • 8b5de27: 8279485: Incorrect copyright year in compiler/lib/ir_framework/IRNode.java after JDK-8278114
  • f326305: 8278114: New addnode ideal optimization: converting "x + x" into "x << 1"
  • 191f730: Merge
  • 95a3010: 8275830: C2: Receiver downcast is missing when inlining through method handle linkers
  • 58b5fb3: 8265317: [vector] assert(payload->is_object()) failed: expected 'object' value for scalar-replaced boxed vector but got: NULL
  • 06f3713: 8279379: GHA: Print tests that are in error
  • e7244c1: 8278966: two microbenchmarks tests fail "assert(!jvms->method()->has_exception_handlers()) failed: no exception handler expected" after JDK-8275638
  • ... and 12 more: https://git.openjdk.java.net/jdk/compare/2a59ebbba391ee0d70604027081712f1c2dfd1fe...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 5, 2022
@openjdk openjdk bot closed this Jan 5, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 5, 2022
@openjdk
Copy link

openjdk bot commented Jan 5, 2022

@jddarcy Pushed as commit 9a0e890.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@jddarcy jddarcy deleted the JDK-8277515 branch February 2, 2023 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build build-dev@openjdk.org compiler compiler-dev@openjdk.org integrated Pull request has been integrated
2 participants