-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8279437: [JVMCI] exception in HotSpotJVMCIRuntime.translate can exit the VM #6951
Conversation
👋 Welcome back dnsimon! A progress list of the required criteria for merging this PR into |
Webrevs
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good. Thank you for testing it.
@dougxc This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 15 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
Please, update copyright year to 2022 in changed files. |
I've done it but this should really be automated some how. I thought there is (was?) a script that runs over all JDK sources once a year to fix copyright dates? |
/integrate |
Going to push as commit e14fb4f.
Your commit was automatically rebased without conflicts. |
This PR addresses the problem reported in JDK-8279437 by adding support for transferring exceptions from HotSpot into libgraal (the other way around was already supported).
It also improves the translation of exceptions by:
|
in an exception's message string).It also adds the
jvmci.ForceTranslateFailure
option to allow testing handling of failures inHotSpotJVMCIRuntime.translate
. See oracle/graal@b3a6ce4 for such a test.Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/6951/head:pull/6951
$ git checkout pull/6951
Update a local copy of the PR:
$ git checkout pull/6951
$ git pull https://git.openjdk.java.net/jdk pull/6951/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 6951
View PR using the GUI difftool:
$ git pr show -t 6951
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/6951.diff