4884570: StreamPrintService.isAttributeValueSupported does not work properly for SheetCollate

[prrace]

This fixes a longstanding consistency issue where the Postscript StreamPrintService would report SheetCollate.UNCOLLATED in a list of supported values then report it was not supported under the same conditions.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-4884570: StreamPrintService.isAttributeValueSupported does not work properly for SheetCollate

Reviewers

• Sergey Bylokhov (@mrserb - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/6963/head:pull/6963
$ git checkout pull/6963

Update a local copy of the PR:
$ git checkout pull/6963
$ git pull https://git.openjdk.java.net/jdk pull/6963/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 6963

View PR using the GUI difftool:
$ git pr show -t 6963

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/6963.diff

[bridgekeeper]

👋 Welcome back prr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@prrace The following label will be automatically applied to this pull request:

• client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 02: Full - Incremental (7722c2c3)
• 01: Full - Incremental (69f49feb)
• 00: Full (a360aee6)

[mrserb]

Can we add other attributes to the tests? I made a quick check for some attributes and it looks like the code is quite confused, on my windows, the same issue exists for the "OrientationRequested.class".

[prrace]

I've also fixed OrientationRequested and added other Enum attributes to the test.

[openjdk]

@prrace This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

4884570: StreamPrintService.isAttributeValueSupported does not work properly for SheetCollate

Reviewed-by: serb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 23 new commits pushed to the master branch:

• 456bd1e: 8211004: javac is complaining about non-denotable types and refusing to generate the class file
• 844dfb3: Merge
• 564c8c6: 8279529: ProblemList java/nio/channels/DatagramChannel/ManySourcesAndTargets.java on macosx-aarch64
• 590fa9d: 8278612: [macos] test/jdk/java/awt/dnd/RemoveDropTargetCrashTest crashes with VoiceOver on macOS
• 5cd9515: 8279525: ProblemList java/awt/GraphicsDevice/CheckDisplayModes.java on macosx-aarch64
• 9d43d25: 8278897: Alignment of heap segments is not enforced correctly
• 0f4807e: 8279222: Incorrect legacyMap.get in java.security.Provider after JDK-8276660
• f8f9148: 8278948: compiler/vectorapi/reshape/TestVectorCastAVX1.java crashes in assembler
• ab49053: 8279533: Bad indentation and missing curly braces in BlockBegin::set_end
• 523300e: 8279526: Exceptions::count_out_of_memory_exceptions miscounts class metaspace OOMEs
• ... and 13 more: https://git.openjdk.java.net/jdk/compare/99a8351bc913a94f8aebef54fe7b147545edd258...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[prrace]

/integrate

[openjdk]

Going to push as commit b3dbfc6.
Since your change was applied there have been 26 commits pushed to the master branch:

• 8703f14: 8273322: Enhance macro logic optimization for masked logic operations.
• bc12381: 8279505: Update documentation for RETRY_COUNT and REPEAT_COUNT
• 2dbb936: 8279339: (ch) Input/Output streams returned by Channels factory methods don't support concurrent read/write ops
• 456bd1e: 8211004: javac is complaining about non-denotable types and refusing to generate the class file
• 844dfb3: Merge
• 564c8c6: 8279529: ProblemList java/nio/channels/DatagramChannel/ManySourcesAndTargets.java on macosx-aarch64
• 590fa9d: 8278612: [macos] test/jdk/java/awt/dnd/RemoveDropTargetCrashTest crashes with VoiceOver on macOS
• 5cd9515: 8279525: ProblemList java/awt/GraphicsDevice/CheckDisplayModes.java on macosx-aarch64
• 9d43d25: 8278897: Alignment of heap segments is not enforced correctly
• 0f4807e: 8279222: Incorrect legacyMap.get in java.security.Provider after JDK-8276660
• ... and 16 more: https://git.openjdk.java.net/jdk/compare/99a8351bc913a94f8aebef54fe7b147545edd258...master

Your commit was automatically rebased without conflicts.

[openjdk]

@prrace Pushed as commit b3dbfc6.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.