8254883: ZGC: Make the ZArrayIterator reusable for ZRelocationSetIterators

[pliden]

The ZRelocationSetIterators are mostly just duplicate implementations of the ZArrayIterators. With some slight adjustments to ZArrayIteratorImpl we can make that code reusable for ZRelocationSetIteratorImpl.

Note that this PR builds/depends on "8254878: Move last piece of ZArray to GrowableArray", which is out for review as a separate PR (#694).

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8254883: ZGC: Make the ZArrayIterator reusable for ZRelocationSetIterators

Reviewers

• Erik Österlund (@fisk - Reviewer)

Download

$ git fetch https://git.openjdk.java.net/jdk pull/697/head:pull/697
$ git checkout pull/697

[bridgekeeper]

👋 Welcome back pliden! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@pliden The following label will be automatically applied to this pull request:

• hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[pliden]

/label add hotspot-gc
/label remove hotspot

[openjdk]

@pliden
The hotspot-gc label was successfully added.

[openjdk]

@pliden
The hotspot label was successfully removed.

[mlbridge]

Webrevs

• 03: Full - Incremental (9e7a396)
• 02: Full - Incremental (19041ec)
• 01: Full - Incremental (dd59735a6afdbed3026380db881e142f8922e37b)
• 00: Full (7c09a198407f9b937d1e14f087bd060f84911d21)

[pliden]

Updated to make the iterator take const arrays.

[pliden]

Rebased, folded, and updated ZGranuleMapIterator to also use ZArrayIterator.

[fisk]

Looks good.

[openjdk]

@pliden This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8254883: ZGC: Make the ZArrayIterator reusable for ZRelocationSetIterators

Reviewed-by: eosterlund

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 5 new commits pushed to the master branch:

• cb6167b: 8254557: Compiler crashes with java.lang.AssertionError: isSubtype UNKNOWN
• 40f847e: 8227745: Enable Escape Analysis for Better Performance in the Presence of JVMTI Agents
• f167a71: 8254264: Remove redundant cross_modify_fence()
• 44f9271: 8254974: Fix stutter typo in TypeElement
• 76fdd7f: 8255038: Adjust adapter_code_size to account for -Xlog:methodhandles in debug builds

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[pliden]

/integrate

[openjdk]

@pliden Since your change was applied there have been 5 commits pushed to the master branch:

• cb6167b: 8254557: Compiler crashes with java.lang.AssertionError: isSubtype UNKNOWN
• 40f847e: 8227745: Enable Escape Analysis for Better Performance in the Presence of JVMTI Agents
• f167a71: 8254264: Remove redundant cross_modify_fence()
• 44f9271: 8254974: Fix stutter typo in TypeElement
• 76fdd7f: 8255038: Adjust adapter_code_size to account for -Xlog:methodhandles in debug builds

Your commit was automatically rebased without conflicts.

Pushed as commit 3267b09.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.