Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JDK-8279533 Bad indentation and missing curly braces in BlockBegin::set_end #6972

Closed
wants to merge 1 commit into from

Conversation

LudwikJaniuk
Copy link
Contributor

@LudwikJaniuk LudwikJaniuk commented Jan 5, 2022

Fixed this to please SonarCloud, but it was already working as intended. This change is equivalent with the original code.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8279533: Bad indentation and missing curly braces in BlockBegin::set_end

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/6972/head:pull/6972
$ git checkout pull/6972

Update a local copy of the PR:
$ git checkout pull/6972
$ git pull https://git.openjdk.java.net/jdk pull/6972/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 6972

View PR using the GUI difftool:
$ git pr show -t 6972

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/6972.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 5, 2022

👋 Welcome back LudwikJaniuk! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Jan 5, 2022
@openjdk
Copy link

openjdk bot commented Jan 5, 2022

@LudwikJaniuk The following label will be automatically applied to this pull request:

  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-compiler label Jan 5, 2022
Copy link
Contributor

@shipilev shipilev left a comment

Looks fine and trivial, thanks!

@LudwikJaniuk
Copy link
Contributor Author

LudwikJaniuk commented Jan 5, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Jan 5, 2022

@LudwikJaniuk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8279533: Bad indentation and missing curly braces in BlockBegin::set_end

Reviewed-by: shade

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 24 new commits pushed to the master branch:

  • 7b429a6: 8279168: Shenandoah: Remove unused always_true in ShenandoahRootAdjuster::roots_do()
  • 9a0e890: 8277515: Update --release 18 symbol information for JDK 18 build 29
  • a741b92: 8279453: Disable tools/jar/ReproducibleJar.java on 32-bit platforms
  • b6ec39c: 8279510: Parallel: Remove unused PSScavenge::_consecutive_skipped_scavenges
  • 0f98efb: 8279445: Update JMH devkit to 1.34
  • 8b5de27: 8279485: Incorrect copyright year in compiler/lib/ir_framework/IRNode.java after JDK-8278114
  • f326305: 8278114: New addnode ideal optimization: converting "x + x" into "x << 1"
  • 191f730: Merge
  • 95a3010: 8275830: C2: Receiver downcast is missing when inlining through method handle linkers
  • 58b5fb3: 8265317: [vector] assert(payload->is_object()) failed: expected 'object' value for scalar-replaced boxed vector but got: NULL
  • ... and 14 more: https://git.openjdk.java.net/jdk/compare/2a59ebbba391ee0d70604027081712f1c2dfd1fe...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@shipilev) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready label Jan 5, 2022
@LudwikJaniuk
Copy link
Contributor Author

LudwikJaniuk commented Jan 5, 2022

@shipilev Please sponsor

@openjdk openjdk bot added the sponsor label Jan 5, 2022
@openjdk
Copy link

openjdk bot commented Jan 5, 2022

@LudwikJaniuk
Your change (at version cde059d) is now ready to be sponsored by a Committer.

@mlbridge
Copy link

mlbridge bot commented Jan 5, 2022

Webrevs

@shipilev
Copy link
Contributor

shipilev commented Jan 5, 2022

/sponsor

@openjdk
Copy link

openjdk bot commented Jan 5, 2022

Going to push as commit ab49053.
Since your change was applied there have been 25 commits pushed to the master branch:

  • 523300e: 8279526: Exceptions::count_out_of_memory_exceptions miscounts class metaspace OOMEs
  • 7b429a6: 8279168: Shenandoah: Remove unused always_true in ShenandoahRootAdjuster::roots_do()
  • 9a0e890: 8277515: Update --release 18 symbol information for JDK 18 build 29
  • a741b92: 8279453: Disable tools/jar/ReproducibleJar.java on 32-bit platforms
  • b6ec39c: 8279510: Parallel: Remove unused PSScavenge::_consecutive_skipped_scavenges
  • 0f98efb: 8279445: Update JMH devkit to 1.34
  • 8b5de27: 8279485: Incorrect copyright year in compiler/lib/ir_framework/IRNode.java after JDK-8278114
  • f326305: 8278114: New addnode ideal optimization: converting "x + x" into "x << 1"
  • 191f730: Merge
  • 95a3010: 8275830: C2: Receiver downcast is missing when inlining through method handle linkers
  • ... and 15 more: https://git.openjdk.java.net/jdk/compare/2a59ebbba391ee0d70604027081712f1c2dfd1fe...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated label Jan 5, 2022
@openjdk openjdk bot closed this Jan 5, 2022
@openjdk openjdk bot removed ready rfr sponsor labels Jan 5, 2022
@openjdk
Copy link

openjdk bot commented Jan 5, 2022

@shipilev @LudwikJaniuk Pushed as commit ab49053.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-compiler integrated
2 participants