Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8268081: Upgrade Unicode Data Files to 14.0.0 #6974

Closed
wants to merge 10 commits into from

Conversation

naotoj
Copy link
Member

@naotoj naotoj commented Jan 5, 2022

Please review the changes for upgrading the Unicode support in the JDK, from version 13 to version 14. Corresponding CSR has also been drafted.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed
  • Change requires a CSR request to be approved

Issues

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/6974/head:pull/6974
$ git checkout pull/6974

Update a local copy of the PR:
$ git checkout pull/6974
$ git pull https://git.openjdk.java.net/jdk pull/6974/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 6974

View PR using the GUI difftool:
$ git pr show -t 6974

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/6974.diff

@openjdk openjdk bot added the csr Pull request needs approved CSR before integration label Jan 5, 2022
@bridgekeeper
Copy link

bridgekeeper bot commented Jan 5, 2022

👋 Welcome back naoto! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jan 5, 2022
@openjdk
Copy link

openjdk bot commented Jan 5, 2022

@naotoj The following labels will be automatically applied to this pull request:

  • build
  • core-libs
  • i18n

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added build build-dev@openjdk.org core-libs core-libs-dev@openjdk.org i18n i18n-dev@openjdk.org labels Jan 5, 2022
@mlbridge
Copy link

mlbridge bot commented Jan 5, 2022

Webrevs

@naotoj naotoj changed the title 8268081: Support for Unicode 14 8268081: Upgrade Unicode Data Files to 14.0.0 Jan 5, 2022
@JoeWang-Java
Copy link
Member

I like how they changed dizzy face to face with crossed-out eyes. Pistol to water pistol, that's even better, just to avoid any confusion ;-)

@kevinrushforth
Copy link
Member

The CSR is now approved. This comment should be sufficient to wake up the bot.

@openjdk openjdk bot removed the csr Pull request needs approved CSR before integration label Jan 12, 2022
@openjdk
Copy link

openjdk bot commented Jan 12, 2022

@naotoj This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8268081: Upgrade Unicode Data Files to 14.0.0

Reviewed-by: joehw, iris, lancea

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 101 new commits pushed to the master branch:

  • ddddec7: 8274243: Implement fast-path for ASCII-compatible CharsetEncoders on aarch64
  • 8fed8ab: 8278065: Refactor subclassAudits to use ClassValue
  • f54ce84: 8238161: use os::fopen in HS code where possible
  • ff0cb98: 8279536: jdk/nio/zipfs/ZipFSOutputStreamTest.java timed out
  • ece98d8: 8278461: Use Executable.getSharedParameterTypes() instead of Executable.getParameterTypes() in trusted code
  • 525b20f: 8279676: Dubious YMM register clearing in x86_64 arraycopy stubs
  • 4f0b650: 8278581: Improve reference processing statistics log output
  • bd339aa: 8277627: Fix copyright years in some jvmci files
  • 319d230: 8277463: JFileChooser with Metal L&F doesn't show non-canonical UNC path in - Look in
  • 13bfb49: 6496103: isFileHidingEnabled return false by default
  • ... and 91 more: https://git.openjdk.java.net/jdk/compare/c295e71b49db20ab398ae1e8ba504d8ebff5fb77...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jan 12, 2022
@naotoj
Copy link
Member Author

naotoj commented Jan 12, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Jan 12, 2022

Going to push as commit 0a094d7.
Since your change was applied there have been 101 commits pushed to the master branch:

  • ddddec7: 8274243: Implement fast-path for ASCII-compatible CharsetEncoders on aarch64
  • 8fed8ab: 8278065: Refactor subclassAudits to use ClassValue
  • f54ce84: 8238161: use os::fopen in HS code where possible
  • ff0cb98: 8279536: jdk/nio/zipfs/ZipFSOutputStreamTest.java timed out
  • ece98d8: 8278461: Use Executable.getSharedParameterTypes() instead of Executable.getParameterTypes() in trusted code
  • 525b20f: 8279676: Dubious YMM register clearing in x86_64 arraycopy stubs
  • 4f0b650: 8278581: Improve reference processing statistics log output
  • bd339aa: 8277627: Fix copyright years in some jvmci files
  • 319d230: 8277463: JFileChooser with Metal L&F doesn't show non-canonical UNC path in - Look in
  • 13bfb49: 6496103: isFileHidingEnabled return false by default
  • ... and 91 more: https://git.openjdk.java.net/jdk/compare/c295e71b49db20ab398ae1e8ba504d8ebff5fb77...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 12, 2022
@openjdk openjdk bot closed this Jan 12, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 12, 2022
@openjdk
Copy link

openjdk bot commented Jan 12, 2022

@naotoj Pushed as commit 0a094d7.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build build-dev@openjdk.org core-libs core-libs-dev@openjdk.org i18n i18n-dev@openjdk.org integrated Pull request has been integrated
5 participants