8183227: read/write APIs in class os shall return ssize_t

[hseigel]

Please review this small fix that changes the return type of os::write() to ssize_t. No changes were needed for os::read() because its return type is ssize_t. This fix was tested by running Mach5 tiers 1-2 on Linux, Mac OS, and Windows and Mach5 tiers 3-5 on Linux x64.
Thanks, Harold

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8183227: read/write APIs in class os shall return ssize_t

Reviewers

• Frederic Parain (@fparain - Committer)
• Robbin Ehn (@robehn - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/6992/head:pull/6992
$ git checkout pull/6992

Update a local copy of the PR:
$ git checkout pull/6992
$ git pull https://git.openjdk.java.net/jdk pull/6992/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 6992

View PR using the GUI difftool:
$ git pr show -t 6992

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/6992.diff

[bridgekeeper]

👋 Welcome back hseigel! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@hseigel The following label will be automatically applied to this pull request:

• hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (529fb984)

[fparain]

Looks good to me.

Fred

[robehn]

Thanks

[openjdk]

@hseigel This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8183227: read/write APIs in class os shall return ssize_t

Reviewed-by: fparain, rehn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 8 new commits pushed to the master branch:

• 4aefd8b: 8279528: Unused TypeEnter.diag after JDK-8205187
• 2f8a2fd: 8279568: IGV: Add bci and line number property for OSR compilations
• 8d1a1e8: 8278228: C2: Improve identical back-to-back if elimination
• e14fb4f: 8279437: [JVMCI] exception in HotSpotJVMCIRuntime.translate can exit the VM
• 77757ba: 8225122: Test AncestorResized.java fails when Windows desktop is scaled.
• f203723: 8279337: The MToolkit is still referenced in a few places
• d47af74: 8279500: Remove FileMapHeader::_heap_obj_roots
• 4243f4c: 8279540: Shenandoah: Should only clear CLD::_claim_strong mark for strong CLD iterations

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[hseigel]

Thanks Fred and Robbin for the reviews!

/integrate

[openjdk]

Going to push as commit 4ff6720.
Since your change was applied there have been 12 commits pushed to the master branch:

• 6613ce6: 8279300: [arm32] SIGILL when running GetObjectSizeIntrinsicsTest
• 1f101b0: 8278329: some TraceDeoptimization code not included in PRODUCT build
• 79b614c: 8279523: Parallel: Remove unnecessary PSScavenge::_to_space_top_before_gc
• 5fa13bb: 8279522: Serial: Remove unused Generation::clear_remembered_set
• 4aefd8b: 8279528: Unused TypeEnter.diag after JDK-8205187
• 2f8a2fd: 8279568: IGV: Add bci and line number property for OSR compilations
• 8d1a1e8: 8278228: C2: Improve identical back-to-back if elimination
• e14fb4f: 8279437: [JVMCI] exception in HotSpotJVMCIRuntime.translate can exit the VM
• 77757ba: 8225122: Test AncestorResized.java fails when Windows desktop is scaled.
• f203723: 8279337: The MToolkit is still referenced in a few places
• ... and 2 more: https://git.openjdk.java.net/jdk/compare/62d03c283667c4122130ec9bbeec623e6a2840e5...master

Your commit was automatically rebased without conflicts.

[openjdk]

@hseigel Pushed as commit 4ff6720.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.