8279560: AArch64: generate_compare_long_string_same_encoding and LARGE_LOOP_PREFETCH alignment #7007

Wanghuang-Huawei · 2022-01-10T13:04:06Z

Fix on code shape :

      __ bind(LARGE_LOOP_PREFETCH);
        __ prfm(Address(str1, SoftwarePrefetchHintDistance));
        __ prfm(Address(str2, SoftwarePrefetchHintDistance));

        __ align(OptoLoopAlignment);

->

      __ align(OptoLoopAlignment);
      __ bind(LARGE_LOOP_PREFETCH);
        __ prfm(Address(str1, SoftwarePrefetchHintDistance));
        __ prfm(Address(str2, SoftwarePrefetchHintDistance));

Thanks to @shipilev for your great advice. Any comments and suggestions will be appreciated.

Progress

Change must not contain extraneous whitespace
Commit message must refer to an issue
Change must be properly reviewed

Issue

JDK-8279560: AArch64: generate_compare_long_string_same_encoding and LARGE_LOOP_PREFETCH alignment

Reviewers

Aleksey Shipilev (@shipilev - Reviewer) ⚠️ Review applies to 8525d14
Andrew Haley (@theRealAph - Reviewer) ⚠️ Review applies to 8525d14

Contributors

Wang Huang <whuang@openjdk.org>

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/7007/head:pull/7007
$ git checkout pull/7007

Update a local copy of the PR:
$ git checkout pull/7007
$ git pull https://git.openjdk.java.net/jdk pull/7007/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 7007

View PR using the GUI difftool:
$ git pr show -t 7007

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/7007.diff

…E_LOOP_PREFETCH alignment

bridgekeeper · 2022-01-10T13:05:33Z

👋 Welcome back whuang! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

shipilev

This looks fine to me, but someone else should take a look too.

Are there any benchmark affected by this change? A targeted String microbenchmark run would be enough.

Wanghuang-Huawei · 2022-01-10T13:07:04Z

/contributor add Wang Huang whuang@openjdk.org

openjdk · 2022-01-10T13:07:25Z

@Wanghuang-Huawei This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8279560: AArch64: generate_compare_long_string_same_encoding and LARGE_LOOP_PREFETCH alignment

Co-authored-by: Wang Huang <whuang@openjdk.org>
Reviewed-by: shade, aph

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 23 new commits pushed to the master branch:

ec5a455: 8279682: JFR: Remove dead code
6504458: 8279647: JFR: Unclosed directory stream
2f13872: 8279646: JFR: Remove recursive call in jdk.jfr.internal.Control
2f7665b: 8279644: hsdis may not work when it was built with --with-binutils=system
4471e95: 8279645: JFR: The cacheEventType in Dispatcher is never assigned
d7e6e9b: 8279643: JFR: Explain why path is sometimes missing from FileRead and FileWrite events
0d19096: 8279642: JFR: Remove unnecessary creation of Duration and Instant objects
d9b1bb5: Merge
40df5df: 8279398: jdk/jfr/api/recording/time/TestTimeMultiple.java failed with "RuntimeException: getStopTime() > afterStop"
ad34f03: 8279515: C1: No inlining through invokedynamic and invokestatic call sites when resolved class is not linked
... and 13 more: https://git.openjdk.java.net/jdk/compare/6613ce64d76a6cc40fd933b022834098721b8d23...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@shipilev, @theRealAph) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

openjdk · 2022-01-10T13:07:46Z

@Wanghuang-Huawei
Contributor Wang Huang <whuang@openjdk.org> successfully added.

openjdk · 2022-01-10T13:10:44Z

@Wanghuang-Huawei The following label will be automatically applied to this pull request:

hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

mlbridge · 2022-01-10T13:14:42Z

Webrevs

01: Full - Incremental (e2873525)
00: Full (8525d14f)

Wanghuang-Huawei · 2022-01-10T13:21:20Z

This looks fine to me, but someone else should take a look too.

Are there any benchmark affected by this change? A targeted String microbenchmark run would be enough.

Thank you for your comment. The fixed version has been tested on Apple M1 (using #5129 's benchmark) without performance degradation.

theRealAph · 2022-01-10T16:34:00Z

This looks fine to me, but someone else should take a look too.
Are there any benchmark affected by this change? A targeted String microbenchmark run would be enough.

Thank you for your comment. The fixed version has been tested on Apple M1 (using #5129 's benchmark) without performance degradation.

It'd be nice to see an improvement. I suspect (but don't know) that this doesn't affect AArch64.

theRealAph · 2022-01-10T16:42:25Z

This looks fine to me, but someone else should take a look too.
Are there any benchmark affected by this change? A targeted String microbenchmark run would be enough.

Thank you for your comment. The fixed version has been tested on Apple M1 (using #5129 's benchmark) without performance degradation.

It'd be nice to see an improvement. I suspect (but don't know) that this doesn't affect AArch64.

Actually, it's probably worth doing anyway, even if no AArch64 port has the weird Intel code alignment stall, just because it makes the loop sit nicely on cache lines.

Wanghuang-Huawei · 2022-01-11T06:09:35Z

/integrate

openjdk · 2022-01-11T06:10:28Z

@Wanghuang-Huawei
Your change (at version 8525d14) is now ready to be sponsored by a Committer.

Wanghuang-Huawei · 2022-01-11T06:32:26Z

/integrate

openjdk · 2022-01-11T06:33:03Z

@Wanghuang-Huawei
Your change (at version e287352) is now ready to be sponsored by a Committer.

shipilev · 2022-01-11T06:38:53Z

/sponsor

openjdk · 2022-01-11T06:40:56Z

Going to push as commit 126328c.
Since your change was applied there have been 23 commits pushed to the master branch:

ec5a455: 8279682: JFR: Remove dead code
6504458: 8279647: JFR: Unclosed directory stream
2f13872: 8279646: JFR: Remove recursive call in jdk.jfr.internal.Control
2f7665b: 8279644: hsdis may not work when it was built with --with-binutils=system
4471e95: 8279645: JFR: The cacheEventType in Dispatcher is never assigned
d7e6e9b: 8279643: JFR: Explain why path is sometimes missing from FileRead and FileWrite events
0d19096: 8279642: JFR: Remove unnecessary creation of Duration and Instant objects
d9b1bb5: Merge
40df5df: 8279398: jdk/jfr/api/recording/time/TestTimeMultiple.java failed with "RuntimeException: getStopTime() > afterStop"
ad34f03: 8279515: C1: No inlining through invokedynamic and invokestatic call sites when resolved class is not linked
... and 13 more: https://git.openjdk.java.net/jdk/compare/6613ce64d76a6cc40fd933b022834098721b8d23...master

Your commit was automatically rebased without conflicts.

openjdk · 2022-01-11T06:41:18Z

@shipilev @Wanghuang-Huawei Pushed as commit 126328c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

8279560: AArch64: generate_compare_long_string_same_encoding and LARG…

8525d14

…E_LOOP_PREFETCH alignment

shipilev approved these changes Jan 10, 2022

View reviewed changes

openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 10, 2022

openjdk bot added the hotspot-compiler hotspot-compiler-dev@openjdk.org label Jan 10, 2022

theRealAph approved these changes Jan 10, 2022

View reviewed changes

openjdk bot added the sponsor Pull request is ready to be sponsored label Jan 11, 2022

fix copyright years

e287352

openjdk bot removed the sponsor Pull request is ready to be sponsored label Jan 11, 2022

openjdk bot added the sponsor Pull request is ready to be sponsored label Jan 11, 2022

openjdk bot added the integrated Pull request has been integrated label Jan 11, 2022

openjdk bot closed this Jan 11, 2022

openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Jan 11, 2022

8279560: AArch64: generate_compare_long_string_same_encoding and LARGE_LOOP_PREFETCH alignment #7007

8279560: AArch64: generate_compare_long_string_same_encoding and LARGE_LOOP_PREFETCH alignment #7007

Wanghuang-Huawei commented Jan 10, 2022 •

edited by openjdk bot

bridgekeeper bot commented Jan 10, 2022

shipilev left a comment

Wanghuang-Huawei commented Jan 10, 2022

openjdk bot commented Jan 10, 2022 •

edited

openjdk bot commented Jan 10, 2022

openjdk bot commented Jan 10, 2022

mlbridge bot commented Jan 10, 2022 •

edited

Wanghuang-Huawei commented Jan 10, 2022

theRealAph commented Jan 10, 2022

theRealAph commented Jan 10, 2022

Wanghuang-Huawei commented Jan 11, 2022

openjdk bot commented Jan 11, 2022

Wanghuang-Huawei commented Jan 11, 2022

openjdk bot commented Jan 11, 2022

shipilev commented Jan 11, 2022

openjdk bot commented Jan 11, 2022

openjdk bot commented Jan 11, 2022

8279560: AArch64: generate_compare_long_string_same_encoding and LARGE_LOOP_PREFETCH alignment #7007

8279560: AArch64: generate_compare_long_string_same_encoding and LARGE_LOOP_PREFETCH alignment #7007

Conversation

Wanghuang-Huawei commented Jan 10, 2022 • edited by openjdk bot

Progress

Issue

Reviewers

Contributors

Reviewing

bridgekeeper bot commented Jan 10, 2022

shipilev left a comment

Choose a reason for hiding this comment

Wanghuang-Huawei commented Jan 10, 2022

openjdk bot commented Jan 10, 2022 • edited

openjdk bot commented Jan 10, 2022

openjdk bot commented Jan 10, 2022

mlbridge bot commented Jan 10, 2022 • edited

Webrevs

Wanghuang-Huawei commented Jan 10, 2022

theRealAph commented Jan 10, 2022

theRealAph commented Jan 10, 2022

Wanghuang-Huawei commented Jan 11, 2022

openjdk bot commented Jan 11, 2022

Wanghuang-Huawei commented Jan 11, 2022

openjdk bot commented Jan 11, 2022

shipilev commented Jan 11, 2022

openjdk bot commented Jan 11, 2022

openjdk bot commented Jan 11, 2022

Wanghuang-Huawei commented Jan 10, 2022 •

edited by openjdk bot

openjdk bot commented Jan 10, 2022 •

edited

mlbridge bot commented Jan 10, 2022 •

edited