Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8278398: jwebserver: Add test to confirm maximum request time #7052

Closed
wants to merge 3 commits into from

Conversation

FrauBoes
Copy link
Member

@FrauBoes FrauBoes commented Jan 12, 2022

This new test confirms that the jwebserver does not wait indefinitely for a request to arrive, but instead closes the connection when the maximum request time is reached. To facilitate this, Exchange::run is amended to process cancelled keys in the case where the current thread is the dispatcher thread (which is the case for the jwebserver).

Testing: tier 1-3 all clear.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8278398: jwebserver: Add test to confirm maximum request time

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/7052/head:pull/7052
$ git checkout pull/7052

Update a local copy of the PR:
$ git checkout pull/7052
$ git pull https://git.openjdk.java.net/jdk pull/7052/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 7052

View PR using the GUI difftool:
$ git pr show -t 7052

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/7052.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 12, 2022

👋 Welcome back jboes! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Jan 12, 2022
@openjdk
Copy link

openjdk bot commented Jan 12, 2022

@FrauBoes The following label will be automatically applied to this pull request:

  • net

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the net label Jan 12, 2022
@mlbridge
Copy link

mlbridge bot commented Jan 12, 2022

Webrevs

* remove redundant null check
* use try-finally to stop process in test
@mlbridge
Copy link

mlbridge bot commented Jan 14, 2022

Mailing list message from Jaikiran Pai on net-dev:

Thank you Julia, these new changes look fine to me.

-Jaikiran

On 13/01/22 9:09 pm, Julia Boes wrote:

dfuch
dfuch approved these changes Jan 14, 2022
Copy link
Member

@dfuch dfuch left a comment

LGTM. @Michael-Mc-Mahon is that the fix you had in mind?

@openjdk
Copy link

openjdk bot commented Jan 14, 2022

@FrauBoes This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8278398: jwebserver: Add test to confirm maximum request time

Reviewed-by: dfuchs, michaelm

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 22 new commits pushed to the master branch:

  • dd76a28: 8280000: Remove unused CardTable::find_covering_region_containing
  • 84976b4: 8278549: UNIX sun/font coding misses SUSE distro detection on recent distro SUSE 15
  • 965c64b: 8279699: Parallel: More precise boundary in ObjectStartArray::object_starts_in_range
  • 35172cd: 8278951: containers/cgroup/PlainRead.java fails on Ubuntu 21.10
  • 237f861: 8273143: Transition to _thread_in_vm when handling a polling page exception
  • 9209e6d: 8279877: Document IDEA IDE setup in docs/ide.md
  • 0a839b4: 8279801: EC KeyFactory and KeyPairGenerator do not have aliases for OID format
  • 6fcaa32: 8262442: (windows) Use all proxy configuration sources when java.net.useSystemProxies=true
  • c17a012: 8278961: Enable debug logging in java/net/DatagramSocket/SendDatagramToBadAddress.java
  • b61a4af: 8259774: Deprecate -XX:FlightRecorderOptions:samplethreads
  • ... and 12 more: https://git.openjdk.java.net/jdk/compare/ddddec7d74745905230282124524a0dbdd1bd1c1...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Jan 14, 2022
Copy link
Member

@Michael-Mc-Mahon Michael-Mc-Mahon left a comment

LGTM

@FrauBoes
Copy link
Member Author

FrauBoes commented Jan 14, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Jan 14, 2022

Going to push as commit 9f30ec1.
Since your change was applied there have been 22 commits pushed to the master branch:

  • dd76a28: 8280000: Remove unused CardTable::find_covering_region_containing
  • 84976b4: 8278549: UNIX sun/font coding misses SUSE distro detection on recent distro SUSE 15
  • 965c64b: 8279699: Parallel: More precise boundary in ObjectStartArray::object_starts_in_range
  • 35172cd: 8278951: containers/cgroup/PlainRead.java fails on Ubuntu 21.10
  • 237f861: 8273143: Transition to _thread_in_vm when handling a polling page exception
  • 9209e6d: 8279877: Document IDEA IDE setup in docs/ide.md
  • 0a839b4: 8279801: EC KeyFactory and KeyPairGenerator do not have aliases for OID format
  • 6fcaa32: 8262442: (windows) Use all proxy configuration sources when java.net.useSystemProxies=true
  • c17a012: 8278961: Enable debug logging in java/net/DatagramSocket/SendDatagramToBadAddress.java
  • b61a4af: 8259774: Deprecate -XX:FlightRecorderOptions:samplethreads
  • ... and 12 more: https://git.openjdk.java.net/jdk/compare/ddddec7d74745905230282124524a0dbdd1bd1c1...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated label Jan 14, 2022
@openjdk openjdk bot closed this Jan 14, 2022
@openjdk openjdk bot removed ready rfr labels Jan 14, 2022
@openjdk
Copy link

openjdk bot commented Jan 14, 2022

@FrauBoes Pushed as commit 9f30ec1.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@FrauBoes FrauBoes deleted the 8278398 branch Jan 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated net
4 participants