Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JDK-8254843: Exception launching app on windows in some cases #706

Closed
wants to merge 1 commit into from

Conversation

@andyherrick
Copy link

@andyherrick andyherrick commented Oct 16, 2020

JDK-8254843: Exception launching app on windows in some cases
loading splashscreen.dll in WinLaunchercpp would load java.dll from path instead of runtime/bin causing jni launcher to crash.
instead we just use what used to be the fallback, using loadDllWithAddDllDirectory().


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Testing

Linux x64 Windows x64 macOS x64
Build ✔️ (5/5 passed) ✔️ (2/2 passed) ✔️ (2/2 passed)
Test (tier1) ✔️ (9/9 passed) ✔️ (9/9 passed) (1/9 failed)

Failed test task

Issue

  • JDK-8254843: Exception launching app on windows in some cases

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/706/head:pull/706
$ git checkout pull/706

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Oct 16, 2020

👋 Welcome back herrick! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Oct 16, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Oct 16, 2020

@andyherrick The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the core-libs label Oct 16, 2020
@mlbridge
Copy link

@mlbridge mlbridge bot commented Oct 16, 2020

Webrevs

Copy link
Member

@kevinrushforth kevinrushforth left a comment

Looks good. I verified that it fixes the problem.

@andyherrick
Copy link
Author

@andyherrick andyherrick commented Oct 19, 2020

@azuev-java - can you review also ?

Copy link
Member

@azuev-java azuev-java left a comment

Looks fine to me.

@openjdk
Copy link

@openjdk openjdk bot commented Oct 20, 2020

@andyherrick This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8254843: Exception launching app on windows in some cases

Reviewed-by: asemenyuk, kcr, almatvee, kizune

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 128 new commits pushed to the master branch:

  • 856037c: 8255006: Add NULL-check to StringDedupTable lookup
  • ee6eb98: 8254995: [x86] ControlWord::print(), rc/pc variables might not be initialized
  • e577c8c: 8253641: Missing newline in the printout of certain JFR events
  • 89e5444: 8254788: Dead code in the sun.java2d.xr.XRPMBlitLoops$XrSwToPMBlit
  • 3267b09: 8254883: ZGC: Make the ZArrayIterator reusable for ZRelocationSetIterators
  • cb6167b: 8254557: Compiler crashes with java.lang.AssertionError: isSubtype UNKNOWN
  • 40f847e: 8227745: Enable Escape Analysis for Better Performance in the Presence of JVMTI Agents
  • f167a71: 8254264: Remove redundant cross_modify_fence()
  • 44f9271: 8254974: Fix stutter typo in TypeElement
  • 76fdd7f: 8255038: Adjust adapter_code_size to account for -Xlog:methodhandles in debug builds
  • ... and 118 more: https://git.openjdk.java.net/jdk/compare/d7128e7daceca8b3717f3a3cd2f7a6ddba6f215d...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Oct 20, 2020
@andyherrick
Copy link
Author

@andyherrick andyherrick commented Oct 20, 2020

/integrate

@openjdk openjdk bot closed this Oct 20, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Oct 20, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Oct 20, 2020

@andyherrick Since your change was applied there have been 128 commits pushed to the master branch:

  • 856037c: 8255006: Add NULL-check to StringDedupTable lookup
  • ee6eb98: 8254995: [x86] ControlWord::print(), rc/pc variables might not be initialized
  • e577c8c: 8253641: Missing newline in the printout of certain JFR events
  • 89e5444: 8254788: Dead code in the sun.java2d.xr.XRPMBlitLoops$XrSwToPMBlit
  • 3267b09: 8254883: ZGC: Make the ZArrayIterator reusable for ZRelocationSetIterators
  • cb6167b: 8254557: Compiler crashes with java.lang.AssertionError: isSubtype UNKNOWN
  • 40f847e: 8227745: Enable Escape Analysis for Better Performance in the Presence of JVMTI Agents
  • f167a71: 8254264: Remove redundant cross_modify_fence()
  • 44f9271: 8254974: Fix stutter typo in TypeElement
  • 76fdd7f: 8255038: Adjust adapter_code_size to account for -Xlog:methodhandles in debug builds
  • ... and 118 more: https://git.openjdk.java.net/jdk/compare/d7128e7daceca8b3717f3a3cd2f7a6ddba6f215d...master

Your commit was automatically rebased without conflicts.

Pushed as commit acacae5.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@andyherrick andyherrick deleted the JDK-8254843 branch Oct 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment