Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8279958: Provide configure hints for Alpine/apk package managers #7064

Closed
wants to merge 1 commit into from

Conversation

shipilev
Copy link
Member

@shipilev shipilev commented Jan 13, 2022

Our build system provides helpful hints about the packages to install to resolve the build-time dependencies. It can be amended to include Alpine/apk package managers. Noticed this when trying to build mainline OpenJDK on Alpine 3.

Additional testing:

  • Was able to build on clean Alpine 3 with these hints

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8279958: Provide configure hints for Alpine/apk package managers

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/7064/head:pull/7064
$ git checkout pull/7064

Update a local copy of the PR:
$ git checkout pull/7064
$ git pull https://git.openjdk.java.net/jdk pull/7064/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 7064

View PR using the GUI difftool:
$ git pr show -t 7064

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/7064.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 13, 2022

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jan 13, 2022
@openjdk
Copy link

openjdk bot commented Jan 13, 2022

@shipilev The following label will be automatically applied to this pull request:

  • build

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the build build-dev@openjdk.org label Jan 13, 2022
@mlbridge
Copy link

mlbridge bot commented Jan 13, 2022

Webrevs

@openjdk
Copy link

openjdk bot commented Jan 13, 2022

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8279958: Provide configure hints for Alpine/apk package managers

Reviewed-by: erikj

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 19 new commits pushed to the master branch:

  • c17a012: 8278961: Enable debug logging in java/net/DatagramSocket/SendDatagramToBadAddress.java
  • b61a4af: 8259774: Deprecate -XX:FlightRecorderOptions:samplethreads
  • 6933934: 8278597: Remove outdated comments regarding RMISecurityManager in HotSpotAgent.java
  • 4851948: 8279903: Redundant modulo operation in ECDHKeyAgreement
  • 67e3d51: Merge
  • 5aecb37: 8206181: ExceptionInInitializerError: improve handling of exceptions in user-provided taglets
  • 86d0abb: 8279695: [TESTBUG] modify compiler/loopopts/TestSkeletonPredicateNegation.java to run on C1 also
  • 6d7db4b: 8279356: Method linking fails with guarantee(mh->adapter() != NULL) failed: Adapter blob must already exist!
  • 92307e5: 8278489: Preserve result in native wrapper with +UseHeavyMonitors
  • bbc1ddb: 8278267: ARM32: several vector test failures for ASHR
  • ... and 9 more: https://git.openjdk.java.net/jdk/compare/525b20fce0acd393f31fd37fe1f05f9d32577f77...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jan 13, 2022
@shipilev
Copy link
Member Author

Since this is a simple change and at least one build system maintainer acked this, I am integrating.

/integrate

@openjdk
Copy link

openjdk bot commented Jan 17, 2022

Going to push as commit a30aa52.
Since your change was applied there have been 45 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 17, 2022
@openjdk openjdk bot closed this Jan 17, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 17, 2022
@openjdk
Copy link

openjdk bot commented Jan 17, 2022

@shipilev Pushed as commit a30aa52.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@shipilev shipilev deleted the JDK-8279958-alpine-hints branch January 27, 2022 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build build-dev@openjdk.org integrated Pull request has been integrated
2 participants