-
Notifications
You must be signed in to change notification settings - Fork 6.2k
8279958: Provide configure hints for Alpine/apk package managers #7064
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
👋 Welcome back shade! A progress list of the required criteria for merging this PR into |
|
@shipilev This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 19 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
|
Since this is a simple change and at least one build system maintainer acked this, I am integrating. /integrate |
|
Going to push as commit a30aa52.
Your commit was automatically rebased without conflicts. |
Our build system provides helpful hints about the packages to install to resolve the build-time dependencies. It can be amended to include Alpine/apk package managers. Noticed this when trying to build mainline OpenJDK on Alpine 3.
Additional testing:
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/7064/head:pull/7064$ git checkout pull/7064Update a local copy of the PR:
$ git checkout pull/7064$ git pull https://git.openjdk.java.net/jdk pull/7064/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 7064View PR using the GUI difftool:
$ git pr show -t 7064Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/7064.diff