JDK-8253936 Replace <code>...</code> with {@code ...} for java.sql #707

Vipin-Sharma · 2020-10-16T19:38:45Z

... is replaced with {@code ...} in java.sql classes.
Please review and sponsor this change.

Progress

Change must not contain extraneous whitespace
Commit message must refer to an issue
Change must be properly reviewed

Testing

	Linux x64	Windows x64	macOS x64
Build	✔️ (5/5 passed)	✔️ (2/2 passed)	✔️ (2/2 passed)
Test (tier1)	✔️ (9/9 passed)	✔️ (9/9 passed)	✔️ (9/9 passed)

Issue

JDK-8253936: Replace ... with {@code ...} for java.sql

Reviewers

Lance Andersen (@LanceAndersen - Reviewer)

Download

$ git fetch https://git.openjdk.java.net/jdk pull/707/head:pull/707
$ git checkout pull/707

bridgekeeper · 2020-10-16T19:39:39Z

👋 Welcome back vsharma! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2020-10-16T19:42:33Z

@Vipin-Sharma The following label will be automatically applied to this pull request:

core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

mlbridge · 2020-10-16T19:45:16Z

Webrevs

01: Full - Incremental (0823d56)
00: Full (89245f3)

mlbridge · 2020-10-16T20:56:15Z

Mailing list message from Lance Andersen on core-libs-dev:

Hi Vipin,

Have you generated the javadocs for this change? If not I will pull the changes over this weekend and take a look

Best
Lance
------------------

Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering
1 Network Drive
Burlington, MA 01803
Lance.Andersen at oracle.com

Vipin-Sharma · 2020-10-17T07:26:17Z

Hi @LanceAndersen,

I have generated javadoc before and after change. Following are 3 differences showing side by side comparison here.

DriverManager.java - line 417 (Change: CODE replaced with code)
d.getClass().getName() | d.getClass().getName()

ResultSet.java - line 3085 (Change: CODE replaced with code)
the result set concurrency is CONCUR_READ_ONLY | the result set concurrency is CONCUR_READ_ONLY

SQLClientInfoException.java - line 60 (Change: removed space before null)
null and the vendor code is initialized to 0. | null and the vendor code is initialized to 0.

All the above three changes doesn't change the effective view.

LanceAndersen

Hi Vipin

Thank you for tackling this update. There are a few required changes below. I will also be going through the generated javadoc to see if anything jumps out as well.

Best
Lance

LanceAndersen · 2020-10-20T21:07:32Z

src/java.sql/share/classes/java/sql/BatchUpdateException.java

   * <p>
   * <strong>Note:</strong> There is no validation of {@code updateCounts} for
   * overflow and because of this it is recommended that you use the constructor
   * {@code BatchUpdateException(String reason, String SQLState,
   * int vendorCode, long []updateCounts,Throwable cause) }.
   * </p>
   * @param reason a description of the exception
-   * @param updateCounts an array of <code>int</code>, with each element
-   *indicating the update count, <code>Statement.SUCCESS_NO_INFO</code> or


Please add a space before indicating

LanceAndersen · 2020-10-20T21:34:07Z

src/java.sql/share/classes/java/sql/DataTruncation.java

@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 1996, 2013, Oracle and/or its affiliates. All rights reserved.
+ * Copyright (c) 1996, 2013, 2020, Oracle and/or its affiliates. All rights reserved.


The copyright update is incorrect, it should be 1996, 2020

LanceAndersen · 2020-10-20T22:25:55Z

src/java.sql/share/classes/java/sql/DriverPropertyInfo.java

@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 1996, 2013, Oracle and/or its affiliates. All rights reserved.
+ * Copyright (c) 1996, 2013, 2020, Oracle and/or its affiliates. All rights reserved.


Please correct the copyright as mentioned above

LanceAndersen · 2020-10-20T22:26:59Z

src/java.sql/share/classes/java/sql/NClob.java

@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2005, 2013, Oracle and/or its affiliates. All rights reserved.
+ * Copyright (c) 2005, 2013, 2020, Oracle and/or its affiliates. All rights reserved.


Please fix the copyright

LanceAndersen · 2020-10-20T22:50:30Z

src/java.sql/share/classes/java/sql/ResultSet.java

@@ -1998,11 +1998,11 @@ void updateObject(int columnIndex, Object x, int scaleOrLength)
    void updateLong(String columnLabel, long x) throws SQLException;

    /**
-     * Updates the designated column with a <code>float </code> value.
+     * Updates the designated column with a {@code float } value.


Please remove the space after float

LanceAndersen · 2020-10-20T23:34:24Z

src/java.sql/share/classes/javax/sql/ConnectionEvent.java

@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2000, 2006, Oracle and/or its affiliates. All rights reserved.
+ * Copyright (c) 2000, 2006, 2020, Oracle and/or its affiliates. All rights reserved.


please fix the copyright

LanceAndersen · 2020-10-20T23:34:56Z

src/java.sql/share/classes/javax/sql/ConnectionEventListener.java

@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2000, 2001, Oracle and/or its affiliates. All rights reserved.
+ * Copyright (c) 2000, 2001, 2020, Oracle and/or its affiliates. All rights reserved.


please fix the copyright

LanceAndersen · 2020-10-20T23:43:04Z

src/java.sql/share/classes/javax/sql/RowSetEvent.java

@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2000, 2006, Oracle and/or its affiliates. All rights reserved.
+ * Copyright (c) 2000, 2006, 2020, Oracle and/or its affiliates. All rights reserved.


please fix the copyright

LanceAndersen · 2020-10-20T23:43:52Z

src/java.sql/share/classes/javax/sql/RowSetListener.java

@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2000, 2001, Oracle and/or its affiliates. All rights reserved.
+ * Copyright (c) 2000, 2001, 2020, Oracle and/or its affiliates. All rights reserved.


please fix the copyright

LanceAndersen · 2020-10-20T23:45:52Z

src/java.sql/share/classes/javax/sql/StatementEventListener.java

@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2005, 2014, Oracle and/or its affiliates. All rights reserved.
+ * Copyright (c) 2005, 2014, 2020, Oracle and/or its affiliates. All rights reserved.


please fix the copyright

openjdk · 2020-11-04T19:30:06Z

@Vipin-Sharma This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8253936: Replace <code>...</code> with {@code ...} for java.sql

Reviewed-by: lancea

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 350 new commits pushed to the master branch:

166c728: 8255858: Add debug agent support for storing thread names
a0ade22: 8255900: x86: Reduce impact when VerifyOops is disabled
29db1dc: 8255886: Shenandoah: Resolve cset address truncation and register clash in interpreter LRB
26e7ef7: 8252870: Finalize (remove "incubator" from) jpackage
804bd72: 8255128: linux x86 build failure with libJNIPoint.c
160759c: 8255838: Use 32-bit immediate movslq in macro assembler if 64-bit value fits in 32 bits on x86_64
94ace03: 8255863: Clean up test/jdk/java/lang/invoke/defineHiddenClass/BasicTest.java
2da9981: 8255862: Remove @SuppressWarnings from sun.misc.Unsafe
5348298: 8255855: appcds/jigsaw/NewModuleFinderTest.java test failed due to unexpected NPE
c287170: 8254742: InputStream::readNBytes(int) result may contain zeros not in input
... and 340 more: https://git.openjdk.java.net/jdk/compare/07ec35e2e50bde9d3cf9e35733837dfd377ef1ab...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@LanceAndersen) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

Vipin-Sharma · 2020-11-04T23:20:33Z

/integrate

openjdk · 2020-11-04T23:21:06Z

@Vipin-Sharma
Your change (at version 0823d56) is now ready to be sponsored by a Committer.

Vipin-Sharma · 2020-11-25T14:31:04Z

I think all steps are completed for this PR, please help sponsoring this.

LanceAndersen · 2020-11-25T16:00:48Z

/sponsor

openjdk · 2020-11-25T16:01:58Z

@LanceAndersen @Vipin-Sharma Since your change was applied there have been 668 commits pushed to the master branch:

cfb175d: 8256508: Improve CompileCommand flag
7aed9b6: 8256016: Dacapo24H.java failed with "assert(false) failed: unscheduable graph"
26e6cb3: 8256489: Make gtest for long path names on Windows more resilient in the presence of virus scanners
911f16d: 8257056: Submit workflow should apt-get update to avoid package installation errors
b0bd0c2: 8256755: Update build.tools.depend.Depend to handle record components in API signatures
9aeadbb: 8256865: Foreign Memory Access and Linker API are missing NPE checks
8cd2e0f: 8243315: ParallelScavengeHeap::initialize() passes GenAlignment as page size to os::trace_page_sizes instead of actual page size
cdb41ba: 8255904: Remove superfluous use of reflection in Class::isRecord
c45725e: 8256747: GitHub Actions: decouple the hotspot build-only jobs from Linux x64 testing
79e57ac: 8256643: Terminally deprecate ThreadGroup stop, destroy, isDestroyed, setDaemon and isDaemon
... and 658 more: https://git.openjdk.java.net/jdk/compare/07ec35e2e50bde9d3cf9e35733837dfd377ef1ab...master

Your commit was automatically rebased without conflicts.

Pushed as commit dee79d6.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Reviewed-by: lancea

JDK-8253936 Replace <code>...</code> with {@code ...} for java.sql

89245f3

openjdk bot added the rfr Pull request is ready for review label Oct 16, 2020

openjdk bot added the core-libs core-libs-dev@openjdk.org label Oct 16, 2020

LanceAndersen suggested changes Oct 20, 2020

View reviewed changes

Updated copyright year and other issues reporrted in review

0823d56

LanceAndersen approved these changes Nov 4, 2020

View reviewed changes

openjdk bot added the ready Pull request is ready to be integrated label Nov 4, 2020

openjdk bot added the sponsor Pull request is ready to be sponsored label Nov 4, 2020

openjdk bot closed this Nov 25, 2020

openjdk bot added integrated Pull request has been integrated and removed sponsor Pull request is ready to be sponsored ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 25, 2020

openjdk-notifier bot referenced this pull request Nov 25, 2020

8253936: Replace <code>...</code> with {@code ...} for java.sql

dee79d6

Reviewed-by: lancea

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

JDK-8253936 Replace <code>...</code> with {@code ...} for java.sql #707

JDK-8253936 Replace <code>...</code> with {@code ...} for java.sql #707

Vipin-Sharma commented Oct 16, 2020 •

edited by openjdk bot

Loading

bridgekeeper bot commented Oct 16, 2020

openjdk bot commented Oct 16, 2020

mlbridge bot commented Oct 16, 2020 •

edited

Loading

mlbridge bot commented Oct 16, 2020

Vipin-Sharma commented Oct 17, 2020

LanceAndersen left a comment

LanceAndersen Oct 20, 2020

LanceAndersen Oct 20, 2020

LanceAndersen Oct 20, 2020

LanceAndersen Oct 20, 2020

LanceAndersen Oct 20, 2020

LanceAndersen Oct 20, 2020

LanceAndersen Oct 20, 2020

LanceAndersen Oct 20, 2020

LanceAndersen Oct 20, 2020

LanceAndersen Oct 20, 2020

openjdk bot commented Nov 4, 2020 •

edited

Loading

Vipin-Sharma commented Nov 4, 2020

openjdk bot commented Nov 4, 2020

Vipin-Sharma commented Nov 25, 2020

LanceAndersen commented Nov 25, 2020

openjdk bot commented Nov 25, 2020

JDK-8253936 Replace <code>...</code> with {@code ...} for java.sql #707

JDK-8253936 Replace <code>...</code> with {@code ...} for java.sql #707

Conversation

Vipin-Sharma commented Oct 16, 2020 • edited by openjdk bot Loading

Progress

Testing

Issue

Reviewers

Download

bridgekeeper bot commented Oct 16, 2020

openjdk bot commented Oct 16, 2020

mlbridge bot commented Oct 16, 2020 • edited Loading

Webrevs

mlbridge bot commented Oct 16, 2020

Vipin-Sharma commented Oct 17, 2020

LanceAndersen left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

openjdk bot commented Nov 4, 2020 • edited Loading

Vipin-Sharma commented Nov 4, 2020

openjdk bot commented Nov 4, 2020

Vipin-Sharma commented Nov 25, 2020

LanceAndersen commented Nov 25, 2020

openjdk bot commented Nov 25, 2020

Vipin-Sharma commented Oct 16, 2020 •

edited by openjdk bot

Loading

mlbridge bot commented Oct 16, 2020 •

edited

Loading

openjdk bot commented Nov 4, 2020 •

edited

Loading