8279970: two AppCDS tests fail after JDK-8261455 #7070

yminqi · 2022-01-13T21:14:05Z

Please review
The failure of the two tests is from jtreg run with -Xshare:off, the arguments caused confusion with the test cases. In fact they should be avoided to run with CDS is disabled.

Tests: tier5 (in testing)
Manually repeat the test failure in local jtreg, and passed jtreg in local.

Thanks
Yumin

Progress

Change must not contain extraneous whitespace
Commit message must refer to an issue
Change must be properly reviewed

Issue

JDK-8279970: two AppCDS tests fail after JDK-8261455

Reviewers

Calvin Cheung (@calvinccheung - Reviewer)
Ioi Lam (@iklam - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/7070/head:pull/7070
$ git checkout pull/7070

Update a local copy of the PR:
$ git checkout pull/7070
$ git pull https://git.openjdk.java.net/jdk pull/7070/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 7070

View PR using the GUI difftool:
$ git pr show -t 7070

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/7070.diff

bridgekeeper · 2022-01-13T21:15:42Z

👋 Welcome back minqi! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2022-01-13T21:17:44Z

@yminqi The following label will be automatically applied to this pull request:

hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

mlbridge · 2022-01-13T21:22:49Z

Webrevs

yminqi · 2022-01-14T01:10:01Z

Passed tier5

calvinccheung · 2022-01-14T02:55:35Z

test/hotspot/jtreg/runtime/cds/appcds/dynamicArchive/TestAutoCreateSharedArchive.java

+            System.out.println("This test is not applicable when JTREG tests are executed with -Xshare:off, or if the JDK doesn't have a default archive.");
+            return;


Suggestion: throw a SkippedException instead of System.out.println.

calvinccheung · 2022-01-14T02:55:55Z

test/hotspot/jtreg/runtime/cds/appcds/loaderConstraints/DynamicLoaderConstraintsTest.java

+            System.out.println("This test is not applicable when JTREG tests are executed with -Xshare:off, or if the JDK doesn't have a default archive.");
+            return;


Same suggestion as above.

calvinccheung

Changes look okay. One suggestion below.

dcubed-ojdk · 2022-01-14T17:27:11Z

We're seeing 7 failures due to this issue per Tier5. Is there an ETA for
when this fix will be integrated?

dcubed-ojdk · 2022-01-14T21:43:03Z

Tap, tap, tap... is this thing working? What's the ETA for when this
fix will be integrated? I really don't want to go into a 3 day weekend
with 7 failures per Tier5...

dcubed-ojdk · 2022-01-14T22:25:34Z

@yminqi - You'll want to merge 'master' into this branch and then update
this PR to UnProblemList the two tests when you get back to this bug
next week.

…failed due to base archive not in consistency, fixed with correct options to dump

calvinccheung

Updates look good.

openjdk · 2022-01-18T23:20:00Z

@yminqi This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8279970: two AppCDS tests fail after JDK-8261455

Reviewed-by: ccheung, iklam

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

iklam

LGTM

yminqi · 2022-01-19T03:20:42Z

@iklam @calvinccheung Thanks for review!

yminqi · 2022-01-19T03:20:51Z

/integrate

openjdk · 2022-01-19T03:21:31Z

Going to push as commit b0496b0.
Since your change was applied there have been 2 commits pushed to the master branch:

4eb4f94: 8279956: Useless method Scheduling::ComputeLocalLatenciesForward()
4f4da3b: 8275318: loaded_classes_do may see ArrayKlass before InstanceKlass is loaded

Your commit was automatically rebased without conflicts.

openjdk · 2022-01-19T03:21:46Z

@yminqi Pushed as commit b0496b0.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

8279970: two AppCDS tests fail after JDK-8261455

2c4f711

openjdk bot added the hotspot-runtime hotspot-runtime-dev@openjdk.org label Jan 13, 2022

yminqi marked this pull request as ready for review January 13, 2022 21:18

openjdk bot added the rfr Pull request is ready for review label Jan 13, 2022

calvinccheung reviewed Jan 14, 2022

View reviewed changes

Use SkippedExceptin instead return, DynamicLoaderConstrainsTest.java …

67206c9

…failed due to base archive not in consistency, fixed with correct options to dump

openjdk bot removed the rfr Pull request is ready for review label Jan 18, 2022

Yumin Qi added 2 commits January 18, 2022 14:52

Merge branch 'master' into jdk-8279770

0ec2617

Remove failed tests from problem list

86db569

openjdk bot added the rfr Pull request is ready for review label Jan 18, 2022

calvinccheung approved these changes Jan 18, 2022

View reviewed changes

openjdk bot added the ready Pull request is ready to be integrated label Jan 18, 2022

iklam approved these changes Jan 18, 2022

View reviewed changes

openjdk bot added the integrated Pull request has been integrated label Jan 19, 2022

openjdk bot closed this Jan 19, 2022

openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 19, 2022

yminqi deleted the jdk-8279770 branch January 19, 2022 03:26

		System.out.println("This test is not applicable when JTREG tests are executed with -Xshare:off, or if the JDK doesn't have a default archive.");
		return;

8279970: two AppCDS tests fail after JDK-8261455 #7070

8279970: two AppCDS tests fail after JDK-8261455 #7070

Uh oh!

Conversation

yminqi commented Jan 13, 2022 • edited by openjdk bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Progress

Issue

Reviewers

Reviewing

Uh oh!

bridgekeeper bot commented Jan 13, 2022

Uh oh!

openjdk bot commented Jan 13, 2022

Uh oh!

mlbridge bot commented Jan 13, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Webrevs

Uh oh!

yminqi commented Jan 14, 2022

Uh oh!

calvinccheung Jan 14, 2022

Choose a reason for hiding this comment

Uh oh!

calvinccheung Jan 14, 2022

Choose a reason for hiding this comment

Uh oh!

calvinccheung left a comment

Choose a reason for hiding this comment

Uh oh!

dcubed-ojdk commented Jan 14, 2022

Uh oh!

dcubed-ojdk commented Jan 14, 2022

Uh oh!

dcubed-ojdk commented Jan 14, 2022

Uh oh!

calvinccheung left a comment

Choose a reason for hiding this comment

Uh oh!

openjdk bot commented Jan 18, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

iklam left a comment

Choose a reason for hiding this comment

Uh oh!

yminqi commented Jan 19, 2022

Uh oh!

yminqi commented Jan 19, 2022

Uh oh!

openjdk bot commented Jan 19, 2022

Uh oh!

openjdk bot commented Jan 19, 2022

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

4 participants

yminqi commented Jan 13, 2022 •

edited by openjdk bot

Loading

mlbridge bot commented Jan 13, 2022 •

edited

Loading

openjdk bot commented Jan 18, 2022 •

edited

Loading