8279970: two AppCDS tests fail after JDK-8261455

[yminqi]

Please review
The failure of the two tests is from jtreg run with -Xshare:off, the arguments caused confusion with the test cases. In fact they should be avoided to run with CDS is disabled.

Tests: tier5 (in testing)
Manually repeat the test failure in local jtreg, and passed jtreg in local.

Thanks
Yumin

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8279970: two AppCDS tests fail after JDK-8261455

Reviewers

• Calvin Cheung (@calvinccheung - Reviewer)
• Ioi Lam (@iklam - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/7070/head:pull/7070
$ git checkout pull/7070

Update a local copy of the PR:
$ git checkout pull/7070
$ git pull https://git.openjdk.java.net/jdk pull/7070/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 7070

View PR using the GUI difftool:
$ git pr show -t 7070

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/7070.diff

[bridgekeeper]

👋 Welcome back minqi! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@yminqi The following label will be automatically applied to this pull request:

• hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 02: Full - Incremental (86db5699)
• 01: Full - Incremental (67206c90)
• 00: Full (2c4f711e)

[yminqi]

Passed tier5

[calvinccheung]

Suggestion: throw a SkippedException instead of System.out.println.

[calvinccheung]

Same suggestion as above.

[calvinccheung]

Changes look okay. One suggestion below.

[dcubed-ojdk]

We're seeing 7 failures due to this issue per Tier5. Is there an ETA for
when this fix will be integrated?

[dcubed-ojdk]

Tap, tap, tap... is this thing working? What's the ETA for when this
fix will be integrated? I really don't want to go into a 3 day weekend
with 7 failures per Tier5...

[dcubed-ojdk]

@yminqi - You'll want to merge 'master' into this branch and then update
this PR to UnProblemList the two tests when you get back to this bug
next week.

[calvinccheung]

Updates look good.

[openjdk]

@yminqi This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8279970: two AppCDS tests fail after JDK-8261455

Reviewed-by: ccheung, iklam

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[iklam]

LGTM

[yminqi]

@iklam @calvinccheung Thanks for review!

[yminqi]

/integrate

[openjdk]

Going to push as commit b0496b0.
Since your change was applied there have been 2 commits pushed to the master branch:

• 4eb4f94: 8279956: Useless method Scheduling::ComputeLocalLatenciesForward()
• 4f4da3b: 8275318: loaded_classes_do may see ArrayKlass before InstanceKlass is loaded

Your commit was automatically rebased without conflicts.

[openjdk]

@yminqi Pushed as commit b0496b0.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.