8279878: java/awt/font/JNICheck/JNICheck.sh test fails on Ubuntu 21.10

[prrace]

Some more signal handler related warning strings from the VM need to be excluded from what this test considers a failure

See the bug for more info.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8279878: java/awt/font/JNICheck/JNICheck.sh test fails on Ubuntu 21.10

Reviewers

• Sergey Bylokhov (@mrserb - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/7091/head:pull/7091
$ git checkout pull/7091

Update a local copy of the PR:
$ git checkout pull/7091
$ git pull https://git.openjdk.java.net/jdk pull/7091/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 7091

View PR using the GUI difftool:
$ git pr show -t 7091

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/7091.diff

[bridgekeeper]

👋 Welcome back prr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@prrace The following label will be automatically applied to this pull request:

• client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (08918228)

[mrserb]

Maybe we can ask some ppl from the hotspot team about this issue, is it a critical thing that these handlers are overwritten by probably GTK3? Can it cause a crash or something?

[tstuefe]

In hotspot, we want to explicitly ignore SIGPIPE and SIGXFSZ (see https://bugs.openjdk.java.net/browse/JDK-4229104 and https://bugs.openjdk.java.net/browse/JDK-6499219). But we don't do SIG_IGN, since we still need to give chained handlers the opportunity to handle them. See

jdk/src/hotspot/os/posix/signals_posix.cpp

Lines 618 to 623 in fef8f2d

	// Ignore SIGPIPE and SIGXFSZ (4229104, 6499219).
	if (!signal_was_handled &&
	(sig == SIGPIPE || sig == SIGXFSZ)) {
	PosixSignals::chained_handler(sig, info, ucVoid);
	signal_was_handled = true; // unconditionally.
	}

.

So now, from the OS perspective, we handle SIGPIPE. We just don't do anything but return from the signal handler (ignoring chained handlers for now). If someone outside sets SIGPIPE to SIG_IGN, then we get subtle changes:

• IO calls would now yield EPIPE, whereas now I am not sure what happens? Does the IO call report success?
• Also, chained handlers would not get called.

It's all pretty unexciting. Nothing would crash. There may be an argument for skipping the test on SIGPIPE if it is SIG_IGN and we don't have chained handlers. If it seems such a standard thing to do for third party libraries. Idk. Maybe open a separate bug?

[mrserb]

Probably we have some tests which may validate that even if our handlers are not default the external handler will call ours by chain(or something like that)? Or maybe we should restore them?

[prrace]

The discussion seems to have gone off somewhere unrelated to this client test.
Feel free to file a hotspot test RFE and let's get the test update pushed

[mrserb]

I am still not sure can we do something about this, depending on that we should update the test/problem list/file another client bug/another hotspot bug?

[prrace]

I am still not sure can we do something about this, depending on that we should update the test/problem list/file another client bug/another hotspot bug?

I can't work out what you are saying/expecting.
The test is nothing to do with signals so that is just noise. We already parse out such noise.
We have two options. Parse out the noise or disable the test because of this irrelevant noise and then miss when the problem it cares about is introduced.
Which is better ?

[mrserb]

So can we file a bug against someone? We should do something about it.

[openjdk]

@prrace This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8279878: java/awt/font/JNICheck/JNICheck.sh test fails on Ubuntu 21.10

Reviewed-by: serb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 263 new commits pushed to the master branch:

• 85d839f: 8280601: ClhsdbThreadContext.java test is triggering codecache related asserts
• 9ca7ff3: 8281082: Improve javadoc references to JOSS
• c74b8f4: 8275914: SHA3: changing java implementation to help C2 create high-performance code
• a18beb4: 8280867: Cpuid1Ecx feature parsing is incorrect for AMD CPUs
• fdd9ca7: 8280642: ObjectInputStream.readObject should throw InvalidClassException instead of IllegalAccessError
• d95de5c: 8255495: Support CDS Archived Heap for uncompressed oops
• bde2b37: 8279954: java/lang/StringBuffer(StringBuilder)/HugeCapacity.java intermittently fails
• d1cc5fd: 8280941: os::print_memory_mappings() prints segment preceeding the inclusion range
• 4532c3a: 8280554: resourcehogs/serviceability/sa/ClhsdbRegionDetailsScanOopsForG1.java can fail if GC is triggered
• 5080e81: 8280770: serviceability/sa/ClhsdbThreadContext.java sometimes fails with 'Thread "SteadyStateThread"' missing from stdout/stderr
• ... and 253 more: https://git.openjdk.java.net/jdk/compare/d9dd485b95e1796822c0dcfaed8a28328b0a976a...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[prrace]

/integrate

[openjdk]

Going to push as commit 2f48a3f.
Since your change was applied there have been 305 commits pushed to the master branch:

• f7814c1: 8139173: [macosx] JInternalFrame shadow is not properly drawn
• 77b0240: 8281183: RandomGenerator:NextDouble() default behavior partially fixed by JDK-8280950
• 42e272e: 8281289: Improve with List.copyOf
• 48523b0: 8281049: man page update for jstatd Security Manager dependency removal
• 8e4ef81: 8280767: -XX:ArchiveClassesAtExit does not archive BoundMethodHandle$Species classes
• f5d6fdd: 8280476: [macOS] : hotspot arm64 bug exposed by latest clang
• d4b99bc: 8281120: G1: Rename G1BlockOffsetTablePart::alloc_block to update_for_block
• 66b2c3b: 8280948: [TESTBUG] Write a regression test for JDK-4659800
• 7207f2a: Merge
• 01f93dd: 8279385: [test] Adjust sun/security/pkcs12/KeytoolOpensslInteropTest.java after 8278344
• ... and 295 more: https://git.openjdk.java.net/jdk/compare/d9dd485b95e1796822c0dcfaed8a28328b0a976a...master

Your commit was automatically rebased without conflicts.

[openjdk]

@prrace Pushed as commit 2f48a3f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.