JDK-8248320: Provide a unique accessible name for <nav role="navigation"> #710
@jonathan-gibbons this pull request can not be integrated into
git checkout 8248320-navigation git fetch https://git.openjdk.java.net/jdk master git merge FETCH_HEAD # resolve conflicts and follow the instructions given by git merge git commit -m "Merge master" git push
@jonathan-gibbons This change now passes all automated pre-integration checks.
ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.
After integration, the commit message for the final commit will be:
At the time when this comment was updated there had been no new commits pushed to the
➡️ To integrate this PR with the above commit message to the
Thanks; I'll take care of that cleanup.…
On 11/3/20 2:25 AM, Hannes Wallnoefer wrote: ***@***.**** approved this pull request. Looks good, Jon! In order to clean up, the following could and should probably be removed: * |HtmlStyle.bottomNav| * Instances of |bottom-nav| in stylesheet.css * |*_BOTTOM_NAVBAR| constants in MarkerComments — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <https://urldefense.com/v3/__https://github.com/openjdk/jdk/pull/710*pullrequestreview-522358876__;Iw!!GqivPVa7Brio!OZ9iGgSl8q-Drk_U444pXFzZHIhWqvKUkfERyZg-zXFchd9lsdYUk8LZnQ4eBPohDTKmQA$>, or unsubscribe <https://urldefense.com/v3/__https://github.com/notifications/unsubscribe-auth/AOUXBRXQQRGLYLFS2OADNUDSN7LALANCNFSM4STZDN6Q__;!!GqivPVa7Brio!OZ9iGgSl8q-Drk_U444pXFzZHIhWqvKUkfERyZg-zXFchd9lsdYUk8LZnQ4eBPqhVzAmtw$>.