Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

8254862: lldb in devkit doesn't work #711

Closed
wants to merge 1 commit into from
Closed

8254862: lldb in devkit doesn't work #711

wants to merge 1 commit into from

Conversation

erikj79
Copy link
Member

@erikj79 erikj79 commented Oct 16, 2020 •
edited by openjdk bot

This patch adds the lldb framework to the macosx devkit to make it possible to run the lldb debugger.

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/711/head:pull/711
$ git checkout pull/711

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 16, 2020

👋 Welcome back erikj! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 16, 2020
@openjdk
Copy link

openjdk bot commented Oct 16, 2020

@erikj79 The following label will be automatically applied to this pull request:

  • build

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the build build-dev@openjdk.org label Oct 16, 2020
@mlbridge
Copy link

mlbridge bot commented Oct 16, 2020

Webrevs

@openjdk
Copy link

openjdk bot commented Oct 17, 2020 •
edited

@erikj79 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8254862: lldb in devkit doesn't work

Reviewed-by: lmesnik, mikael, ihse

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 12 new commits pushed to the master branch:

  • 011dd0d: 8254824: SignalHandlerMark have no purpose
  • 736e077: 8254178: Remove .hgignore
  • 51a865d: 8254085: javax/swing/text/Caret/TestCaretPositionJTextPane.java failed with "RuntimeException: Wrong caret position"
  • dd032b7: 8254798: Deprecate for removal an empty finalize() methods in java.desktop module
  • 272bb5d: 8253455: Record Classes javax.lang.model changes
  • c17d585: 8246774: implement Record Classes as a standard feature in Java
  • 0b3e6c5: 8194126: Regression automated Test '/open/test/jdk/javax/swing/JColorChooser/Test7194184.java' fails
  • ce1aac1: 8028707: javax/swing/JComboBox/6236162/bug6236162.java fails on azure
  • 83ea863: 8253559: The INDEX page should link to Serialized Form and Constant Values pages
  • e66c6bb: 8254349: The TestNoScreenMenuBar test should be updated
  • ... and 2 more: https://git.openjdk.java.net/jdk/compare/0570cc10b579580f37b8978f2498459bdd4c870b...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Oct 17, 2020
magicus
magicus approved these changes Oct 19, 2020
View reviewed changes
Copy link
Member

@magicus magicus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@erikj79
Copy link
Member Author

erikj79 commented Oct 19, 2020

/integrate

@openjdk openjdk bot closed this Oct 19, 2020
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 19, 2020
@openjdk
Copy link

openjdk bot commented Oct 19, 2020

@erikj79 Since your change was applied there have been 26 commits pushed to the master branch:

  • 60f63ec: 8254796: Cleanup pervasive unnecessary parameter
  • 953e472: 8254967: com.sun.net.HttpsServer spins on TLS session close
  • 1da28de: 8255009: delta apply fixes for JDK-8246774 and JDK-8253455, pushed too soon
  • a0382cd: 8253235: JFR.dump does not respect maxage parameter
  • cb7701b: 8253970: Build error: address argument to atomic builtin must be a pointer to integer or pointer ('volatile narrowOop *' invalid)
  • 4ffed32: 8254940: AArch64: Cleanup non-product thread members
  • cd66e0f: 8253877: gc/g1/TestGCLogMessages.java fails - missing "Evacuation failure" message
  • e76de18: 8223051: support loops with long (64b) trip counts
  • e9be2db: 8253453: SourceFileInfoTable should be allocated lazily
  • e10b538: 8243962: Various JVM TI tests time out using JFR on Windows
  • ... and 16 more: https://git.openjdk.java.net/jdk/compare/0570cc10b579580f37b8978f2498459bdd4c870b...master

Your commit was automatically rebased without conflicts.

Pushed as commit 52cb329.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lmesnik lmesnik lmesnik approved these changes

@magicus magicus magicus approved these changes

@vidmik vidmik vidmik approved these changes

Assignees
No one assigned
Labels
build build-dev@openjdk.org integrated Pull request has been integrated
Milestone
No milestone
4 participants
@erikj79 @lmesnik @magicus @vidmik