Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8280030: [REDO] Parallel: More precise boundary in ObjectStartArray::object_starts_in_range #7111

Closed
wants to merge 2 commits into from

Conversation

albertnetymk
Copy link
Member

@albertnetymk albertnetymk commented Jan 17, 2022

Second try in refining the range calculation in ObjectStartArray::object_starts_in_range.

Test: tier1-6


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8280030: [REDO] Parallel: More precise boundary in ObjectStartArray::object_starts_in_range

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/7111/head:pull/7111
$ git checkout pull/7111

Update a local copy of the PR:
$ git checkout pull/7111
$ git pull https://git.openjdk.java.net/jdk pull/7111/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 7111

View PR using the GUI difftool:
$ git pr show -t 7111

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/7111.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 17, 2022

👋 Welcome back ayang! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jan 17, 2022
@openjdk
Copy link

openjdk bot commented Jan 17, 2022

@albertnetymk The following label will be automatically applied to this pull request:

  • hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-gc hotspot-gc-dev@openjdk.org label Jan 17, 2022
@mlbridge
Copy link

mlbridge bot commented Jan 17, 2022

Webrevs

Copy link
Contributor

@kstefanj kstefanj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing the extra testing. Looks good.

@openjdk
Copy link

openjdk bot commented Jan 25, 2022

@albertnetymk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8280030: [REDO] Parallel: More precise boundary in ObjectStartArray::object_starts_in_range

Reviewed-by: sjohanss, tschatzl

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 154 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jan 25, 2022
Copy link
Contributor

@tschatzl tschatzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm.

@albertnetymk
Copy link
Member Author

Thanks for the review.

/integrate

@openjdk
Copy link

openjdk bot commented Jan 25, 2022

Going to push as commit 496baad.
Since your change was applied there have been 157 commits pushed to the master branch:

  • 4503d04: 8280375: G1: Tighten mem region limit in G1RebuildRemSetHeapRegionClosure
  • 36fbec7: 8280241: (aio) AsynchronousSocketChannel init fails in IPv6 only Windows env
  • 28796cb: 8163921: HttpURLConnection default Accept header is malformed according to HTTP/1.1 RFC
  • c43ce85: 8278302: [s390] Implement fast-path for ASCII-compatible CharsetEncoders
  • 1b14157: 8280274: Guard printing code of Compile::print_method in PRODUCT
  • 2155afe: 8280503: Use allStatic.hpp instead of allocation.hpp where possible
  • 295b263: 8279241: G1 Full GC does not always slide memory to bottom addresses
  • b327746: 8280384: Parallel: Remove VMThread specific ParCompactionManager
  • 5380472: 8280470: Confusing instanceof check in HijrahChronology.range
  • a59d717: 8280289: Enhance debug pp() command with NMT info
  • ... and 147 more: https://git.openjdk.java.net/jdk/compare/9e536b64705f841b224d0e64cad0f1609ebf5bca...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 25, 2022
@openjdk openjdk bot closed this Jan 25, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 25, 2022
@openjdk
Copy link

openjdk bot commented Jan 25, 2022

@albertnetymk Pushed as commit 496baad.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@albertnetymk albertnetymk deleted the redo branch January 25, 2022 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-gc hotspot-gc-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

3 participants