Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8274148: can jshell show deprecated classes, methods and fields as strikethrough text? #7130

Closed
wants to merge 3 commits into from

Conversation

lahodaj
Copy link
Contributor

@lahodaj lahodaj commented Jan 18, 2022

This adds a limited highlighting for JShell. It underlines keywords, highlights declarations and shows deprecated elements inversed (on Windows) or with fainted italic text (on other platforms).

For example, on Windows:
jshell-coloring-other

On other platforms:
screenshot-snippet-nonwin


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed
  • Change requires a CSR request to be approved

Issues

  • JDK-8274148: can jshell show deprecated classes, methods and fields as strikethrough text?
  • JDK-8280154: can jshell show deprecated classes, methods and fields as strikethrough text? (CSR)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/7130/head:pull/7130
$ git checkout pull/7130

Update a local copy of the PR:
$ git checkout pull/7130
$ git pull https://git.openjdk.java.net/jdk pull/7130/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 7130

View PR using the GUI difftool:
$ git pr show -t 7130

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/7130.diff

@lahodaj
Copy link
Contributor Author

lahodaj commented Jan 18, 2022

/csr needed

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 18, 2022

👋 Welcome back jlahoda! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added rfr Pull request is ready for review csr Pull request needs approved CSR before integration labels Jan 18, 2022
@openjdk
Copy link

openjdk bot commented Jan 18, 2022

@lahodaj this pull request will not be integrated until the CSR request JDK-8280154 for issue JDK-8274148 has been approved.

@openjdk
Copy link

openjdk bot commented Jan 18, 2022

@lahodaj The following label will be automatically applied to this pull request:

  • kulla

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the kulla kulla-dev@openjdk.org label Jan 18, 2022
@mlbridge
Copy link

mlbridge bot commented Jan 18, 2022

Webrevs

Copy link
Contributor

@vicente-romero-oracle vicente-romero-oracle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

complex change, looks sensible to me

@openjdk openjdk bot removed the csr Pull request needs approved CSR before integration label Feb 16, 2022
@openjdk
Copy link

openjdk bot commented Feb 16, 2022

@lahodaj This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8274148: can jshell show deprecated classes, methods and fields as strikethrough text?

Reviewed-by: vromero

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 163 new commits pushed to the master branch:

  • 0af356b: 8278173: [vectorapi] Add x64 intrinsics for unsigned (zero extended) casts
  • a24498b: 8281771: Crash in java_lang_invoke_MethodType::print_signature
  • 1aff44b: 8279949: JavaThread::_free_handle_block leaks native memory
  • 394ce5f: 8280825: Modules that "provide" ToolProvider should document the name that can be used
  • 745f7e7: 8281186: runtime/cds/appcds/DumpingWithNoCoops.java fails
  • 1870465: 8281744: x86: Use short jumps in TIG::set_vtos_entry_points
  • 2fe0bf6: 8281748: runtime/logging/RedefineClasses.java failed "assert(addr != __null) failed: invariant"
  • bc61484: 8280136: Serial: Remove unnecessary use of ExpandHeap_lock
  • 2112a9d: 8246033: bin/print_config.js script uses nashorn jjs tool
  • 1c12b15: 8281741: [testbug] PrintIdealPhaseTest fails with -Xcomp
  • ... and 153 more: https://git.openjdk.java.net/jdk/compare/de3113b998550021bb502cd6f766036fb8351e7d...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Feb 16, 2022
@bridgekeeper
Copy link

bridgekeeper bot commented Mar 16, 2022

@lahodaj This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@lahodaj
Copy link
Contributor Author

lahodaj commented Apr 1, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Apr 1, 2022

Going to push as commit 9156c0b.
Since your change was applied there have been 662 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Apr 1, 2022
@openjdk openjdk bot closed this Apr 1, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 1, 2022
@openjdk
Copy link

openjdk bot commented Apr 1, 2022

@lahodaj Pushed as commit 9156c0b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated kulla kulla-dev@openjdk.org
2 participants