-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8278475: G1 dirty card refinement by Java threads may get unnecessarily paused #7148
8278475: G1 dirty card refinement by Java threads may get unnecessarily paused #7148
Conversation
👋 Welcome back kbarrett! A progress list of the required criteria for merging this PR into |
@kimbarrett The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
Webrevs
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm.
@kimbarrett This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm!
/integrate |
Going to push as commit 1f6fcbe. |
@kimbarrett Pushed as commit 1f6fcbe. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Please review this change to avoid attempts to refine dirty cards by Java
threads when there is an active STS yield request, as the attempt will just
end up being paused. When going into a safepoint this avoids wasted work and
transfer of buffers into the paused list. More importantly, when coming out
of a pause this avoids deferring buffers to after the next safepoint, due to
the yield request being cleared after Java threads are restarted.
Testing:
mach5 tier1
Lots of testing as part of investigation of JDK-8273383.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/7148/head:pull/7148
$ git checkout pull/7148
Update a local copy of the PR:
$ git checkout pull/7148
$ git pull https://git.openjdk.java.net/jdk pull/7148/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 7148
View PR using the GUI difftool:
$ git pr show -t 7148
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/7148.diff