Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8278475: G1 dirty card refinement by Java threads may get unnecessarily paused #7148

Closed

Conversation

kimbarrett
Copy link

@kimbarrett kimbarrett commented Jan 19, 2022

Please review this change to avoid attempts to refine dirty cards by Java
threads when there is an active STS yield request, as the attempt will just
end up being paused. When going into a safepoint this avoids wasted work and
transfer of buffers into the paused list. More importantly, when coming out
of a pause this avoids deferring buffers to after the next safepoint, due to
the yield request being cleared after Java threads are restarted.

Testing:
mach5 tier1

Lots of testing as part of investigation of JDK-8273383.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8278475: G1 dirty card refinement by Java threads may get unnecessarily paused

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/7148/head:pull/7148
$ git checkout pull/7148

Update a local copy of the PR:
$ git checkout pull/7148
$ git pull https://git.openjdk.java.net/jdk pull/7148/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 7148

View PR using the GUI difftool:
$ git pr show -t 7148

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/7148.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 19, 2022

👋 Welcome back kbarrett! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jan 19, 2022
@openjdk
Copy link

openjdk bot commented Jan 19, 2022

@kimbarrett The following label will be automatically applied to this pull request:

  • hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-gc hotspot-gc-dev@openjdk.org label Jan 19, 2022
@mlbridge
Copy link

mlbridge bot commented Jan 19, 2022

Webrevs

Copy link
Contributor

@tschatzl tschatzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm.

@openjdk
Copy link

openjdk bot commented Jan 20, 2022

@kimbarrett This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8278475: G1 dirty card refinement by Java threads may get unnecessarily paused

Reviewed-by: tschatzl, iwalulya

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jan 20, 2022
Copy link
Member

@walulyai walulyai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

@kimbarrett
Copy link
Author

Thanks @walulyai and @tschatzl for reviews.

@kimbarrett
Copy link
Author

/integrate

@openjdk
Copy link

openjdk bot commented Feb 1, 2022

Going to push as commit 1f6fcbe.

@openjdk openjdk bot added the integrated Pull request has been integrated label Feb 1, 2022
@openjdk openjdk bot closed this Feb 1, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Feb 1, 2022
@openjdk
Copy link

openjdk bot commented Feb 1, 2022

@kimbarrett Pushed as commit 1f6fcbe.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@kimbarrett kimbarrett deleted the no-dequeue-when-should-yield branch February 1, 2022 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-gc hotspot-gc-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

3 participants