Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8198395: Test javax/swing/plaf/metal/MetalLookAndFeel/Test8039750.java fails in mach5 #715

Closed
wants to merge 3 commits into from

Conversation

prsadhuk
Copy link
Contributor

@prsadhuk prsadhuk commented Oct 17, 2020

Please review a test fix for an issue seen to be failing in mach5.
Test is stabilised by making the test run under EDT.
Mach5 job was run for several iteration on all 3 platforms. Link in JBS


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Testing

Linux x32 Linux x64 Windows x64 macOS x64
Build (1/1 running) (5/5 running) (2/2 running) (2/2 running)

Issue

  • JDK-8198395: Test javax/swing/plaf/metal/MetalLookAndFeel/Test8039750.java fails in mach5

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/715/head:pull/715
$ git checkout pull/715

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 17, 2020

👋 Welcome back psadhukhan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Oct 17, 2020

@prsadhuk The following label will be automatically applied to this pull request:

  • swing

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the swing client-libs-dev@openjdk.org label Oct 17, 2020
@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 17, 2020
@mlbridge
Copy link

mlbridge bot commented Oct 17, 2020

Webrevs

prrace
prrace approved these changes Oct 19, 2020
@openjdk
Copy link

openjdk bot commented Oct 19, 2020

@prsadhuk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8198395: Test javax/swing/plaf/metal/MetalLookAndFeel/Test8039750.java fails in mach5

Reviewed-by: prr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Oct 19, 2020
@prsadhuk
Copy link
Contributor Author

/integrate

@openjdk openjdk bot closed this Oct 22, 2020
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 22, 2020
@openjdk
Copy link

openjdk bot commented Oct 22, 2020

@prsadhuk Pushed as commit 299e115.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@prsadhuk prsadhuk deleted the JDK-8198395 branch Oct 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated swing client-libs-dev@openjdk.org
2 participants