-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JDK-8280373: Update Xalan serializer / SystemIDResolver to align with JDK-8270492 #7155
Conversation
👋 Welcome back mbaesken! A progress list of the required criteria for merging this PR into |
Webrevs
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@MBaesken This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 63 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
It would be useful if Joe Wang can review this, just in case the security changes did not touch this code for some reason. |
Thanks Alan for the reminder. The change looks good. Please add a copyright header and the LastModified tag as the other class did. |
Hi, I added the header and LastModified. |
/integrate |
Going to push as commit c180070.
Your commit was automatically rebased without conflicts. |
After 8270492
78b2c84
has been pushed, we should adjust src/java.xml/share/classes/com/sun/org/apache/xml/internal/serializer/utils/SystemIDResolver.java getAbsoluteURI to what has been done in 8270492 to src/java.xml/share/classes/com/sun/org/apache/xml/internal/utils/SystemIDResolver.java
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/7155/head:pull/7155
$ git checkout pull/7155
Update a local copy of the PR:
$ git checkout pull/7155
$ git pull https://git.openjdk.java.net/jdk pull/7155/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 7155
View PR using the GUI difftool:
$ git pr show -t 7155
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/7155.diff